From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)' Date: Mon, 18 Feb 2013 09:24:46 -0800 Message-ID: <220CC265C06944E69F89E1F29796C873@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1361295313 26448 80.91.229.3 (19 Feb 2013 17:35:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Feb 2013 17:35:13 +0000 (UTC) To: 13764@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 19 18:35:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U7r6M-0001MM-9q for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Feb 2013 18:35:34 +0100 Original-Received: from localhost ([::1]:59866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7r62-0002oi-2M for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Feb 2013 12:35:14 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7r5p-0002iA-7D for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2013 12:35:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7r5k-0005gu-A3 for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2013 12:35:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7r5k-0005gb-6N for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2013 12:34:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U7r6n-0000LE-UJ for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2013 12:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Feb 2013 17:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.13612953051247 (code B ref -1); Tue, 19 Feb 2013 17:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Feb 2013 17:35:05 +0000 Original-Received: from localhost ([127.0.0.1]:37228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7r5r-0000K2-SJ for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:35:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58015) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7r5o-0000Jc-4b for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:35:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7r4g-0005Go-4H for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:33:53 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:50715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7Ugl-00042s-PU for submit@debbugs.gnu.org; Mon, 18 Feb 2013 12:39:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7USa-0002o5-Rl for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2013 12:25:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7USR-0007xL-H4 for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2013 12:25:00 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:44074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7USR-0007wf-BM for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2013 12:24:51 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1IHOnwv011113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Feb 2013 17:24:50 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1IHOmmI003480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 18 Feb 2013 17:24:48 GMT Original-Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1IHOmH1014020 for ; Mon, 18 Feb 2013 11:24:48 -0600 Original-Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Feb 2013 09:24:47 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac4N/NkwKvP8kyu3REGPoyC8eCU9tA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71522 Archived-At: These are not tiny, trivial functions. They do not fit the criteria for `defsubst' outlined in (elisp) `Inline Functions'. And they introduce all of the disadvantages listed there, especially this one, listed first: [I]f you change the definition of the function, calls already inlined still use the old definition until you recompile them. One use case: I have highlighting code that uses text property `font-lock-ignore'. I modify a few font-lock.el functions so that text that has this property is ignored. IOW, this property tells font-lock "Hands off", so that it will not erase of otherwise interfere with such highlighting. I see no reason why these function should not be defuns. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-02-17 on VBOX-W7 Bzr revision: 111822 rgm@gnu.org-20130217190146-mm9bh3227ev56bus Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/emacs/libs/libXpm-3.5.10/include -IC:/emacs/libs/libXpm-3.5.10/src -IC:/emacs/libs/libpng-dev_1.4.3-1_win32/include -IC:/emacs/libs/zlib-dev_1.2.5-2_win32/include -IC:/emacs/libs/giflib-4.1.4-1-lib/include -IC:/emacs/libs/jpeg-6b-4-lib/include -IC:/emacs/libs/tiff-3.8.2-1-lib/include -IC:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2 -IC:/emacs/libs/gnutls-3.1.8-w32/include -IC:/emacs/libs/libiconv-1.14-2-mingw32-dev/include'