From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#71766: 30.0.60; HarfBuzz is not used in the Cygwin-w32 build Date: Mon, 24 Jun 2024 21:18:31 -0400 Message-ID: <22087552-7262-4963-ae11-60ed0895221c@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13655"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 71766@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 25 03:19:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLuq8-0003L8-Vu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jun 2024 03:19:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLupr-00047D-KQ; Mon, 24 Jun 2024 21:19:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLupp-00046g-Ev for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 21:19:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLupp-0003G5-6L for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 21:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLupq-00046l-BG for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 21:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2024 01:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71766 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171927832715766 (code B ref -1); Tue, 25 Jun 2024 01:19:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jun 2024 01:18:47 +0000 Original-Received: from localhost ([127.0.0.1]:35854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLupa-00046E-T2 for submit@debbugs.gnu.org; Mon, 24 Jun 2024 21:18:47 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLupY-000465-2E for submit@debbugs.gnu.org; Mon, 24 Jun 2024 21:18:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLupW-000448-BZ for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 21:18:42 -0400 Original-Received: from mail-sn1nam02on20724.outbound.protection.outlook.com ([2a01:111:f400:7ea9::724] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLupU-0003DW-5W for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 21:18:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g3Dcu8aASAJjW06sSovnT9+aYIuHazua5BMcV6nlzcVbcHsmozzoWCABJbT3YbleH8/dEEd+4ro9Ez2vqeGFNdcJCRkagvuWmknygvwf+jofBmnaWXDh7toLgM1OrEQCqAwAGcDBm90hwwZmO9c6gS2CbQo6/KiaXYJN5UcNNT7mGY1ALoFyw7Ie46kzKy8uKkCbtIwCtJVSdPgTGmfHtfNfY7Pp70vmVetMayNEYilJElgzZTNJ7vxkAJqsX5Kkx8JphYoz6mKokRrEcW9t/uchkWcj/7JJLa2ReQ2/irYr1ZE1JQN8EtLfgf2QvVatCob5Hv8u/moctkEQ+lNa9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIFtNRpOz+2wk/EFf48A4A78XDi0GF7dwlRljwSanaQ=; b=Xc/8ixzfaSF6efpo8wDslonEA3ay7IXz/NtG4Jfi2/6GZoOSYwyj6Tk+0jAr6v7LjfPcaHyUOKdpj2egeBfUvS/69v6RxcvJiTa9Y4QPVoEowJEDAUeRzckJajBDWyzST7ujEj2P7W1/by06GXJvhN5rM0GbRV+F8nOkCV0QJptME44G60q+kp4tyXZccAFLSRZum1Trfly7fMrFicNTB0UDkEtDibiWwaVYA5YvmdGt2umC28CYeB57y4Jv/QHLhuuL/HPoYbjdZnjdHDIGmVNdqidXCdfbIZWPMyd2PuzpbBAwRU3pLy95YjBieIyhowAfprjgdS2hN5xiKCWTQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TIFtNRpOz+2wk/EFf48A4A78XDi0GF7dwlRljwSanaQ=; b=A3uQVfS2vgywnqKr5Uiu6aVg7zPEFvXTBfqKjsmIR5r90uit50reYVzy6Q6tY9eod/T8tYpU+zKfLtMDM23JYGT0c9+BMpFDJNmHYSh1w7+RImVoXNr3zFSUf+9sM9bFV3lELYUUTCo0vc45Q/RZvbLRIHgLdLWuUEHxlGMm4Zc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BL0PR04MB5140.namprd04.prod.outlook.com (2603:10b6:208:56::10) by DM8PR04MB7878.namprd04.prod.outlook.com (2603:10b6:8:36::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Tue, 25 Jun 2024 01:18:36 +0000 Original-Received: from BL0PR04MB5140.namprd04.prod.outlook.com ([fe80::2367:e361:918a:2c39]) by BL0PR04MB5140.namprd04.prod.outlook.com ([fe80::2367:e361:918a:2c39%3]) with mapi id 15.20.7698.025; Tue, 25 Jun 2024 01:18:35 +0000 Content-Language: en-US X-ClientProxiedBy: BL0PR05CA0026.namprd05.prod.outlook.com (2603:10b6:208:91::36) To BL0PR04MB5140.namprd04.prod.outlook.com (2603:10b6:208:56::10) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR04MB5140:EE_|DM8PR04MB7878:EE_ X-MS-Office365-Filtering-Correlation-Id: 75429a8e-2e85-4f1b-1972-08dc94b4bc6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|1800799021|376011; X-Microsoft-Antispam-Message-Info: Kda5/8aE8Ksf4S9R1Nf+HytV1yRrtXqw/YD/m3aksjyEBEotO21CtiPj4QZOczREtxzcuozxSVduc5PiF7lgw50x8SbfiE8eGayEADn6PIVtVNvnnpIsr1JbYmDUMabwteK4vpkbvi4geVp19ogRpuCd667/YTK286/n8omGws0A162cD9zMX3pkBuSd11EmZbKxJL07sdISEWahXD9Z3aCFoKhHtTySu8nQyEZdQFIYAXykrr2oOlwS8LAVWJafeauPCn5aZFkNaNvLJSkCzO/OONTVLy1xBrNJAFFvf6AqXsgGaDhQ+d1dgcIglMzJz7yCR8Yyw7xt/m71UmQgX6L6f+1U7oLQ1bSfQx92Ajy/ng+LrJ9B3Q7NLjIDzMgvqSYMonBGieiaHoTHR+yP8a8MExkKoMD1sgw/lbf6iuv1bvnPMfsNGYPJQjJXWzT6uYcGruOQEjW+0f6/PG/DcYhXWXbbEthJ1gBlhFhrgr1MUHpXyRB2u72xA+ruvhEGWmZ4eivQHxFbtUUrNnV1i+0ful27VIl3hRG3XtLcCaITgDAHn5NtQ55WGt4IyZ2WXSRmCRjFpYtBgC28wjrX8rdHssxDvMLzos86CK0Q+laHmULhKG7/icV86ac4mpCqmvmlkCiWKhm2jja3yGut6BWUH2RAbTqyYGvKK2JRJVUMA/TyrAK96O5zqKMtUr3kOek342r6r3aNh1IyncQKwl3owR7iIiLRBOhcuKzCxf2Cl+DEJ8BaaGRJoCAaE 8lAugORDg9YHuZkhU/ys3GOE9cyeil75QUKxvcYXW/5GBSbdJjZ0Npgh/cqw+ltpAyAgCoyoM1ExyWm7TqFz1NSLpDt9mWFFc4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR04MB5140.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(1800799021)(376011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nDXQu89IIU7EXVaqF5zlHTr9DwTIoYsUBboniZPT0artNCAidYW1FuI43cdIX2MO/5LEmkiOpUqi87YSHkwPyBZ3rKlxXrIN9ZgKhT1pPiCF2R3oUPb5REn/Y/xR4ybH3ir9cVa0arUz4uiqJbyy6mDanM/zWYS+V9BVIZZojXS6mWiu5rXwpOVd1AHXJ00oM1jMI5wc2wgG9skMss+ZnXpev68QBS1zx6+C0NrgjeNzTtaMVI8HU0RuN5fyW+dS60cDJKmuODxSzIJaPs86JOGTs5GwKFGKVv8UTgk1XOviSYNddqWpWUW6si7OQPx3RPqxylehHXHx3nbHqGqVPzq7dLHargiLDuRpRFUEw4kWMCM+Rab9Y55ydutHW8mIfd+OLelFYf8hBbeuW24EZMvR01K93DNoBMTAx7KwG0IfsNWmaWZbr7VZH2BKyDhx5Y3LhjW7l3YjrlSMSJ2IyZFaGRhLz3lDMtEabKxrtKGdr9jkxG/h6xpGLqodt8VskqT3NFWM22V9GKF8QfRaTRu+qV/NtTQmhqK/Xi/EFHcf3QX6czZ1K5lqHkZ/q0kOxWnSvMySn1qMFCEj+DyyN2i8IUYjPL8er2UWCtrE01IUaxuRYDZSCPrpAKGvfoqufR2yguO/dbA4Kjz7SI7GiXSQmomWspoMutkCwunCqZcMxGclQgjqR+4S+vVASM6SiNHt2TNscX9o8RmlBW03ecdzNCnFocdAClYHW/+QE31+Pg2U5BL3mG/a+9 9P1f2ZD8IgsPoxAsaMsY392RDHaBmfddi98hoqmylGqFMSvQ9DqcmdJ4nZP2srLqMylRChqFe4LBu2mMuPcpkUDhDf2bmPjpwn X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 75429a8e-2e85-4f1b-1972-08dc94b4bc6a X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB5140.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2024 01:18:35.7002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JLglxqm03xIt736nC6pusNTLp3P8RzQeVTFfreSqwSv3iPQNtTlWOForkoVPsUkeqvF8ViYn36QE6d4tTnR7uQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR04MB7878 Received-SPF: pass client-ip=2a01:111:f400:7ea9::724; envelope-from=kbrown@cornell.edu; helo=NAM02-SN1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287865 Archived-At: The HarfBuzz library is hard-coded as libharfbuzz-0.dll in w32uniscribe.c, but this is only valid on MS-Windows. On Cygwin the library is cygharfbuzz-0.dll. As a result, HarfBuzz is not used in the Cygwin-w32 build. The obvious fix is diff --git a/src/w32uniscribe.c b/src/w32uniscribe.c index b3112912c767..dacd6dd766ed 100644 --- a/src/w32uniscribe.c +++ b/src/w32uniscribe.c @@ -1527,12 +1527,17 @@ syms_of_w32uniscribe_for_pdumper (void) uniscribe_new_apis = false; #ifdef HAVE_HARFBUZZ - /* Currently, HarfBuzz DLLs are always named libharfbuzz-0.dll, as + /* Currently, HarfBuzz DLLs are always named libharfbuzz-0.dll on + MS-Windows and cygharfbuzz-0.dll on Cygwin, as the project keeps the ABI backward-compatible. So we can hard-code the name of the library here, for now. If they ever break ABI compatibility, we may need to load the DLL that corresponds to the HarfBuzz version for which Emacs was built. */ +# ifdef WINDOWSNT HMODULE harfbuzz = LoadLibrary ("libharfbuzz-0.dll"); +# else /* CYGWIN */ + HMODULE harfbuzz = LoadLibrary ("cygharfbuzz-0.dll"); +# endif /* CYGWIN */ /* Don't register if HarfBuzz is not available. */ if (!harfbuzz) return; Before pushing this, I'd like to test it, but I don't know enough about HarfBuzz to do that. Can someone tell me how to test that HarfBuzz is actually being used as intended? All I've done so far is to start emacs and note that the display looks reasonable. Ken P.S. I had a problem sending this email the first time I tried. I apologize in advance if I ended up sending it twice.