unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: 71766@debbugs.gnu.org
Subject: bug#71766: 30.0.60; HarfBuzz is not used in the Cygwin-w32 build
Date: Mon, 24 Jun 2024 21:18:31 -0400	[thread overview]
Message-ID: <22087552-7262-4963-ae11-60ed0895221c@cornell.edu> (raw)

The HarfBuzz library is hard-coded as libharfbuzz-0.dll in 
w32uniscribe.c, but this is only valid on MS-Windows.  On Cygwin the 
library is cygharfbuzz-0.dll.  As a result, HarfBuzz is not used in the 
Cygwin-w32 build.  The obvious fix is

diff --git a/src/w32uniscribe.c b/src/w32uniscribe.c
index b3112912c767..dacd6dd766ed 100644
--- a/src/w32uniscribe.c
+++ b/src/w32uniscribe.c
@@ -1527,12 +1527,17 @@ syms_of_w32uniscribe_for_pdumper (void)
      uniscribe_new_apis = false;

  #ifdef HAVE_HARFBUZZ
-  /* Currently, HarfBuzz DLLs are always named libharfbuzz-0.dll, as
+  /* Currently, HarfBuzz DLLs are always named libharfbuzz-0.dll on
+     MS-Windows and cygharfbuzz-0.dll on Cygwin, as
       the project keeps the ABI backward-compatible.  So we can
       hard-code the name of the library here, for now.  If they ever
       break ABI compatibility, we may need to load the DLL that
       corresponds to the HarfBuzz version for which Emacs was built.  */
+# ifdef WINDOWSNT
    HMODULE harfbuzz = LoadLibrary ("libharfbuzz-0.dll");
+# else /* CYGWIN */
+  HMODULE harfbuzz = LoadLibrary ("cygharfbuzz-0.dll");
+# endif /* CYGWIN */
    /* Don't register if HarfBuzz is not available.  */
    if (!harfbuzz)
      return;

Before pushing this, I'd like to test it, but I don't know enough about 
HarfBuzz to do that.  Can someone tell me how to test that HarfBuzz is 
actually being used as intended?  All I've done so far is to start emacs 
and note that the display looks reasonable.

Ken

P.S. I had a problem sending this email the first time I tried.  I 
apologize in advance if I ended up sending it twice.





             reply	other threads:[~2024-06-25  1:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  1:18 Ken Brown [this message]
2024-06-25  2:34 ` bug#71766: 30.0.60; HarfBuzz is not used in the Cygwin-w32 build Eli Zaretskii
2024-06-25 15:36   ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22087552-7262-4963-ae11-60ed0895221c@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=71766@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).