From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Wed, 7 Oct 2020 08:42:10 -0700 (PDT) Message-ID: <21c5738b-e9f2-465f-9ca3-8947a5b9191d@default> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <871riav4os.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Lars Ingebrigtsen , 43702@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 17:43:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQBbF-0009Le-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 17:43:29 +0200 Original-Received: from localhost ([::1]:48054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQBbE-00013z-CE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 11:43:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQBao-00013Q-Qu for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 11:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQBao-0006TZ-IJ for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 11:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQBao-0006wz-Gx for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 11:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.160208534426667 (code B ref 43702); Wed, 07 Oct 2020 15:43:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 7 Oct 2020 15:42:24 +0000 Original-Received: from localhost ([127.0.0.1]:57767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQBaC-0006w3-Je for submit@debbugs.gnu.org; Wed, 07 Oct 2020 11:42:24 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:56992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQBaA-0006vr-To for 43702@debbugs.gnu.org; Wed, 07 Oct 2020 11:42:24 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 097FY4V7098379; Wed, 7 Oct 2020 15:42:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ECTcgxJti1qhjvJqZ+EfhS8sJD6Pbkhs4f7LyLB2JeY=; b=kBKG0LlfsW8UblYoOy4s6rR6DCvpeXbqEwoPdApzNbGfS1IcHIsz6xcKUMj9pvwh25Rc GzzKGRvO9/CQBVwrHzsz2iQHq5fnl496NRBrRwwbO6I/YDs2jSVpfLYP6O9mJgyv9EjK HjalV4DSNC5u9ivauYC4Awahz4wBLfxnm2ZlfxIU0Aj1LKwaiUgYE+3IMgrT5LEOd+yC Mssn9ABPpn9Du59ZnGyUo0Q2b2E2EqZgukqpWZmh+8kQVG0FQsXIJ44ZmoNR92gQyjzZ 4IKcap8z/wpb36F/WOx/vZyb8davJ+u1dCNXbVjW0yueq2wUcIRdfZkH84UbgtsQU+cP lQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 33ym34qnwu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 07 Oct 2020 15:42:16 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 097FZHJ9008665; Wed, 7 Oct 2020 15:42:15 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 33yyjhc75h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Oct 2020 15:42:15 +0000 Original-Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 097FgBMj016170; Wed, 7 Oct 2020 15:42:11 GMT In-Reply-To: <871riav4os.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9767 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070099 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9767 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070099 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190040 Archived-At: > > I don't agree, but won't argue about it. I redefined > > `replace-highlight' and `replace-dehighlight' so they > > do highlight regexp groups, and I think it's helpful. >=20 > After query-replace is started, the regexp is already created > (either with the help of isearch group submatches highlighting > or typed directly on the query-replace prompt), so during replacements > the user has only to decide for each match whether to replace it or not > by answering the y/n question for the currently highlighted regexp. >=20 > How highlighting the replacement submatches will help the user to decide > whether to replace the current match or not? Whether to replace a given match is not the only thing a user can do - not the only thing to decide/consider. Highlighting groups helps you see _how_ a regexp matches. And you can always change a regexp and search/replace again, if it's either not matching something you want to match or matching too many things you don't want to match. It's helpful in pretty much any context where regexps are matched against text, IMO.