From: Yuan Fu <casouri@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: eliz@gnu.org, 58431@debbugs.gnu.org
Subject: bug#58431: 29.0.50; [Eglot] Add "breadcrumb.el" feature based on imenu.el/project.el services
Date: Tue, 11 Oct 2022 08:38:30 -0700 [thread overview]
Message-ID: <21C0D090-6EE1-45EB-B23A-8BECDD5A9447@gmail.com> (raw)
In-Reply-To: <87czayra73.fsf@gmail.com>
> In the original Eglot request, users are requesting this UI feature for
> the Eglot LSP client. But this doesn't have any LSP-specific
> interactions. It can and should be done entirely by using the services
> provided by imenu.el and project.el.
>
> Eglot already integrates with Imenu, so as soon as this hypothetical
> breadcrumb.el is in place, then Eglot users can take advantage of it.
>
> This is similar to which-func.el, which displays the trailing element of
> the breadcrumb in the headerline. Perhaps the breadcrumb feature can be
> thought of as an augmentation of which-func.el's functionality. I don't
> have a strong opinion there.
I think which-func is closer to breadcrumb conceptually and api-wise: Both which-func and breadcrumb are about the current function, while imenu is about a list of _all_ functions/sections. We could just allow which-func-function to accept a list of function names. In fact, the which-func function of tree-sitter powered python.el already generates a breadcrumb, I just joined all the function names along the path with “/“.
>
> João
>
> PS: Eli, I'm CCing you to underline this as just an example of a UI
> feature that is requested for Eglot, but belongs somewhere else. In
> this case, I believe there is 0 additional integration needed in
> eglot.el: it can be realized independently of the backend which feeds
> into Imenu (perhaps tree-sitter?) and project.el.
I agree, Emacs provides the framework/UI, and tree-sitter/eglot/future magic plug in.
Yuan
next prev parent reply other threads:[~2022-10-11 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 9:17 bug#58431: 29.0.50; [Eglot] Add "breadcrumb.el" feature based on imenu.el/project.el services João Távora
2022-10-11 15:38 ` Yuan Fu [this message]
2022-10-11 23:50 ` João Távora
2022-10-12 6:22 ` Yuan Fu
2022-10-12 8:30 ` João Távora
2023-05-12 13:09 ` João Távora
2023-05-17 21:31 ` Yuan Fu
2023-04-08 19:47 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-18 18:10 ` bug#58431: 29.0.50; [Eglot] Add "breadcrumb.el" feature based, " Adam Porter
2023-04-18 18:26 ` João Távora
2023-04-20 4:27 ` Adam Porter
2023-04-20 9:22 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21C0D090-6EE1-45EB-B23A-8BECDD5A9447@gmail.com \
--to=casouri@gmail.com \
--cc=58431@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).