From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37840@debbugs.gnu.org, konrad.podczeck@univie.ac.at, juri@linkov.net
Subject: bug#37840: Missing in the Emacs manuals:
Date: Thu, 14 Nov 2019 19:18:48 +0100 [thread overview]
Message-ID: <219b929b-ea87-7a50-081e-652e87ed25f0@gmx.at> (raw)
In-Reply-To: <83mucy7p1z.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
> That seems unfortunate. Can we somehow make Speedbar insulated from
> the switch-to-buffer customizations?
The attached patch should do that. But there are probably too many
similar cases out there. Strictly spoken we should check each of our
'switch-to-buffer' calls for whether to
(1) convert it to 'set-window-buffer' (so no customization ever
affects it),
(2) bind 'switch-to-buffer-obey-display-actions' to nil around it (to
bow out comme il faut when the window is a minibuffer window or
dedicated to its buffer),
(3) call 'pop-to-buffer-same-window' instead, or
(4) leave it alone.
martin
[-- Attachment #2: dframe.diffs --]
[-- Type: text/plain, Size: 903 bytes --]
--- a/lisp/dframe.el
+++ b/lisp/dframe.el
@@ -309,8 +309,8 @@ dframe-frame-mode
(make-frame-visible (symbol-value frame-var))
(select-frame (symbol-value frame-var))
(set-window-dedicated-p (selected-window) nil)
- (if (not (eq (current-buffer) (symbol-value buffer-var)))
- (switch-to-buffer (symbol-value buffer-var)))
+ (unless (eq (current-buffer) (symbol-value buffer-var))
+ (set-window-buffer nil (symbol-value buffer-var)))
(set-window-dedicated-p (selected-window) t)
(raise-frame (symbol-value frame-var))
)
@@ -346,7 +346,7 @@ dframe-frame-mode
;; Put the buffer into the frame
(save-excursion
(select-frame (symbol-value frame-var))
- (switch-to-buffer (symbol-value buffer-var))
+ (set-window-buffer nil (symbol-value buffer-var))
(set-window-dedicated-p (selected-window) t))
;; Run hooks (like reposition)
(run-hooks create-hook)
next prev parent reply other threads:[~2019-11-14 18:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 0:39 bug#37840: Missing in the Emacs manuals: Konrad Podczeck
2019-10-22 8:43 ` martin rudalics
2019-10-23 7:25 ` Konrad Podczeck
2019-10-23 7:46 ` martin rudalics
2019-10-28 17:37 ` Konrad Podczeck
2019-10-28 18:13 ` martin rudalics
2019-10-28 19:04 ` Konrad Podczeck
2019-10-29 9:28 ` martin rudalics
2019-10-30 0:56 ` Konrad Podczeck
2019-10-30 8:14 ` martin rudalics
2019-10-30 20:37 ` Konrad Podczeck
2019-10-31 7:59 ` martin rudalics
2019-11-02 21:47 ` Konrad Podczeck
2019-11-04 9:06 ` martin rudalics
2019-11-04 11:20 ` Konrad Podczeck
2019-11-04 18:27 ` martin rudalics
[not found] ` <A8BBF7A4-BFE0-44BB-BCB3-B26477FFC946@univie.ac.at>
2019-11-04 19:10 ` martin rudalics
2019-11-06 22:41 ` Juri Linkov
2019-11-07 8:39 ` martin rudalics
2019-11-07 21:58 ` Juri Linkov
2019-11-08 9:20 ` martin rudalics
2019-11-08 11:04 ` Konrad Podczeck
2019-11-08 18:27 ` martin rudalics
2019-11-08 21:12 ` Konrad Podczeck
2019-11-09 9:01 ` martin rudalics
2019-11-10 16:44 ` Konrad Podczeck
2019-11-10 18:33 ` martin rudalics
2019-11-14 10:03 ` Eli Zaretskii
2019-11-14 18:18 ` martin rudalics [this message]
2019-11-14 18:35 ` Eli Zaretskii
2019-11-15 8:50 ` martin rudalics
2019-11-22 13:09 ` Konrad Podczeck
2019-11-22 17:49 ` martin rudalics
2019-11-22 19:22 ` Eli Zaretskii
2019-11-23 1:42 ` Konrad Podczeck
2019-11-23 8:16 ` martin rudalics
2019-11-25 23:47 ` Konrad Podczeck
2019-11-26 9:32 ` martin rudalics
2019-12-02 1:35 ` Konrad Podczeck
2019-12-02 9:41 ` martin rudalics
2019-11-23 8:15 ` martin rudalics
2019-11-23 9:49 ` Eli Zaretskii
2019-11-26 9:31 ` martin rudalics
2019-11-26 9:42 ` martin rudalics
2020-09-20 11:12 ` Lars Ingebrigtsen
2019-11-10 20:11 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=219b929b-ea87-7a50-081e-652e87ed25f0@gmx.at \
--to=rudalics@gmx.at \
--cc=37840@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=konrad.podczeck@univie.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).