unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Olivier Certner <ocert.dev@free.fr>
To: 44100@debbugs.gnu.org
Subject: bug#44100: Patch
Date: Wed, 21 Oct 2020 12:08:47 +0200	[thread overview]
Message-ID: <21986473.sr7ieKrsik@ravel> (raw)
In-Reply-To: <4578382.cRamKGfW39@ravel>

[-- Attachment #1: Type: text/plain, Size: 36 bytes --]

	In attachment.

-- 
Olivier Certner

[-- Attachment #2: 0001-ERC-Make-IBuffer-ERC-s-custom-displays-work-again.patch --]
[-- Type: text/x-patch, Size: 1495 bytes --]

From 33586f449fdf646fbfb1aa6bd5ef6ca4c4848761 Mon Sep 17 00:00:00 2001
From: Olivier Certner <ocert.dev@free.fr>
Date: Tue, 20 Oct 2020 18:36:25 +0200
Subject: [PATCH] ERC: Make IBuffer ERC's custom displays work again

* lisp/erc/erc-ibuffer.el (erc-modified): Don't use `length' on
dotted lists (and not even to test if there is more than one
element, for that matter). Use `cdr' instead.
---
 ChangeLog.3             | 8 ++++++++
 lisp/erc/erc-ibuffer.el | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog.3 b/ChangeLog.3
index ec2d3f8d46..86579b3913 100644
--- a/ChangeLog.3
+++ b/ChangeLog.3
@@ -1,3 +1,11 @@
+2020-10-20  Olivier Certner  <ocert.dev@free.fr>
+
+	ERC: Make IBuffer ERC's custom displays work again
+
+	* lisp/erc/erc-ibuffer.el (erc-modified): Don't use `length' on
+	dotted lists (and not even to test if there is more than one
+	element, for that matter). Use `cdr' instead.
+
 2020-08-03  Phil Sainty  <psainty@orcon.net.nz>
 
 	lisp/so-long.el: Improve support for major mode hooks
diff --git a/lisp/erc/erc-ibuffer.el b/lisp/erc/erc-ibuffer.el
index 7aee7705ff..955b022177 100644
--- a/lisp/erc/erc-ibuffer.el
+++ b/lisp/erc/erc-ibuffer.el
@@ -77,7 +77,7 @@
 	   erc-track-mode)
       (let ((entry (assq (current-buffer) erc-modified-channels-alist)))
 	(if entry
-	    (if (> (length entry) 1)
+	    (if (cdr entry)
 		(cond ((eq 'pal (nth 1 entry))
 		       (string erc-ibuffer-pal-char))
 		      ((eq 'fool (nth 1 entry))
-- 
2.24.1


  reply	other threads:[~2020-10-21 10:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 16:39 bug#44100: 26.3; ERC: Make IBuffer custom display work again Olivier Certner
2020-10-21 10:08 ` Olivier Certner [this message]
2020-10-21 15:54   ` bug#44100: Patch Corwin Brust
     [not found]   ` <CAJf-WoRBf-TNXSopiUnugOgAj_GAnJsRjkbuwBXRc-m4EB7-Jw@mail.gmail.com>
2020-10-31 19:54     ` Amin Bandali
     [not found]     ` <87imaquq6z.fsf@gnu.org>
2020-11-01  2:16       ` Amin Bandali
     [not found]       ` <875z6pu8h5.fsf@gnu.org>
2020-11-01 13:09         ` Lars Ingebrigtsen
     [not found]         ` <87mu01cjfh.fsf@gnus.org>
2020-11-03  2:38           ` Amin Bandali
     [not found]           ` <87lffjf9lu.fsf@gnu.org>
2020-11-05 16:38             ` Olivier Certner
2020-11-07 14:54               ` Amin Bandali
2021-06-04 10:07                 ` bug#44100: 26.3; ERC: Make IBuffer custom display work again Lars Ingebrigtsen
     [not found]                 ` <87v96ux7rc.fsf_-_@gnus.org>
2021-06-04 19:58                   ` bandali
     [not found]                   ` <1946874.pO33bOzxCm@ravel>
2021-08-03  2:52                     ` Amin Bandali
2021-07-06 12:06 ` bug#44100: Updated patch Olivier Certner
2021-07-06 14:29 ` bug#44100: On Amin's proposed change Olivier Certner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21986473.sr7ieKrsik@ravel \
    --to=ocert.dev@free.fr \
    --cc=44100@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).