From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74637: [PATCH] Make view-read-only behave like view-file Date: Tue, 03 Dec 2024 21:39:00 +0200 Message-ID: <21973.3555147954$1733254834@news.gmane.org> References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17919"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andrea Corallo , 74637@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 03 20:40:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIYkx-0004R2-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Dec 2024 20:40:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIYkk-0000zX-KQ; Tue, 03 Dec 2024 14:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIYkd-0000mX-F5 for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 14:40:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIYkd-0003ZH-4R for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 14:40:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Y5P+2p2NmAjYL0dBeOmJa+L+FPOSXHJoQANlTKX9v9Q=; b=G2VHp7TU/kAxGcptg0k2y62rEHBNs+G+3HEHp9syHL+3w3BqdoTOuvXNQALrJ4DnqA0TvK1A2sP8bM3Bq/K3131FPGfkO2dXeIWg9GofbqMGspnNd1PUF2t4v0KRSXi4QlNinCpfeR9T6q1+OSTkKlGLz+Uv0mYMgUtcTRUdRMugjU62eQltAvzxm1O5yYC4YFMUISjz+KCp0aQzSjKPjsxdthWyvTWkVg97YIBa7X9UJci3f7kx5rdGhhQlpGH4bWrZwCW7c31cgFfdwFtnadZTNBYebkLs5QJt8iUN56VTmAdEv8L0BPpqHOmst/UwiZWCLPaYj0zKGk2xp5mJUA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIYkc-0008AC-7K for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2024 14:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Dec 2024 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74637-submit@debbugs.gnu.org id=B74637.173325474431271 (code B ref 74637); Tue, 03 Dec 2024 19:40:02 +0000 Original-Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 19:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:32992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYjf-00088I-I3 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 14:39:03 -0500 Original-Received: from thaodan.de ([185.216.177.71]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYjd-00087t-Sm for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 14:39:03 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id E6759D0004F; Tue, 3 Dec 2024 21:39:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733254741; bh=rQUdwzaYzfj+0UQ+hbkioq55C8VtW+S1Ei33PPSAQws=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=22LHYD1FALVfcPaHT0fcfRpuS5jL8JuJ0tj9Vl0QVP54YN+8BzqCxL7zCv/H1in1b oIjdCGoQ72hDbhgYrCIYFUg4hoXtp2Advcq9VOD1wrTo+xZr2eZiGUdo/Z3KdldjOK h34WUY6N+2tgdmoKxpwAMCz0jsmDsYoav2oKP3OaJ2/7Oxhg2AH6pbH8l4pEHH0IdW fy+IA6Megjd9M+98FVOJdlN3ATlGf18Xok2p6Yb9z5nzkU++kv02PIO9aFUGJpQfwo Y5wuSuN38vdIFB5zDD9hNSp4/ujsPZU8N2tBUxPD6lLFgT87lOqO7KG9C+uN4l0e3l EBC8/N49IDsX6ZRY1hQc/6a34v5dx4e6kPlf5SiCvcuaibs5ur3iYeHN9Hlv33PmqN BZCvW68sNXhRXAr0JeaM27XQD5vBCISJ1Wi2NdpkA/9SaQuZ3XG+TO43RE4Ubr3HSw uPdnzzqZ035pRPQUheya+As/igeF9b6UisMg+Z71Ak+eFmlxe0pMn2GiS8diXoYvqI KevP97GcwMTu7ojfPzDNvg0HkYhVj6hI92Bjf7FfzY23RWgzhd2wsuwiyJaT1eg390 Mzu2RJaqtS/Kem6rTJbBDTM6X3osnUEE3lbrF/svM+QyXZYjWQhLkmmLbSaFlgfz3u i8b7ErTw3QnM3dQoiYiHn2ME= In-Reply-To: <86zflc27dl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:01:10 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296382 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>=20 >> >> > That's an incompatible behavior change. Is that justified? How can >> >> > we be sure that everyone agrees with your interpretation of this mo= de? >> >>=20 >> >> All other view-file like modes behave like this, you view the file and >> >> leave the file with q. >> > >> > That doesn't change the fact that view-mode didn't behave like that, >> > until now. >>=20 >> View-mode isn't change outside of the specific situation of opening a >> file which isn't writable. > > It's still a significant change. Killing a buffer is not a minor > think, and restoring it is not always easy, or even possible (e.g., > the file could have been deleted in the meantime). In such instances the files are usually those which are shared by other users or installed by the system administrator if the file was deleted it could have been only by the owner or those with the power to delete them. Files which the user owns wouldn't be affected. > My opinion is that if we install this, we need to provide some way of > getting the previous behavior back, for those who may want it. > Should this also affected files through the other instances where view-mode kills the buffer if not modified? In the instances affected by the patch view-read-only is more implicit e.g. when following a reference w= ith xref to a read-only file but view-file is still similar.