unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <acorallo@gnu.org>,
	74637@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#74637: [PATCH] Make view-read-only behave like view-file
Date: Tue, 03 Dec 2024 21:39:00 +0200	[thread overview]
Message-ID: <21973.3555147954$1733254834@news.gmane.org> (raw)
In-Reply-To: <86zflc27dl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:01:10 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Björn Bidar <bjorn.bidar@thaodan.de>
>> Cc: 74637@debbugs.gnu.org
>> Date: Tue, 03 Dec 2024 12:06:11 +0200
>> 
>> >> > That's an incompatible behavior change.  Is that justified?  How can
>> >> > we be sure that everyone agrees with your interpretation of this mode?
>> >> 
>> >> All other view-file like modes behave like this, you view the file and
>> >> leave the file with q.
>> >
>> > That doesn't change the fact that view-mode didn't behave like that,
>> > until now.
>> 
>> View-mode isn't change outside of the specific situation of opening a
>> file which isn't writable.
>
> It's still a significant change.  Killing a buffer is not a minor
> think, and restoring it is not always easy, or even possible (e.g.,
> the file could have been deleted in the meantime).

In such instances the files are usually those which are shared by other
users or installed by the system administrator if the file was deleted
it could have been only by the owner or those with the power to delete
them.

Files which the user owns wouldn't be affected.

> My opinion is that if we install this, we need to provide some way of
> getting the previous behavior back, for those who may want it.
>

Should this also affected files through the other instances where
view-mode kills the buffer if not modified? In the instances affected by
the patch view-read-only is more implicit e.g. when following a reference with
xref to a read-only file but view-file is still similar.





  parent reply	other threads:[~2024-12-03 19:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ldwzm91r.fsf@>
2024-12-02 12:29 ` bug#74637: [PATCH] Make view-read-only behave like view-file Eli Zaretskii
2024-12-02 18:08   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <87ttbmj6tt.fsf@>
2024-12-02 19:33     ` Eli Zaretskii
2024-12-03 10:06       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]       ` <87mshdjd2k.fsf@>
2024-12-03 14:01         ` Eli Zaretskii
2024-12-03 14:25           ` Visuwesh
2024-12-03 19:33             ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-03 19:39           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
     [not found]           ` <874j3kimjv.fsf@>
2024-12-03 19:43             ` Eli Zaretskii
2024-12-01 20:40 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='21973.3555147954$1733254834@news.gmane.org' \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74637@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).