From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: 75012@debbugs.gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>,
Filippo Argiolas <filippo.argiolas@gmail.com>
Subject: bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments
Date: Sat, 21 Dec 2024 22:18:08 +0100 [thread overview]
Message-ID: <2184374.9o76ZdvQCi@fedora> (raw)
In-Reply-To: <m2ikrczyl2.fsf@gmail.com>
Ciao Filippo,
it's fine for me, even the "overkill" version.
@Eli WDYT ?
Vincenzo
In data sabato 21 dicembre 2024 19:21:29 Ora standard dell’Europa centrale,
Filippo Argiolas ha scritto:
> Hi, I was experimenting with the new local parser for doxygen comments
> in c-ts-mode.
>
> I think current syntax highlighting rules really basic and could use
> some love. One thing that would really help IMHO would be using a
> different face for storage class so that e.g.
>
> @param[in] some param
>
> have param and [in] with two different colors. Param type is detected as
> "storage_class" and that's usually fontified with font-lock-keyword-face
> (e.g. like const and static in C) so I believe that would be the most
> obvious choice.
>
> I also have been experimenting with some additional rules in
>
> c-ts-mode-doxygen-comment-font-lock-settings but they may be overkill:
> :language 'doxygen
> :override t
> :feature 'keyword
>
> '((tag_name) @font-lock-constant-face
> (type) @font-lock-type-face
> (emphasis) @bold
> ((tag_name) @bold (:match ".note" @bold))
> ((tag_name) @warning (:match ".warning" @warning))
> ((tag_name) @error (:match ".error" @error))
> (storageclass) @font-lock-keyword-face)
>
> gets me something like the 'after' screenshot here[1], the 'before' now
> is current faces with ef-dream theme.
>
> What do you think?
>
> Thanks,
> Filippo
>
>
> 1. https://people.freedesktop.org/~fargiolas/c-ts-doxy/
>
>
>
>
>
> In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.1.0, NS
> appkit-2575.20 Version 15.1.1 (Build 24B91)) of 2024-12-21 built on mba
> Repository revision: 1c960bda91237c92f9f602bcb8538ad500c0bc49
> Repository branch: master
> Windowing system distributor 'Apple', version 10.3.2575
> System Description: macOS 15.1.1
>
> Configured using:
> 'configure --with-tree-sitter --with-native-compilation'
next prev parent reply other threads:[~2024-12-21 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 18:21 bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments Filippo Argiolas
2024-12-21 21:18 ` Vincenzo Pupillo [this message]
2024-12-22 6:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2184374.9o76ZdvQCi@fedora \
--to=v.pupillo@gmail.com \
--cc=75012@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=filippo.argiolas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).