unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18784@debbugs.gnu.org
Subject: bug#18784: Coultdn't compile emacs-24.4
Date: Mon, 16 Mar 2015 10:16:37 +0100	[thread overview]
Message-ID: <21766.40821.679834.521362@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <jwva8zgpjkn.fsf-monnier+emacsbugs@gnu.org>

>>>>> On Fri, 13 Mar 2015, Stefan Monnier wrote:

> Indeed, looks right. And 18780's diagnostic looks right as well.
> Could someone look at fixing our configure script accordingly?

Find my attempt of a patch below. Please review.


From 30678f8b5cba82b4ca9841fd1c8760b48cf12b59 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Mon, 16 Mar 2015 10:02:51 +0100
Subject: [PATCH] configure.ac: Add -nopie to LD_SWITCH_SYSTEM_TEMACS.

* configure.ac (LD_SWITCH_SYSTEM_TEMACS): Add -nopie option,
in order to avoid segfaults in temacs.  (Bug#18780)
---
 ChangeLog    | 5 +++++
 configure.ac | 7 +++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 4f6523e..fd99ff9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-16  Ulrich Müller  <ulm@gentoo.org>
+
+	* configure.ac (LD_SWITCH_SYSTEM_TEMACS): Add -nopie option,
+	in order to avoid segfaults in temacs.  (Bug#18780)
+
 2015-03-02  Robert Pluim  <rpluim@gmail.com>  (tiny change)
 
 	* configure.ac: Error out if with-file-notification=w32 is
diff --git a/configure.ac b/configure.ac
index d65494a..0c0c5b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4989,11 +4989,14 @@ case "$opsys" in
    esac
    ;;
 
-  openbsd) LD_SWITCH_SYSTEM_TEMACS='-nopie' ;;
-
   *) LD_SWITCH_SYSTEM_TEMACS= ;;
 esac
 
+if test "$GCC" = yes; then
+  # Disable PIE to avoid segfaults in temacs (bug#18780)
+  LD_SWITCH_SYSTEM_TEMACS="$LD_SWITCH_SYSTEM_TEMACS -nopie"
+fi
+
 if test x$ac_enable_profiling != x ; then
   case $opsys in
     *freebsd | gnu-linux) ;;
-- 
2.3.2






  reply	other threads:[~2015-03-16  9:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 11:52 bug#18784: Coultdn't compile emacs-24.4 Gangræna Gorgeous
2014-10-21 15:16 ` Eli Zaretskii
2014-10-21 15:49   ` David Engster
2015-03-13 19:54 ` Glenn Morris
2015-03-13 20:43   ` Ulrich Mueller
2015-03-13 21:09     ` Ulrich Mueller
2015-03-13 23:25       ` Stefan Monnier
2015-03-16  9:16         ` Ulrich Mueller [this message]
2015-03-16 13:09           ` Stefan Monnier
2015-03-16 16:18             ` Eli Zaretskii
2015-03-16 18:19               ` Stefan Monnier
2015-03-16 18:29                 ` Eli Zaretskii
2015-03-16 19:06                   ` Stefan Monnier
2015-03-16 19:34                     ` Eli Zaretskii
2015-03-16 20:04                       ` Ulrich Mueller
2015-03-16 20:29                         ` Stefan Monnier
2015-03-29 12:19                           ` Ulrich Mueller
2015-04-03 11:45                             ` Ulrich Mueller
2015-03-16 16:26             ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21766.40821.679834.521362@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=18784@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).