From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Sat, 01 Jul 2023 14:14:11 +0000 Message-ID: <215b00d2590a10728db4@heytings.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> <83o7l61lz6.fsf@gnu.org> <2aa76ba11fd0a77ba107@heytings.org> <30832e86470f7dc33387@heytings.org> <83r0pyw89y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, monnier@iro.umontreal.ca, acm@muc.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 01 16:15:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFbNm-0000mt-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jul 2023 16:15:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFbNP-0007MK-Qp; Sat, 01 Jul 2023 10:15:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbNO-0007Lk-FU for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFbNO-0004eH-5W for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFbNN-0003TJ-Kg for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jul 2023 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.168822085613263 (code B ref 60467); Sat, 01 Jul 2023 14:15:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 1 Jul 2023 14:14:16 +0000 Original-Received: from localhost ([127.0.0.1]:58412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbMe-0003Rr-5Z for submit@debbugs.gnu.org; Sat, 01 Jul 2023 10:14:16 -0400 Original-Received: from heytings.org ([95.142.160.155]:36896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbMa-0003Rg-9W for 60467@debbugs.gnu.org; Sat, 01 Jul 2023 10:14:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1688220851; bh=ZamH90jNbhLKMkrxPdhZS+yZ//XU4i1iFN/gN/v4EAU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=J2ajx+FzKGB4vK1KorTHPfi4OuDVo+cXtevog4G2009v+K+L0VHfN9zHBP8zd6/xM jFQYZouiAyouhphdjLDlXtXpyqt8g572GFKBrk7RNH8lKzAAZJvE0i6u4RAO4MLr+9 nDnXFc1cNgLTciCceb+xMFm5di7agN6+NKooMJUsqLQbdaYe+iL1ofalf4qd5yl9dg vjYfxYg5xE/mncFHmnNPrMPXJZkrvo5ZG/VmOfGuQSplvpHZJ4aVCmwKRuG1FWr800 5azdSiT7LfCp9ZmFW3BAYCPK6XyUEZj++bULLbFHcKImArJpipBYrPzfdeZKT7ATx9 dE9aTegYAfDfA== In-Reply-To: <83r0pyw89y.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264407 Archived-At: >> Well, that bug was already discussed at length six months ago, and the >> minimal change that was in the end installed (59c3c53efa) introduced a >> new bug. Should we design another minimal change, at the risk of >> introducing another bug? ISTM that the safe thing to do is the >> refactoring that was suggested. > > If there's no safer way than the refactoring suggested back then, we > will have to stay with this regression in Emacs 29.1 and install a > better fix only on master. After all, the fact that buffer-modified-p > is not undone is a minor inconvenience at best. > Indeed. A safer way probably exists, but I would not dare writing that patch. I believe Stefan is in a better position to write it.