From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincenzo Pupillo Newsgroups: gmane.emacs.bugs Subject: bug#71724: 30.0.50; [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region' Date: Sun, 23 Jun 2024 12:11:07 +0200 Message-ID: <2139705.9o76ZdvQCi@fedora> References: <2215304.Hq7AAxBmiT@fedora> <86iky0fdtp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71724-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 12:13:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLKDz-0000qC-U2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 12:13:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLKDX-0005Vp-LA; Sun, 23 Jun 2024 06:13:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLKDW-0005VO-19 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 06:13:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLKDV-0008VY-P2 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 06:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLKDW-0001zZ-24 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 06:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71724-done@debbugs.gnu.org id=D71724.17191375377568 (code D ref 71724); Sun, 23 Jun 2024 10:13:02 +0000 Original-Received: (at 71724-done) by debbugs.gnu.org; 23 Jun 2024 10:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:52714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLKCn-0001xz-2X for submit@debbugs.gnu.org; Sun, 23 Jun 2024 06:12:17 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:60788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLKCl-0001xi-8A for 71724-done@debbugs.gnu.org; Sun, 23 Jun 2024 06:12:15 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-57cc1c00ba6so4026535a12.1 for <71724-done@debbugs.gnu.org>; Sun, 23 Jun 2024 03:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719137469; x=1719742269; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8igQ6S66eyYjWZ0XwnCJPIUAKvF5v7jo8o6cTPN9OG0=; b=RV3SP3u/88GyCHNucJW1wZZRGafGVjw2g6qRq6mQmKSJmtgP8xL5zHq14FtWAWsfhp cnNfW5R0cfr3OgrTa997gv72uNB+UkOaZQQhuOAsOJRjvvyAfVSS7lpCxJBYr6zwRyUa J8jfQTjR8Lxt7d1/sWjOMm+bVtN9nQMRMNMgPJYhHINcJw189RMkX0jV/YaQk+QNi5Y5 zFsNRlqdF24byg+JIA6He+v911VET9FTZKRjdjHgErXghccDtQrDizkHLqNHYwcyWLvD Tux3CBv9LG/ADazCyGhV/Ze6we3s1v+s9VdIMxRKQKZJTfm5m3fZzcLhKp/QCpdACaw5 gE4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719137469; x=1719742269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8igQ6S66eyYjWZ0XwnCJPIUAKvF5v7jo8o6cTPN9OG0=; b=aYlX07x8Zl1gQWPhN5DqLF8DAu0T8+aFRwEapGJz3+NMtuDer9kZdMobrMI58T+zu9 EvrDjF2+O0fE0E+DhdDenrkZv8pPAv9vnbRS6aQjLpFRB6Wh0XJ5pliYq7aIsy4/XYf0 NaW1fe/VlAuFiN9GSGiN7tDwG2H1mqJyT2byEwjUrIe3rOvvFgiEFHvEymJjvABn3BZw 9FuixEUjH3aTqfeVnAplwrtcbUOJntsASeWZjmTCaqsEnLUgQP6KhkjR/p8wmmtAwsfK I8Q6Fd/zFH1yX4NvuJ5tDYoYHZnd4hOm/EL5ZuYLDDqcKeuuwu0D+RL98ahXPvZQmtns ahrg== X-Gm-Message-State: AOJu0Yzk0aHGcq7SCtiCRPuuUn1YgCPIB1xvfsPDLlR5kXCQPiK92mV6 kuKgTHPfBYQb6EN3E+5HhPiMgD5WEugtQto3NYvMf6knxx3rRHif X-Google-Smtp-Source: AGHT+IFD+6z37MA56qDR+3ADyWLGEn8Ge2x67i/WDH2uS+RW5lN26cQmJ3/DAUrVMLdafWo5eyQQEQ== X-Received: by 2002:a50:d557:0:b0:57c:935d:2881 with SMTP id 4fb4d7f45d1cf-57d4bdbfb59mr1077691a12.32.1719137468700; Sun, 23 Jun 2024 03:11:08 -0700 (PDT) Original-Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d303d7ddcsm3340514a12.17.2024.06.23.03.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 03:11:08 -0700 (PDT) In-Reply-To: <86iky0fdtp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287770 Archived-At: In data domenica 23 giugno 2024 07:06:10 CEST, Eli Zaretskii ha scritto: > > From: Vincenzo Pupillo > > Date: Sat, 22 Jun 2024 23:36:13 +0200 > > > > this patch adds a new feature to colorize a property when it's value is a > > text that represents a CSS color. It will be fontified such that its > > background is the color itself, like in 'cs-ts-mode'. > > A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle > > this behavior. > > Thanks, installed, and closing the bug. > > Please in the future observe our conventions for the commit log > > messages: > > Subject: [PATCH] Colorize CSS property value like `css--fontify-region' > > > > If the value of a property is text representing a CSS color, it will be > > fontified such that its background is the color itself. > > 'php-ts-mode-css-fontify-colors' can be used to disable this behaviour. > > These lines are too long. They will be indented by a TAB in the > generated ChangeLog file, so they should preferably be no longer than > 65 characters. > > > * lisp/progmodes/php-ts-mode.el (php-ts-mode-css-fontify-colors): > > New custom var. > > ^^^ > Please don't leave this whitespace at the beginning of lines. > > > * lisp/progmodes/php-ts-mode.el (php-ts-mode): Use the new function. > > This line is also too long. > > I usually correct any log messages that need it, but if you observe > these conventions better, it will make my job easier. > > Thanks. I apologize, I will be more accurate with the commit log messages. Thank you very much Eli. Vincenzo