From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Sun, 25 Jul 2021 23:28:24 +0200 (CEST) Message-ID: <2138242899.459686.1627248504532@ichabod.co-bxl> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> <343742107.2068902.1626706305280@ichabod.co-bxl> <87k0lml3wt.fsf@mail.linkov.net> <874kcql2r8.fsf@gnus.org> <2097190220.304800.1627097630028@ichabod.co-bxl> <87sg02zz65.fsf@gnus.org> <8735s2ru7o.fsf@mail.linkov.net> Reply-To: Brian Leung Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24108"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49632@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 23:29:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7lgL-000627-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 23:29:09 +0200 Original-Received: from localhost ([::1]:51894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7lgJ-0006l0-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 17:29:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7lgE-0006kp-5q for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 17:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7lgD-0004eH-R9 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 17:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7lgD-0001an-My for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 17:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.16272485206088 (code B ref 49632); Sun, 25 Jul 2021 21:29:01 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 25 Jul 2021 21:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:49514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7lfr-0001a8-Ll for submit@debbugs.gnu.org; Sun, 25 Jul 2021 17:28:39 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:51360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7lfn-0001Zp-0a for 49632@debbugs.gnu.org; Sun, 25 Jul 2021 17:28:38 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id 4C89D879; Sun, 25 Jul 2021 23:28:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1627248508; s=20210208-e7xh; d=mailfence.com; i=leungbk@mailfence.com; h=Date:From:Reply-To:Cc:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; l=1952; bh=krzbb/Jg3ijbdyOYMs9fLa9YRGeqEkGWiwVv0oktALY=; b=IDmLIyGr9tWqaS2v6zUV+KJpTCNXV6+C7XutQ/z+SSrdgK8JhKwLumBbxn0NMSV1 vJkAih6G2kYn0d+XDEw4L8TvOyAZvpiiZH55Q7tibhq1Rf5nvqLcXmNFnDRxyKFIteL p+7mD7OQQ7zBrWIi+dwaDwcd/neyLoHJjroD4fmXQNi3dQs6MTkhu9GufQrc+pZM1ec OXuaLoMJ89WWRMPPk33oAM96Sc4ATFw+QkLuxirWw0RadjCYK+8GHF2DT8zKEQW0zJN qXnXfNGNt7/vlOSs3LHZfPvC1nIkA2e8n6xIpNwsOBceQmTkPTkrvrK7KTzQN5VcqTb smIyiZ2hQw== In-Reply-To: <8735s2ru7o.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210737 Archived-At: > There is one thing that I don't understand: is the > helper function gud-set-repeat-map-property really needed? >=20 > If e.g. the defvar gud-gdb-repeat-map uses such symbols as 'gud-next', > could it put the 'repeat-map' property on the same symbols > with reference to the variable 'map' directly in these defvars? > Then only defvars will be needed, and no changes in gud-gdb, gdb. If we assign the repeat-map property within the defvars and avoid doing so = in the M-x gdb commands, then after gud.el gets loaded, the repeat-map prop= erty on (say) gud-next will be 'jdb, since jdb-repeat-map is the last such = foo-repeat-map defvar appearing in gud.el. In that case, calling M-x perldb= and then running gud-next when repeat-mode is on will bring up the jdb-rep= eat-map, which contains some commands that aren't defined for perldb. So I = think the gud-set-repeat-map-property macro (or something like it) is neces= sary. > ---------------------------------------- > From: Juri Linkov > Sent: Sun Jul 25 22:53:31 CEST 2021 > To: Lars Ingebrigtsen > Cc: Brian Leung , <49632@debbugs.gnu.org> > Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-= map >=20 >=20 > >> OK, I've updated the patch following Juri's suggestions. > > > > Skimming the patch, it looks good to me. Juri, do you have any > > comments? >=20 > There is one thing that I don't understand: is the > helper function gud-set-repeat-map-property really needed? >=20 > If e.g. the defvar gud-gdb-repeat-map uses such symbols as 'gud-next', > could it put the 'repeat-map' property on the same symbols > with reference to the variable 'map' directly in these defvars? > Then only defvars will be needed, and no changes in gud-gdb, gdb. --=C2=A0 Sent with https://mailfence.com Secure and private email --=20 Mailfence.com Private and secure email