From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincenzo Pupillo Newsgroups: gmane.emacs.bugs Subject: bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php Date: Fri, 07 Jun 2024 12:45:05 +0200 Message-ID: <2137654.9o76ZdvQCi@3-191.divsi.unimi.it> References: <3686989.dWV9SEqChM@3-191.divsi.unimi.it> <86cyouimm4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2696204.vuYhMxLoTh" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71380@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 07 12:55:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFXFj-0005O8-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jun 2024 12:55:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFXFB-0002oH-2T; Fri, 07 Jun 2024 06:54:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFXF9-0002nJ-4q for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 06:54:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFXF8-0005AI-Sg for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 06:54:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFXFN-000502-Nk for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 06:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71380 X-GNU-PR-Package: emacs Original-Received: via spool by 71380-submit@debbugs.gnu.org id=B71380.171775765719107 (code B ref 71380); Fri, 07 Jun 2024 10:55:01 +0000 Original-Received: (at 71380) by debbugs.gnu.org; 7 Jun 2024 10:54:17 +0000 Original-Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFXEa-0004xt-Dd for submit@debbugs.gnu.org; Fri, 07 Jun 2024 06:54:17 -0400 Original-Received: from mail-lj1-f170.google.com ([209.85.208.170]:60662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFXEU-0004x4-GB for 71380@debbugs.gnu.org; Fri, 07 Jun 2024 06:54:10 -0400 Original-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2e72b8931caso19999731fa.0 for <71380@debbugs.gnu.org>; Fri, 07 Jun 2024 03:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717757565; x=1718362365; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jY9YOfiLMgG+CtGBMg90pkuF8FEGWHl+yhOFeARjF/M=; b=K6BpHYcT+38dGU+S6ksiyJbvvwIeb8y+m+1vWvmryC0bZcO98t/01A+BA2VdlvCSZt siCFLz011FbiLgEGSVbFAX5kacq7dH5g/yTGB9RpV2yjPnpSNMpQ3BzDZZ8WaQTjFhs3 SKooWrv4YSCe89nLg+sk2R+dNIhhe9RmyYL5xuQA4AR+8yLLF6uMtNDz9RBEUDDFMmpg 3rHEsK8Am44qm1LIjx19JC1QLcYzzizFkFDX2oB6pBMeeTsqJAFLTWjt+t9IBqwZNyIu hFNfcDjf4NbG8NfiwwKdiWTmti2v2L08DoTdsHqRFjopmUQxNJcSw17e22L11du9pZ6Z KC0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717757565; x=1718362365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jY9YOfiLMgG+CtGBMg90pkuF8FEGWHl+yhOFeARjF/M=; b=u0VjNIkHPpJ8XrUrzgqc1cPc+Pzdu3+ArWUyJycJRabZWXyy+TKzR+HKAp0TK/BQee 50CRcACpdk9dwpHRcgKf56/5kKLOrnAB97Mv9hdlLFL0H8ZhKr0SnZv+m/JxKv/8WnBS l1PKsNKgx5LzGuV0AwP1mbqws1xTaUfl8hV4iMV5ca8xeXzmzeUoElov0joehEN20l/N kLtTihc2HlL8IYZaqw2d2ePmTIs9b3U+f15eeCfdrgFXShnSEOH2ry+CHENOr78wSQKZ VzQZ5c1xmsBo0KCYp45VuiOo4GyDG/PmqojCEhkDNdzBauop+ZSnwKkQhdNRGB2OeQoo Q4iQ== X-Gm-Message-State: AOJu0Yyj1SFVAtiQ+PKOrgL/Jmp4ElgUkopxG+sSGH2nrn8pViWnwk6i pGaTWGofXGOym1RyJmeWbVmbIdkWU4oeQAHDJUbfTLt3/JLBShtGn8lpW0N9 X-Google-Smtp-Source: AGHT+IH+kvvd6fvd1NHSG03UJwdg4fcudC4Fu73liugu0fppr83OsM0nTlOPleL5VLdlt5oz5raK7g== X-Received: by 2002:a17:906:9c2:b0:a5a:1562:518c with SMTP id a640c23a62f3a-a6cdad2383emr135536266b.48.1717757106865; Fri, 07 Jun 2024 03:45:06 -0700 (PDT) Original-Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c8070e818sm231016766b.170.2024.06.07.03.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 03:45:06 -0700 (PDT) In-Reply-To: <86cyouimm4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286757 Archived-At: This is a multi-part message in MIME format. --nextPart2696204.vuYhMxLoTh Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Eli, Thank you. In data gioved=C3=AC 6 giugno 2024 08:58:11 CEST, hai scritto: > > From: Vincenzo Pupillo > > Date: Wed, 05 Jun 2024 15:59:20 +0200 > >=20 > > I would like to submit php-ts-mode. > > This major mode this major mode, in addition to font-lock for PHP > > implements the following features: * font-lock for html, javascript, css > > and phpdoc. > > * six different indentation styles (PSR, PEAR, Zend, Drupal, Wordpress, > > Symfony). * Imenu > > * Flymake > > * Which-function > > * a helper function to simplify the installation of parsers, in versions > > used to develop major-mode * PHP built-in server support > > * Shell interaction: execute PHP code in an inferior PHP process. >=20 > Thanks, I added Stefan, Philip and Yuan to the discussion, in case they h= ave > comments. >=20 > > +--- > > +*** New major mode 'php-ts-mode'. > > +A major mode based on the tree-sitter library for editing >=20 > This seems to be an incomplete sentence. Done >=20 > Also, I think we should add PHP to the list of modes in the "Program > Modes" node of the Emacs user manual. >=20 > > +(defun php-ts-mode-install-parsers () > > + "Install all the required treesitter parser. >=20 > ^^^^^^ > "parsers", in plural. > Done=20 > > +`php-ts-mode--language-source-alist' define which parsers to install." >=20 > ^^^^^^ > "defines". >=20 Done > > +(defcustom php-ts-mode-indent-offset 4 > > + "Number of spaces for each indentation step (default) in > > `php-ts-mode'." >=20 > ^^^^^^ > "columns", I guess? >=20 > And what does "(default)" mean here? >=20 The comment is the same as c-ts-mode-indent-offset except for =E2=80=9C(def= ault)=E2=80=9D ,=20 which I deleted > > +(defcustom php-ts-mode-js-css-indent-offset html-ts-mode-indent-offset > > + "JavaScript and CSS indent spaces related to the