From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48841: fido-mode is slower than ido-mode with similar settings Date: Sun, 4 Jul 2021 04:42:28 +0300 Message-ID: <21357b0f-0c95-c520-15c6-7bd326681e69@yandex.ru> References: <87eedgy7pt.fsf@gmail.com> <1f659c88-4d9d-8fc9-733a-5e6068f9ed4a@yandex.ru> <87a6o3x5j7.fsf@gmail.com> <87y2bnv5xc.fsf@gmail.com> <35be6652-9c8d-ee21-e9eb-9598ad6777eb@yandex.ru> <858682b2-b8fd-898b-bef3-97dbe5e4debc@yandex.ru> <878s3gugqj.fsf@gmail.com> <87zgvtu9bm.fsf@gmail.com> <033e12e5-86e2-cb0c-ac8b-6753b96fa4b2@yandex.ru> <33224e9c-2185-29c0-5aa9-f798b2f3ccaf@yandex.ru> <871r90b2od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11881"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: Stefan Monnier , 48841@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 04 03:43:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzrA6-0002zK-7J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jul 2021 03:43:10 +0200 Original-Received: from localhost ([::1]:41506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzrA5-0002bg-9H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jul 2021 21:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzr9z-0002bU-87 for bug-gnu-emacs@gnu.org; Sat, 03 Jul 2021 21:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzr9y-0005hu-G0 for bug-gnu-emacs@gnu.org; Sat, 03 Jul 2021 21:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzr9y-0007D8-Aa for bug-gnu-emacs@gnu.org; Sat, 03 Jul 2021 21:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jul 2021 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48841 X-GNU-PR-Package: emacs Original-Received: via spool by 48841-submit@debbugs.gnu.org id=B48841.162536296027687 (code B ref 48841); Sun, 04 Jul 2021 01:43:02 +0000 Original-Received: (at 48841) by debbugs.gnu.org; 4 Jul 2021 01:42:40 +0000 Original-Received: from localhost ([127.0.0.1]:40210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzr9b-0007CV-Mb for submit@debbugs.gnu.org; Sat, 03 Jul 2021 21:42:39 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:38643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzr9Z-0007CI-6G for 48841@debbugs.gnu.org; Sat, 03 Jul 2021 21:42:38 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id b14-20020a1c1b0e0000b02901fc3a62af78so5030209wmb.3 for <48841@debbugs.gnu.org>; Sat, 03 Jul 2021 18:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mf/RM6T+aNhp2Wm89BbNUXm8BpQLgsQV0+hTdalnHYM=; b=DgmhVwJoZ8uuf1Yi1bwteyIRzMXF20qa+vVmIkOc3eYjzjhobFu8EBRsFgTGRHHYyC jaxhGtzlVjfhFrZfxdphJFxfpl0mAwOZmOz3ZwjgQ6rhxH2sbzFuGGu1yZMsUqbNQP4A uewgfvpX/PoAfS3Bw682gBvB+b8TRSDuYLF3JGYxv11p+zgnQ+kts1nj3g3RSxhPL7/p XiaMXTip7QvjpPrMUjgEOSknu5OnNdQ+gckxNdm43+ffw7RptSHxb/iVG1M03/vJv+WY Ify11LG5apwdJ0ON/aMOcf2rtvveZmisiVkuL1JSTU+H78ahlbCdhuwMHHQOaybw8ZGf k3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mf/RM6T+aNhp2Wm89BbNUXm8BpQLgsQV0+hTdalnHYM=; b=NrpSEcK2dJ7slqW5N3n6XwGPms+t/LxN7r4Z+ZxrW2a/AoEQz7F4rJdruUPJTBjVqc /PuFBc5uL7djvgKQQazUlwV81pPluyKlW2dddlY2CNzFrWYImZlu6SuOTaRlptebsHKB KSDVsgKZ9rZWihFQeeGF1wIwSd5rgX6f9AjCyFP0RMqvT5ZxtiV6yB8HtEqHzZrYvtAH j5qfE5+W44A6sEaIhFxD6Cth9VrZpC9PKIx+WCAAaef9h8f90cwC+8SoHrpvxLp1YWo/ 93Hmb9LrSc1QG4z/c2slv7LhiON6QrFkeMdCBIyIKFG/PP2PorupR+V7fwVpUW+kx6/c HWEA== X-Gm-Message-State: AOAM530t0FgwBym3DXfmeZ86J2EXN+2KQMEnBLccDjTpmsU5DDdiyCe5 lGVUI1rc451EmlpsqfI1PLeEdXzmrz8= X-Google-Smtp-Source: ABdhPJxHHnD3VSoAyFzL8yIxoeoJoIk7+WNbWbuEqupUoA9soR8fWCA7DXvh6HTVzQ7d8GLYiI6l/Q== X-Received: by 2002:a7b:ce82:: with SMTP id q2mr7290748wmj.60.1625362951277; Sat, 03 Jul 2021 18:42:31 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n7sm16327195wmq.37.2021.07.03.18.42.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jul 2021 18:42:30 -0700 (PDT) In-Reply-To: <871r90b2od.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209374 Archived-At: On 18.06.2021 00:29, João Távora wrote: >> Unless I'm missing something and the value does see some use in the >> multiple-matches situations, the patch below both keeps the current >> behavior and gives the same performance improvement: > > That'd be fantastic, but I doubt you'd be keeping the exact same > behaviour. I never understood it -- that's the thing here -- but I > think that completion-try-completion is doing more stuff when multiple > candidates matched by a pattern happen to share the same prefix or > suffix or something like that. I might be completely wrong, tho. Turns out that indeed the logic is used in the "multiple matches" case: when icomplete-hide-common-prefix is non-nil. Meaning, with icomplete-mode but not with fido-mode. > But really if you make this patch conditional to fido-mode or that other > var that you think is more abstract, I think it's fine and it's a very > clear win. I really doubt that the tiny number of fido-mode users care > about that behaviour anyway, but I'm sure they'll appreciate the > considerable speedup. So I have done the above. There is no change in observable behavior either (AFAICS), so it's win-win.