From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ikumi Keita Newsgroups: gmane.emacs.bugs Subject: bug#69187: 29.2; Poor compatibility in align.el Date: Sat, 06 Apr 2024 01:57:53 +0900 Message-ID: <2125.1712336273@localhost> References: <55489.1708171413@localhost> <2214.1708282932@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22335"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69187@debbugs.gnu.org To: Arash Esbati Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 05 18:59:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsmuM-0005WN-0p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Apr 2024 18:59:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsmu3-0004to-J6; Fri, 05 Apr 2024 12:58:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsmu0-0004t7-AH for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 12:58:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsmu0-00027q-1d for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 12:58:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsmu5-00076k-Lu for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 12:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ikumi Keita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2024 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69187 X-GNU-PR-Package: emacs Original-Received: via spool by 69187-submit@debbugs.gnu.org id=B69187.171233628927104 (code B ref 69187); Fri, 05 Apr 2024 16:59:01 +0000 Original-Received: (at 69187) by debbugs.gnu.org; 5 Apr 2024 16:58:09 +0000 Original-Received: from localhost ([127.0.0.1]:37423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsmtD-000733-Qq for submit@debbugs.gnu.org; Fri, 05 Apr 2024 12:58:09 -0400 Original-Received: from smtp1a.inetd.co.jp ([210.129.88.11]:44020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsmt8-00072M-Da for 69187@debbugs.gnu.org; Fri, 05 Apr 2024 12:58:06 -0400 Original-Received: from localhost (42-144-34-11.rev.home.ne.jp [42.144.34.11]) by smtp1a.inetd.co.jp (Postfix) with ESMTPA id C4F146A; Sat, 6 Apr 2024 01:57:54 +0900 (JST) In-reply-to: Comments: In-reply-to Arash Esbati message dated "Wed, 03 Apr 2024 14:22:16 +0200." X-Mailer: MH-E 8.6+git; nmh 1.8; Emacs 29.3 Content-ID: <2122.1712336273.1@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282716 Archived-At: Hi Arash, >>>>> Arash Esbati writes: > Thanks for raising this issue. I have a question though: Does the > change below fit the bill as well: > diff --git a/lisp/align.el b/lisp/align.el > index 81ccc4b5e2d..21e2e12ac24 100644 > --- a/lisp/align.el > +++ b/lisp/align.el > @@ -538,9 +538,7 @@ align-rules-list > (align-match-tex-pattern "\\\\[=3D>]" end reverse))) > (group . (1 2)) > (modes . align-tex-modes) > - (repeat . t) > - (run-if . ,(lambda () > - (eq major-mode 'latex-mode)))) > + (repeat . t)) > (tex-record-break > (regexp . "\\(\\s-*\\)\\\\\\\\") That would practically do the job as well, because this entry wouldn't be relevant in buffers in modes other than latex (LaTeX) mode actually. My proposal is just to keep the precise behavior the same. > Ikumi Keita writes: >> Sorry, I included a spurious quote at >> (modes . '(latex-mode)) >> in my proposal. The proposal for `tex-tabbing-separator' should have >> been: >> ---------------------------------------------------------------------- >> (tex-tabbing-separator >> (regexp . ,(lambda (end reverse) >> (align-match-tex-pattern "\\\\[=3D>]" end reverse))) >> (group . (1 2)) >> (modes . (latex-mode)) >> (repeat . t)) >> ---------------------------------------------------------------------- Sorry again, this was my mistake. After the second (third?) thought, my first propoal was actually correct. The entry I should propose is (tex-tabbing-separator (regexp . ,(lambda (end reverse) (align-match-tex-pattern "\\\\[=>]" end reverse))) (group . (1 2)) (modes . '(latex-mode)) (repeat . t)) , not (modes . (latex-mode)) . Regards, Ikumi Keita #StandWithUkraine #StopWarInUkraine #Gaza #StopMassiveKilling #CeasefireNOW