From: Ikumi Keita <ikumi@ikumi.que.jp>
To: Arash Esbati <arash@gnu.org>
Cc: 69187@debbugs.gnu.org
Subject: bug#69187: 29.2; Poor compatibility in align.el
Date: Sat, 06 Apr 2024 01:57:53 +0900 [thread overview]
Message-ID: <2125.1712336273@localhost> (raw)
In-Reply-To: <m2a5mazldz.fsf@macmutant.fritz.box>
Hi Arash,
>>>>> Arash Esbati <arash@gnu.org> writes:
> Thanks for raising this issue. I have a question though: Does the
> change below fit the bill as well:
> diff --git a/lisp/align.el b/lisp/align.el
> index 81ccc4b5e2d..21e2e12ac24 100644
> --- a/lisp/align.el
> +++ b/lisp/align.el
> @@ -538,9 +538,7 @@ align-rules-list
> (align-match-tex-pattern "\\\\[=3D>]" end reverse)))
> (group . (1 2))
> (modes . align-tex-modes)
> - (repeat . t)
> - (run-if . ,(lambda ()
> - (eq major-mode 'latex-mode))))
> + (repeat . t))
> (tex-record-break
> (regexp . "\\(\\s-*\\)\\\\\\\\")
That would practically do the job as well, because this entry wouldn't be
relevant in buffers in modes other than latex (LaTeX) mode actually. My
proposal is just to keep the precise behavior the same.
> Ikumi Keita <ikumi@ikumi.que.jp> writes:
>> Sorry, I included a spurious quote at
>> (modes . '(latex-mode))
>> in my proposal. The proposal for `tex-tabbing-separator' should have
>> been:
>> ----------------------------------------------------------------------
>> (tex-tabbing-separator
>> (regexp . ,(lambda (end reverse)
>> (align-match-tex-pattern "\\\\[=3D>]" end reverse)))
>> (group . (1 2))
>> (modes . (latex-mode))
>> (repeat . t))
>> ----------------------------------------------------------------------
Sorry again, this was my mistake. After the second (third?) thought, my
first propoal was actually correct. The entry I should propose is
(tex-tabbing-separator
(regexp . ,(lambda (end reverse)
(align-match-tex-pattern "\\\\[=>]" end reverse)))
(group . (1 2))
(modes . '(latex-mode))
(repeat . t))
, not
(modes . (latex-mode))
.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
next prev parent reply other threads:[~2024-04-05 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 12:03 bug#69187: 29.2; Poor compatibility in align.el Ikumi Keita
2024-02-18 19:02 ` Ikumi Keita
2024-04-03 12:22 ` Arash Esbati
2024-04-05 16:57 ` Ikumi Keita [this message]
2024-04-05 19:59 ` Arash Esbati
2024-04-06 6:21 ` Eli Zaretskii
2024-04-06 9:30 ` Ikumi Keita
2024-04-06 11:03 ` Eli Zaretskii
2024-04-06 20:14 ` Arash Esbati
2024-04-07 5:49 ` Eli Zaretskii
2024-04-07 8:49 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2125.1712336273@localhost \
--to=ikumi@ikumi.que.jp \
--cc=69187@debbugs.gnu.org \
--cc=arash@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).