unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Harig via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "dgutov@yandex.ru" <dgutov@yandex.ru>, "eliz@gnu.org" <eliz@gnu.org>
Cc: "58525@debbugs.gnu.org" <58525@debbugs.gnu.org>
Subject: bug#58525: 28.1: `vc-dir' (key sequence: C-x v d) fails when used with a CVS repository
Date: Tue, 18 Oct 2022 01:06:34 +0000 (UTC)	[thread overview]
Message-ID: <2124138216.2052980.1666055194810@mail.yahoo.com> (raw)
In-Reply-To: <a0bfa70d-2e6f-bae4-35e7-c47d2332b8f2@yandex.ru>

> It tries to use the most specific one, by using the sorting logic at the
> end of vc-responsible-backend. That was added in
> https://debbugs.gnu.org/42966, which should have made it into Emacs 28.1.
>

It appears that `vc-responsible-backend' DOES include the sorting
code that you have described (and which is listed as a patch in
42966).  In fact, that sorting code is included in the excerpt
from that function that I included in my previous message.

> I'm not sure why your CVS value in that list is t and not a string: that
> should have been fixed in Emacs 28.1 as well, in revision
> bc636515884530f0cab6f.
> 
> There was a further fix, though (regarding expanded vs abbreviated file
> names) which is only available on master (bug#57777). But I'm not sure
> if that comes into play here.
> 
> Anyway, are you really using Emacs 28.1? If not, try that...

The command `emacs-version' reports that it is 28.1.  Also,
/usr/share/emacs/28.1/lisp/vc-dir.el includes the following that all
appear to indicate that the file is from at least 28.1, or later:

;; Copyright (C) 2007-2022 Free Software Foundation, Inc.

(defface vc-dir-header '((t :inherit font-lock-type-face))
  "Face for headers in VC-dir buffers."
  :group 'vc
  :version "28.1")

(defface vc-dir-header-value '((t :inherit font-lock-variable-name-face))
  "Face for header values in VC-dir buffers."
  :group 'vc
  :version "28.1")

(defface vc-dir-directory '((t :inherit font-lock-comment-delimiter-face))
  "Face for directories in VC-dir buffers."
  :group 'vc
  :version "28.1")

> if yes: could
> you try building Emacs from master? And seeing whether it fixes
> your problem.

The problem is fixed for me by removing or renaming my ~/.git/
directory.

To reproduce the problem, create a ~/.git/ directory and then
follow the recipe in the original problem report.  Those steps
take less than 10 minutes to reproduce the problem, using Emacs
28.1, bash, and cvs.  Please let me know if those steps do not
reproduce the problem with Emacs 28.1.

(End.)





  reply	other threads:[~2022-10-18  1:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2011444375.1250404.1665768998367.ref@mail.yahoo.com>
2022-10-14 17:36 ` bug#58525: 28.1: `vc-dir' (key sequence: C-x v d) fails when used with a CVS repository Mark Harig via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 18:34   ` Eli Zaretskii
2022-10-16 22:06     ` Mark Harig via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-17  6:06       ` Eli Zaretskii
2022-10-17 13:00         ` Dmitry Gutov
2022-10-17 16:34           ` Eli Zaretskii
2022-10-17 17:43             ` Mark Harig via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-17 23:10               ` Dmitry Gutov
2022-10-18  1:06                 ` Mark Harig via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-10-18 12:04                   ` Dmitry Gutov
2022-10-18 15:39                     ` Mark Harig via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-18 15:58                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2124138216.2052980.1666055194810@mail.yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58525@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=idirectscm@aim.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).