From: "Roland Winkler" <winkler@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 15987@debbugs.gnu.org
Subject: bug#15987: 24.3; diary-add-to-list ignored by diary-mark-entries
Date: Sat, 30 Nov 2013 19:25:11 -0600 [thread overview]
Message-ID: <21146.36855.78802.434475@gargle.gargle.HOWL> (raw)
In-Reply-To: <13mwkl32tm.fsf@fencepost.gnu.org>
On Sat Nov 30 2013 Glenn Morris wrote:
> Not sure I agree. It may happen to do something, but this function is
> intended to be used to add entries from a literal diary file.
> These days, it might be called "diary--add-to-list".
> diary-entries-list is dynamically bound during certain diary operations,
> it is not a generally accessible variable.
BBDB's context is that bbdb-anniv-diary-entries is added to
diary-list-entries-hook (which is run when diary-entries-list is
properly bound). The function bbdb-anniv-diary-entries then calls
diary-add-to-list. This approach has been used by BBDB for 15
years and I believe that quite a few people have liked this.
No matter whether you consider this approach clean or not, I think
it is reasonable to have *some* mechanism for adding diary entries
from other sources than just diary files.
> It's intended to mark entries from a diary-file, not arbitrary sources.
> So I view this as a wishlist item to have non-diary sources treated as
> diary entries. I don't think this is going to be a high priority for me
> to implement, because it doesn't make much sense to me. Eg what will
> happen when you press "d" on such a marked date in the calendar?
Well, it would be nice to have some mechanism to let the external
source of diary entries define what should happen. I mean, in the
case of BBDB this is obvious: when pressing "d" this should then
jump to the respective BBDB record.
> This "Searches the file named in `diary-file' for entries that match
> [the date]". There will be no file to search.
>
> Instead you could simply have a function that exports bbdb data to a
> diary file, and include it from the main diary file. Then everything
> would just work, right now.
I don't know whether it makes much sense to jump to an entry in such
an auto-generated file. I'd be rather confused.
next prev parent reply other threads:[~2013-12-01 1:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 14:40 bug#15987: 24.3; diary-add-to-list ignored by diary-mark-entries Roland Winkler
2013-11-30 23:08 ` Glenn Morris
2013-12-01 1:25 ` Roland Winkler [this message]
2013-12-01 12:03 ` Stephen Berman
2013-12-02 1:46 ` Roland Winkler
2019-08-18 17:55 ` Stefan Kangas
2019-08-21 2:48 ` Roland Winkler
2019-08-21 3:06 ` Stefan Kangas
2019-08-21 3:41 ` Roland Winkler
2019-08-21 13:29 ` Stefan Kangas
2019-08-21 14:10 ` Stephen Berman
2019-08-21 15:46 ` Roland Winkler
2019-08-21 16:31 ` Stephen Berman
2019-08-21 16:46 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21146.36855.78802.434475@gargle.gargle.HOWL \
--to=winkler@gnu.org \
--cc=15987@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).