From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Date: Sat, 1 Feb 2020 07:53:18 -0800 (PST) Message-ID: <21024bbe-3e10-4d63-8d25-5e689ca459ff@default> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="110014"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39373@debbugs.gnu.org To: Eli Zaretskii , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 01 16:54:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixv63-000SSj-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 16:54:11 +0100 Original-Received: from localhost ([::1]:47272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixv62-0005aj-22 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 10:54:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52779) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixv5v-0005aR-3R for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 10:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixv5u-0001CS-7b for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 10:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixv5u-0001C8-4X for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 10:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixv5u-0000zj-1b for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 10:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15805724153788 (code B ref 39373); Sat, 01 Feb 2020 15:54:01 +0000 Original-Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 15:53:35 +0000 Original-Received: from localhost ([127.0.0.1]:39318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixv5T-0000z1-CJ for submit@debbugs.gnu.org; Sat, 01 Feb 2020 10:53:35 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:58550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixv5Q-0000yl-Lo for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 10:53:34 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 011FqZo8127069; Sat, 1 Feb 2020 15:53:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=5pAzaBGENolvA6BA3yUzeKontLNIvD6yNCzVozNNsSU=; b=Wlg63GVmscHxjbKIqiVg0WJ5NVol/uYPe4GvpVZVJD85U1wZ4M8UT7a+a389MW5cWHl9 i0EJpKuq9kddcNIi5VHtYqTnHnqIPD/4anu7evLCeULkxZwyniiwCKfJLH0mFo35GPCV w1AOPlx4u6eoo/VOjCm2MJh+39FFUwY90VSftsTqWVppCmPnPFBHswGnE7pSHHc0q9XU WNmAz+Wr3ZeZ98fI26GMnUNo091aS1hPxAjXsB1gzGWkWlASe4FO/3hJWLI0Pthvs6t+ haZV0vxhkmRVxcpgHyX4ayulNttIlGL4x/a7N7U0DjriZEhPt4iNlFn4X5UE8kO3C7vL rg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2xw19q1m3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 01 Feb 2020 15:53:23 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 011FoFkE157417; Sat, 1 Feb 2020 15:53:23 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2xvxfgtnt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 01 Feb 2020 15:53:22 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 011FrJgJ011784; Sat, 1 Feb 2020 15:53:20 GMT In-Reply-To: <83eevekat8.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4954.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9518 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=885 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002010116 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9518 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=933 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002010116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175564 Archived-At: > > 'add-to-list' doesn't work on lexical variables because it's a plain > > function taking the variable symbol as argument. 'push' works on > > lexical variables since it is a macro that expands to direct > > variable reference and setq. >=20 > If that's the case, then why don't we say that loud and clear in the > ELisp manual? (The doc string of add-to-list has some vague > recommendation, not sure if it really talks about this aspect, but > that's definitely not enough for such a serious issue.) >=20 > And doesn't it mean we should audit all the gazillion uses of > add-to-list in our sources, and do that urgently? +1. `add-to-list' uses `symbol-value'. Everything that uses `symbol-value' is in the same boat.