From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Fri, 02 Dec 2022 07:56:06 +0000 Message-ID: <20f32a53dcb7869be445@heytings.org> References: <83a682d66r.fsf@gnu.org> <837d36ceno.fsf@gnu.org> <37dd2827f54f8bbda5e3@heytings.org> <735c1d5b-0d64-a8e1-3aaa-91fc0248abd3@yandex.ru> <97049541-f5b4-ed3b-b8de-7c0bdc86f0f5@yandex.ru> <6e305c9b-7702-133a-3347-f64db05ade3f@yandex.ru> <83mt89kt10.fsf@gnu.org> <834juglesn.fsf@gnu.org> <83r0xkjw5s.fsf@gnu.org> <83pmd3ioxx.fsf@gnu.org> <47153506021498df087c@heytings.org> <83bkomhlmn.fsf@gnu.org> <4715350602cf2ec6860b@heytings.org> <83a646hkat.fsf@gnu.org> <47153506028bbb3bc8b3@heytings.org> <838rjqgu9b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6670"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 08:57:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p10vL-0001YY-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 08:57:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p10uy-0004eq-Ug; Fri, 02 Dec 2022 02:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p10us-0004dl-5B for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 02:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p10ur-0006PN-Sw for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 02:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p10ur-0003LH-PT for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 02:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166996777412810 (code B ref 56682); Fri, 02 Dec 2022 07:57:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 2 Dec 2022 07:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:45104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p10u6-0003KY-8a for submit@debbugs.gnu.org; Fri, 02 Dec 2022 02:56:14 -0500 Original-Received: from heytings.org ([95.142.160.155]:40416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p10u1-0003KP-K1 for 56682@debbugs.gnu.org; Fri, 02 Dec 2022 02:56:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669967767; bh=QfSyEqweVN9qccynk6XWeAjzwcqbTaUglE2f2DhnbBA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=b3Sc7jS8I6eNo+Vt2rsKDUZav6I0V7DwRdgIYVQnbpp3CiZr/IiKiZjgde++o8G67 2N9Xjp10T+pNZeLNnJyVosq3hMIGmDtLH9TbBicbiQnooiwcuwMed1HewMAXzG71+U gBKATCa3HRQ2hmpuTuQabytCU0uzWAGzlU02ifYW6kOZ8avJnL/bzwxHsjCMynKnoL F4m5m/DAqELtK0vCU9Zy8fHNto8e1zWpnXKs1q9/161i9JxnefDS7vr8EDRPx32MDj I1G+PlzA49QKa/pzvT+lpvzGWb+eexiFkgjBK7C9jlLKHzEzgYLSPEqoE2h1FJE+Hc 4HWHnK+Pbaz9Q== In-Reply-To: <838rjqgu9b.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249712 Archived-At: >> It proves that the long line detection loop must be executed on the >> whole buffer. > > No, it doesn't. It shows that the conditions to re-examine buffer text > are incomplete and need to be augmented. > It does, and it's just an example of the general point I'm (apparently unsuccessfully) trying to convey: when redisplay is called, any kind of changes may have been made in the buffer at any point since last redisplay, and we cannot know where these changes occurred. Stefan's proposed approach looks promising, however. >> In this case there are no modifications to the buffer when it is >> widened, so the detection loop is not triggered, and because there was >> no long line in BEGV/ZV before widening Emacs did not activate the long >> line optimizations. > > You didn't explain the problem clearly enough, so I didn't understand it > originally. The actual problem is not that the restriction changes > since the last redisplay, the problem is that the restriction changes > _and_ the number of unsaved buffer text modifications is still below the > threshold of 8. > > Once I understood the scenario, the fix was a simple one-liner, which I > installed yesterday night. > That fix is wrong, sorry. Now the detection loop is triggered each time the user changes the narrowing, in the vast majority of cases for no good reason.