unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>,
	"'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 9532@debbugs.gnu.org
Subject: bug#9532: 24.0.50; `special-display-regexps' is no longer respected
Date: Wed, 21 Sep 2011 09:30:46 -0700	[thread overview]
Message-ID: <208166A8F7EF4681B76EADADCA39822C@us.oracle.com> (raw)
In-Reply-To: <874o05x4l6.fsf@stupidchicken.com>

> > I think the problem here is that display-buffer--special 
> > should not just be in display-buffer-fallback-action but
> > should take precedence over the ACTION argument (it's
> > largely equivalent to display-buffer-alist).
> 
> The problem with this is that if the "special" buffer is already
> displayed in a window, that window is supposed to be used instead of
> popping up a special window (at least, according to old behavior).

Yes, of course.  And it's not just "old behavior".  It's (part of) the
definition of "special-display" buffer.

> We could accomodate this...
> Then another problem arises: all direct switch-to-buffer calls will
> trigger special display for special buffers, which is not consistent
> with old behavior.

Not sure I follow.  Why is that not consistent with past behavior?  Why would we
not always want special display for special-display buffers?

Can you give an example for Emacs 23 and explain how the behavior would be
different for Emacs 24?

> The key difference here is that in Emacs 23 the `info' command
> calls display-buffer (using same-window-regexps to force
> it into the same window),

force it or not, depending on the value of `same-window-regexps' ;-)

> whereas currently `info' uses switch-to-buffer
> (with the intention of transitioning away from same-window-*).

Emacs 24 needs to respect `same-window-*'.  It needs to be compatible with past
Emacs behavior.

> OTOH, I don't see an easy way to handle all the backward
> compatibility exceptions in this case.

FWIW, Martin's code worked fine in this regard.

And please do not call these "exceptions".  Backward compatibility is backward
compatibility.  The various use cases that Emacs has always supported are not
"exceptions".

What sounds like "exceptions", to me (but I'm not sure because I'm not clear
about what you mean), are proposed changes like not always having
special-display buffers be displayed as such (see above - your "not consistent
with old behavior").

The new code needs to DTRT, supporting the same use cases supported in the past.
In particular, it needs to support special-display in the same ways.

It is OK to change how that support is implemented.  It is not OK to remove that
support.

> One possibility is to change `info' etc. back to using
> same-window-regexps with display-buffer, which mostly kicks the
> can down the road to a later release.  Or maybe we should just require
> use of display-buffer-alist for this case.
> 
> Any thoughts?

Perhaps look to Martin's code for an answer?  Even if you decide not to do
everything the same way he did it, perhaps for things like this his code can
help guide you.  Dunno.






  reply	other threads:[~2011-09-21 16:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-17 14:55 bug#9532: 24.0.50; `special-display-regexps' is no longer respected Drew Adams
2011-09-18 15:13 ` Chong Yidong
2011-09-18 17:33   ` Drew Adams
2011-09-20 21:52     ` Drew Adams
2011-09-21  1:38       ` Stefan Monnier
2011-09-21 16:06         ` Chong Yidong
2011-09-21 16:30           ` Drew Adams [this message]
2011-09-21 17:01             ` Chong Yidong
2011-09-21 17:11               ` Drew Adams
2011-10-02 18:44                 ` Drew Adams
2011-10-19 18:51                   ` Drew Adams
2011-10-31 15:24                     ` Drew Adams
2011-11-05 21:17                       ` Drew Adams
2011-11-08  2:59                         ` Stefan Monnier
2011-11-08  5:39                           ` Drew Adams
2011-11-08  6:25                             ` Eli Zaretskii
2011-11-08  6:47                             ` Drew Adams
2011-11-08 13:26                               ` Stefan Monnier
2011-11-08 17:37                           ` Drew Adams
2011-11-08 19:28                             ` Stefan Monnier
2011-09-21 17:59           ` Stefan Monnier
2011-09-21 18:30             ` Chong Yidong
2011-09-22  1:16               ` Stefan Monnier
2011-09-22  3:21                 ` Chong Yidong
2011-09-22  3:37                   ` Chong Yidong
2011-09-22 12:29                     ` Stefan Monnier
2011-09-22 16:15                       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208166A8F7EF4681B76EADADCA39822C@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=9532@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).