From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#73730: 31.0.50; Support for color fonts on MS-Windows Date: Sun, 20 Oct 2024 20:20:29 +0200 Message-ID: <206b72b7-eea9-4515-b68d-69180317452f@imayhem.com> References: <36a6b4d5-c719-44d6-957d-bcd7db5a854b@imayhem.com> <86o73s14x5.fsf@gnu.org> <0a0c622c-5b69-4f30-94b1-67a238e124b4@imayhem.com> <861q0gqpkf.fsf@gnu.org> <0d2238ff-5cf9-4ba7-97ab-11b76892198d@imayhem.com> <86bjzjp7vv.fsf@gnu.org> <80dc50bd-b2d4-4d21-ad38-322412588b3b@imayhem.com> <86cyjuiwah.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6188"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 73730@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 20:22:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2aZ7-0001RN-Os for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 20:22:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2aYk-00056i-FK; Sun, 20 Oct 2024 14:21:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2aYb-00056P-F4 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 14:21:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2aYb-0002I2-70 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 14:21:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=zzdN298MnD+xqMala26aYfvPpqghNGpYhBu/Xpp52Zk=; b=tt7SDsFd0/ZgMfBVmtCBHO3MTqg5chd4a4IMz7w90DEBIQksbkfKEZ04a02/DopZbombg+g+Tns+JcChqVvNDk616W5tMayYNmcz26H1MN1rUdBlTRNts5aIwWq07qTLC1c/N83PBltSO42glREY8rshbL6zHP316QDUJcEUbfunJAA76NGTmY0xK3HHYGfEtNzdKWXPVl6g1y4ybV//ADejZ93ARotwqUR145xMIRmLHfXkUu/hbr+U2iOp58CXOA3A1GTzrSsfrOHOWn8aqWCQUoNn0oPJf0u6tQhSMtbcRc+ZeIxNKjx2TXcHO05aZkdkP+TWL1yTBxS5ryseRw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2aZ0-0005nH-7E for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 14:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73730 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172944846422169 (code B ref -1); Sun, 20 Oct 2024 18:22:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Oct 2024 18:21:04 +0000 Original-Received: from localhost ([127.0.0.1]:48431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2aY4-0005lV-6a for submit@debbugs.gnu.org; Sun, 20 Oct 2024 14:21:04 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2aY2-0005l7-BK for submit@debbugs.gnu.org; Sun, 20 Oct 2024 14:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2aXb-00053L-BQ for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 14:20:35 -0400 Original-Received: from mail.imayhem.com ([82.223.54.191] helo=zealous-pike.82-223-54-191.plesk.page) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2aXY-0002GG-Pp for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 14:20:34 -0400 Original-Received: from [192.168.68.105] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 882D380122 for ; Sun, 20 Oct 2024 18:20:30 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.105] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Language: es-ES In-Reply-To: <86cyjuiwah.fsf@gnu.org> Received-SPF: pass client-ip=82.223.54.191; envelope-from=cpardo@imayhem.com; helo=zealous-pike.82-223-54-191.plesk.page X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293998 Archived-At: On 20/10/2024 18:17, Eli Zaretskii wrote: >> If the case of size <= 0, we are now falling back to >> w32font_text_extents. > > Maybe it's better to use some default size in text_extents instead? > The pixel size of the default font is known (see FRAME_LINE_HEIGHT), > so maybe just use it if you get a font of size zero? That could be a > more future-proof fix, since we could get such fonts in other > situations as well. The reason w32fint_text_extents has a value to return is because when the specified font size is 0: "The font mapper uses a default height value when it searches for a match." So it gives a font with a size that we cannot know, because when we ask it says it is 0. So we may return our own default.