From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 71380@debbugs.gnu.org
Subject: bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php
Date: Fri, 07 Jun 2024 15:25:16 +0200 [thread overview]
Message-ID: <2068418.YKUYFuaPT4@3-191.divsi.unimi.it> (raw)
In-Reply-To: <jwvr0d8rkfr.fsf-monnier+emacs@gnu.org>
In data venerdì 7 giugno 2024 14:53:04 CEST, Stefan Monnier ha scritto:
> >> (dolist (buffer (buffer-list))
> >> (with-current-buffer buffer
> >> (when (derived-mode-p 'php-ts-mode)
> >> (php-ts-mode-set-style val))))
> >>
> >> ?
> > Yes is better. The code above is a copy of c-ts-mode--indent-style-setter.
> > It seemed too complicated to me too, but since it had been used there
> > I thought there was some reason.
>
> Aha! Thanks, I guess we should check the
> `c-ts-mode--indent-style-setter` situation, as well, then.
>
> >> > +(defvar php-ts-mode--syntax-table
> >> > + (let ((table (make-syntax-table)))
> >> > + ;; Taken from the cc-langs version
> >>
> >> Does this mean it comes from "the cc-mode-based `php-mode.el`" or from
> >> `cc-langs.el` (and if so, which part, exactly)?
> >>
> >> > +;; taken from c-ts-mode
> >> [...]
> >> > +;; taken from c-ts-mode
> >>
> >> Are these literal copies?
> >> Maybe we should consolidate the code with that of `c-ts-mode` to avoid
> >> the code duplication?
> >>
> > Yes, the first part is a literal copy of c-ts-mode--syntax-table.
> > java-ts-mode does exactly the same thing, so I thought it best
> > to avoid depending on c-ts-mode--syntax-table.
>
> Hmm... that makes the comment hard to understand.
>
Yes. Perhaps it would be better to remove it.
> >> > + (cond
> >> > + ((equal comment-start "/*") (setq-local comment-end "*/"))
> >> > + ((equal comment-start "//") (setq-local comment-end ""))
> >> > + ((equal comment-start "#") (setq-local comment-end ""))
> >> > + ((equal comment-start "/**") (setq-local comment-end "*/")))
> >> > + (setq mode-name (concat "PHP" (string-trim-right comment-start)))
> >> > + (force-mode-line-update))
> >> Is `comment-start` important enough to merit being part of the mode name?
> > Sorry. I didn't understand. Could you please clarify?
>
> You have:
>
> (setq mode-name (concat "PHP" (string-trim-right comment-start)))
>
> which means the mode-line will display `comment-start` (along with the
> usual other things). Is it really a good idea, given how the mode-line
> is already often "too full"? Which other major mode does that?
> What's special about `comment-start` to make it deserve this honor?
>
>
c-ts-mode-set-modeline does the same, which is why I did it too.
> Stefan
>
>
Thanks
Vincenzo
next prev parent reply other threads:[~2024-06-07 13:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:59 bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php Vincenzo Pupillo
2024-06-06 6:58 ` Eli Zaretskii
2024-06-07 10:45 ` Vincenzo Pupillo
2024-06-07 11:12 ` Eli Zaretskii
2024-06-07 12:50 ` Vincenzo Pupillo
2024-06-07 13:44 ` Eli Zaretskii
2024-06-07 15:05 ` Vincenzo Pupillo
2024-06-08 9:31 ` Vincenzo Pupillo
2024-06-08 10:45 ` Eli Zaretskii
2024-06-08 11:15 ` Vincenzo Pupillo
2024-06-09 13:54 ` Eli Zaretskii
2024-06-09 17:23 ` Vincenzo Pupillo
2024-06-09 17:49 ` Eli Zaretskii
2024-06-09 19:37 ` Vincenzo Pupillo
2024-06-09 20:36 ` Vincenzo Pupillo
2024-06-12 9:25 ` Vincenzo Pupillo
2024-06-12 18:27 ` Eli Zaretskii
2024-06-12 20:44 ` Vincenzo Pupillo
2024-06-09 13:53 ` Eli Zaretskii
2024-06-06 14:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 9:04 ` Vincenzo Pupillo
2024-06-07 12:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 13:25 ` Vincenzo Pupillo [this message]
2024-06-07 13:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 14:37 ` Vincenzo Pupillo
2024-06-06 14:54 ` Andrea Corallo
2024-06-07 8:36 ` Vincenzo Pupillo
2024-06-07 13:39 ` Andrea Corallo
2024-06-07 17:02 ` Vincenzo Pupillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2068418.YKUYFuaPT4@3-191.divsi.unimi.it \
--to=v.pupillo@gmail.com \
--cc=71380@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).