* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
@ 2012-10-25 15:16 Ulrich Mueller
2012-10-29 11:53 ` Ulrich Mueller
0 siblings, 1 reply; 12+ messages in thread
From: Ulrich Mueller @ 2012-10-25 15:16 UTC (permalink / raw)
To: 12733
With Emacs from BZR (revision 110662) linked against the Motif toolkit
(version 2.3.4), I observe that after disabling the menu bar, the
frame doesn't have the correct height. The result is that the modeline
and the minibuffer are no longer visible.
Steps to reproduce:
$ emacs -Q
;; Lisp Interaction Mode:
(frame-pixel-height)
608
(frame-height)
38
(menu-bar-mode -1)
nil
;; At this point, the X window shrinks by the height of the menu bar.
;; However, the bottom of the frame contents (containing modeline and
;; minibuffer) are no longer visible.
(frame-pixel-height)
608
;; Number of lines is _larger_ than before:
(frame-height)
40
In GNU Emacs 24.2.50.1 (x86_64-pc-linux-gnu, Motif Version 2.3.4)
of 2012-10-25 on juno
Bzr revision: eggert@cs.ucla.edu-20121025043539-ywusszr9cgklw9p7
Windowing system distributor `The X.Org Foundation', version 11.0.11300000
System Description: Gentoo Base System release 2.2
Configured using:
`configure '--prefix=/usr' '--build=x86_64-pc-linux-gnu'
'--host=x86_64-pc-linux-gnu' '--mandir=/usr/share/man'
'--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc'
'--localstatedir=/var/lib' '--libdir=/usr/lib64'
'--disable-dependency-tracking' '--program-suffix=-emacs-24-vcs'
'--program-transform-name=s/emacs-[0-9].*/emacs-24-vcs/'
'--infodir=/usr/share/info/emacs-24-vcs'
'--enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp'
'--with-crt-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64'
'--with-gameuser=games' '--without-compress-info' '--without-hesiod'
'--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus'
'--without-gnutls' '--without-xml2' '--without-selinux'
'--without-wide-int' '--with-sound' '--with-x' '--without-ns'
'--without-gconf' '--without-gsettings' '--without-toolkit-scroll-bars'
'--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff'
'--with-xpm' '--with-imagemagick' '--with-xft' '--without-libotf'
'--without-m17n-flt' '--with-x-toolkit=motif'
'GENTOO_PACKAGE=app-editors/emacs-vcs-24.2.9999' 'EBZR_BRANCH=trunk'
'EBZR_REVNO=110662' 'build_alias=x86_64-pc-linux-gnu'
'host_alias=x86_64-pc-linux-gnu' 'CFLAGS=-march=core2 -ggdb -O2 -pipe
-O2' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed' 'CPPFLAGS=''
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-25 15:16 bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif Ulrich Mueller
@ 2012-10-29 11:53 ` Ulrich Mueller
2012-10-30 18:42 ` Jan Djärv
0 siblings, 1 reply; 12+ messages in thread
From: Ulrich Mueller @ 2012-10-29 11:53 UTC (permalink / raw)
To: 12733
>>>>> On Thu, 25 Oct 2012, Ulrich Mueller wrote:
> With Emacs from BZR (revision 110662) linked against the Motif toolkit
> (version 2.3.4), I observe that after disabling the menu bar, the
> frame doesn't have the correct height. The result is that the modeline
> and the minibuffer are no longer visible.
> Steps to reproduce:
> $ emacs -Q
> ;; Lisp Interaction Mode:
> (frame-pixel-height)
> 608
In fact, there's already an inconsistency here. The documentation of
frame-pixel-height says:
With the Motif or Lucid toolkits, it also includes the tool bar
(but not the menu bar).
However, if I measure the height on my screen, it is 608 pixels in
total, i.e. including _both_ the tool bar and the menu bar. (I see the
same inconsistency if configured --with-x-toolkit=lucid, BTW.)
Is it an error in the code or in the documentation?
> (frame-height)
> 38
> (menu-bar-mode -1)
> nil
> ;; At this point, the X window shrinks by the height of the menu bar.
> ;; However, the bottom of the frame contents (containing modeline and
> ;; minibuffer) are no longer visible.
> (frame-pixel-height)
> 608
This value is definitely wrong. Measured height is only 572 pixels.
> ;; Number of lines is _larger_ than before:
> (frame-height)
> 40
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-29 11:53 ` Ulrich Mueller
@ 2012-10-30 18:42 ` Jan Djärv
2012-10-30 20:10 ` Ulrich Mueller
0 siblings, 1 reply; 12+ messages in thread
From: Jan Djärv @ 2012-10-30 18:42 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 12733
Hello.
29 okt 2012 kl. 12:53 skrev Ulrich Mueller <ulm@gentoo.org>:
>>>>>> On Thu, 25 Oct 2012, Ulrich Mueller wrote:
>
>> With Emacs from BZR (revision 110662) linked against the Motif toolkit
>> (version 2.3.4), I observe that after disabling the menu bar, the
>> frame doesn't have the correct height. The result is that the modeline
>> and the minibuffer are no longer visible.
>
>> Steps to reproduce:
>
>> $ emacs -Q
>
>> ;; Lisp Interaction Mode:
>> (frame-pixel-height)
>> 608
>
> In fact, there's already an inconsistency here. The documentation of
> frame-pixel-height says:
>
> With the Motif or Lucid toolkits, it also includes the tool bar
> (but not the menu bar).
>
> However, if I measure the height on my screen, it is 608 pixels in
> total, i.e. including _both_ the tool bar and the menu bar. (I see the
> same inconsistency if configured --with-x-toolkit=lucid, BTW.)
>
> Is it an error in the code or in the documentation?
I've fixed the documentation.
>
>> (frame-height)
>> 38
>> (menu-bar-mode -1)
>> nil
>> ;; At this point, the X window shrinks by the height of the menu bar.
>> ;; However, the bottom of the frame contents (containing modeline and
>> ;; minibuffer) are no longer visible.
Do they appear if you resize the frame a bit?
>
>> (frame-pixel-height)
>> 608
>
> This value is definitely wrong. Measured height is only 572 pixels.
>
>> ;; Number of lines is _larger_ than before:
>> (frame-height)
>> 40
I can't reproduce the problem. It sounds as Emacs does not get the resize event from your window manager. Can you try with another window manager? What are you using now?
Jan D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-30 18:42 ` Jan Djärv
@ 2012-10-30 20:10 ` Ulrich Mueller
2012-10-30 21:08 ` Jan Djärv
0 siblings, 1 reply; 12+ messages in thread
From: Ulrich Mueller @ 2012-10-30 20:10 UTC (permalink / raw)
To: Jan Djärv; +Cc: 12733
>>>>> On Tue, 30 Oct 2012, Jan Djärv wrote:
>>> With Emacs from BZR (revision 110662) linked against the Motif toolkit
>>> (version 2.3.4), I observe that after disabling the menu bar, the
>>> frame doesn't have the correct height. The result is that the modeline
>>> and the minibuffer are no longer visible.
>>> (menu-bar-mode -1)
>>> nil
>>> ;; At this point, the X window shrinks by the height of the menu bar.
>>> ;; However, the bottom of the frame contents (containing modeline and
>>> ;; minibuffer) are no longer visible.
> Do they appear if you resize the frame a bit?
Yes, they do appear.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-30 20:10 ` Ulrich Mueller
@ 2012-10-30 21:08 ` Jan Djärv
2012-10-31 10:26 ` martin rudalics
0 siblings, 1 reply; 12+ messages in thread
From: Jan Djärv @ 2012-10-30 21:08 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 12733
Hello.
30 okt 2012 kl. 21:10 skrev Ulrich Mueller <ulm@gentoo.org>:
>>>>>> On Tue, 30 Oct 2012, Jan Djärv wrote:
>
>>>> With Emacs from BZR (revision 110662) linked against the Motif toolkit
>>>> (version 2.3.4), I observe that after disabling the menu bar, the
>>>> frame doesn't have the correct height. The result is that the modeline
>>>> and the minibuffer are no longer visible.
>
>>>> (menu-bar-mode -1)
>>>> nil
>>>> ;; At this point, the X window shrinks by the height of the menu bar.
>>>> ;; However, the bottom of the frame contents (containing modeline and
>>>> ;; minibuffer) are no longer visible.
>
>> Do they appear if you resize the frame a bit?
>
> Yes, they do appear.
So the size calculation is sound, Emacs is either not getting resize events or does not understand them. This is usually window manager related.
Jan D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-30 21:08 ` Jan Djärv
@ 2012-10-31 10:26 ` martin rudalics
2012-11-01 7:22 ` Jan Djärv
0 siblings, 1 reply; 12+ messages in thread
From: martin rudalics @ 2012-10-31 10:26 UTC (permalink / raw)
To: Jan Djärv; +Cc: 12733, Ulrich Mueller
> So the size calculation is sound, Emacs is either not getting resize
> events or does not understand them. This is usually window manager
> related.
Are you sure that we don't miss calling the display engine here after
updating the frame parameters?
martin
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-10-31 10:26 ` martin rudalics
@ 2012-11-01 7:22 ` Jan Djärv
2012-11-01 9:12 ` Ulrich Mueller
2012-11-01 13:50 ` Eli Zaretskii
0 siblings, 2 replies; 12+ messages in thread
From: Jan Djärv @ 2012-11-01 7:22 UTC (permalink / raw)
To: martin rudalics; +Cc: 12733, Ulrich Mueller
Hello.
31 okt 2012 kl. 11:26 skrev martin rudalics <rudalics@gmx.at>:
> > So the size calculation is sound, Emacs is either not getting resize
> > events or does not understand them. This is usually window manager
> > related.
>
> Are you sure that we don't miss calling the display engine here after
> updating the frame parameters?
There is no calling the display engine in this case, there is just setting the frame garbaged and adjusting the frame size.
Given the fact that I can't reproduce it suggests it is working for some cases at least. But the exact environment of the reporter is not known, we don't know which window manager he uses. So we probably can't reproduce this util we know that.
Jan D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-11-01 7:22 ` Jan Djärv
@ 2012-11-01 9:12 ` Ulrich Mueller
2012-11-02 17:26 ` Jan Djärv
2012-11-01 13:50 ` Eli Zaretskii
1 sibling, 1 reply; 12+ messages in thread
From: Ulrich Mueller @ 2012-11-01 9:12 UTC (permalink / raw)
To: Jan Djärv; +Cc: 12733
>>>>> On Thu, 1 Nov 2012, Jan Djärv wrote:
> There is no calling the display engine in this case, there is just
> setting the frame garbaged and adjusting the frame size.
> Given the fact that I can't reproduce it suggests it is working for
> some cases at least. But the exact environment of the reporter is
> not known, we don't know which window manager he uses. So we
> probably can't reproduce this util we know that.
Window manager here is xfwm4 version 4.10.0.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-11-01 9:12 ` Ulrich Mueller
@ 2012-11-02 17:26 ` Jan Djärv
2012-11-02 18:44 ` Ulrich Mueller
0 siblings, 1 reply; 12+ messages in thread
From: Jan Djärv @ 2012-11-02 17:26 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 12733-done
Hello.
1 nov 2012 kl. 10:12 skrev Ulrich Mueller <ulm@gentoo.org>:
>>>>>> On Thu, 1 Nov 2012, Jan Djärv wrote:
>
>> There is no calling the display engine in this case, there is just
>> setting the frame garbaged and adjusting the frame size.
>
>> Given the fact that I can't reproduce it suggests it is working for
>> some cases at least. But the exact environment of the reporter is
>> not known, we don't know which window manager he uses. So we
>> probably can't reproduce this util we know that.
>
> Window manager here is xfwm4 version 4.10.0.
It is reproducible with that WM. My guess is that Xt filters out the ConfigureNotify from xfwm4 because of a bad timestamp or serial.
I have checked in a fix in the trunk.
Jan D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-11-02 17:26 ` Jan Djärv
@ 2012-11-02 18:44 ` Ulrich Mueller
2012-11-03 11:38 ` Jan Djärv
0 siblings, 1 reply; 12+ messages in thread
From: Ulrich Mueller @ 2012-11-02 18:44 UTC (permalink / raw)
To: Jan Djärv; +Cc: 12733-done
>>>>> On Fri, 2 Nov 2012, Jan Djärv wrote:
>> Window manager here is xfwm4 version 4.10.0.
> It is reproducible with that WM. My guess is that Xt filters out
> the ConfigureNotify from xfwm4 because of a bad timestamp or serial.
> I have checked in a fix in the trunk.
Thank you. I can confirm that I don't see the problem in the trunk
(revno 110771) any more.
Since this was a regression from Emacs 23, I wonder if the fix
wouldn't qualify for the emacs-24 branch?
Ulrich
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-11-02 18:44 ` Ulrich Mueller
@ 2012-11-03 11:38 ` Jan Djärv
0 siblings, 0 replies; 12+ messages in thread
From: Jan Djärv @ 2012-11-03 11:38 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 12733-done
Hello.
2 nov 2012 kl. 19:44 skrev Ulrich Mueller <ulm@gentoo.org>:
>>>>>> On Fri, 2 Nov 2012, Jan Djärv wrote:
>
>>> Window manager here is xfwm4 version 4.10.0.
>
>> It is reproducible with that WM. My guess is that Xt filters out
>> the ConfigureNotify from xfwm4 because of a bad timestamp or serial.
>
>> I have checked in a fix in the trunk.
>
> Thank you. I can confirm that I don't see the problem in the trunk
> (revno 110771) any more.
>
> Since this was a regression from Emacs 23, I wonder if the fix
> wouldn't qualify for the emacs-24 branch?
I put it there.
Jan D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif
2012-11-01 7:22 ` Jan Djärv
2012-11-01 9:12 ` Ulrich Mueller
@ 2012-11-01 13:50 ` Eli Zaretskii
1 sibling, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2012-11-01 13:50 UTC (permalink / raw)
To: Jan Djärv; +Cc: ulm, 12733
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Thu, 1 Nov 2012 08:22:13 +0100
> Cc: 12733@debbugs.gnu.org, Ulrich Mueller <ulm@gentoo.org>
>
> > Are you sure that we don't miss calling the display engine here after
> > updating the frame parameters?
>
> There is no calling the display engine in this case, there is just setting the frame garbaged and adjusting the frame size.
Which will cause the display engine reallocate the glyph matrices and
redraw everything at the next redisplay opportunity.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-11-03 11:38 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 15:16 bug#12733: 24.2.50; Disabling menu bar doesn't resize frame correctly --with-x-toolkit=motif Ulrich Mueller
2012-10-29 11:53 ` Ulrich Mueller
2012-10-30 18:42 ` Jan Djärv
2012-10-30 20:10 ` Ulrich Mueller
2012-10-30 21:08 ` Jan Djärv
2012-10-31 10:26 ` martin rudalics
2012-11-01 7:22 ` Jan Djärv
2012-11-01 9:12 ` Ulrich Mueller
2012-11-02 17:26 ` Jan Djärv
2012-11-02 18:44 ` Ulrich Mueller
2012-11-03 11:38 ` Jan Djärv
2012-11-01 13:50 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).