From 8302329ab590abe4a8b4f05d32894be93410e10c Mon Sep 17 00:00:00 2001 From: Olivier Certner Date: Thu, 6 Apr 2023 10:16:33 +0200 Subject: [PATCH 1/3] VC: CVS: Fix ROOT file parsing * lisp/vc/vc-cvs.el (vc-cvs-parse-root): Don't artificially prepend 'x:' in an attempt to preserve ":" at start, and not even compensating for it later on. Function `split-string' with an explicit SEPARATORS doesn't default OMIT-NULLS to t. --- lisp/vc/vc-cvs.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el index 6e0246ea762..695442b98d4 100644 --- a/lisp/vc/vc-cvs.el +++ b/lisp/vc/vc-cvs.el @@ -846,9 +846,7 @@ vc-cvs-parse-root is `ext'. For an empty string, nil is returned (invalid CVS root)." ;; Split CVS root into colon separated fields (0-4). - ;; The `x:' makes sure, that leading colons are not lost; - ;; `HOST:/PATH' is then different from `:METHOD:/PATH'. - (let* ((root-list (cdr (split-string (concat "x:" root) ":"))) + (let* ((root-list (cdr (split-string root ":"))) (len (length root-list)) ;; All syntactic varieties will get a proper METHOD. (root-list -- 2.39.2