From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75355: [PATCH 0/1] Improve comment cycling in log-edit Date: Sat, 4 Jan 2025 17:28:59 +0100 Message-ID: <20250104162859.13378-1-jonas@bernoul.li> Reply-To: Jonas Bernoulli Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13768"; mail-complaints-to="usenet@ciao.gmane.io" To: 75355@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 17:30:28 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU72h-0003PV-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 17:30:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU72M-00066D-0q; Sat, 04 Jan 2025 11:30:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU72J-000643-3A for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:30:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU72I-0003Gk-Qp for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:30:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=ZSXQkq7NjYpCZIT8JIcIK4gykfD06xw6vDlFqWxHc7Y=; b=iJrAsQL3YGgR9MWl/455vKgznRjQgiAJNZtNwz36GCdR8nU8jb+WBif0Zqhe8o7DzKPssbejN9ogz8ver4fmiskxSQFR8T+31+KBgbxTOUjUbSst6Gra2D8QrohmVxPnW2UCDnlm/NzUJuRsaTD0ffyv55EIwxGPrBaXaU32Dc4YVsL04htjJR6rKd0PXkU7cbVWOjijPdrF7FbIRDhB8TjjTL/JRu6uwdUTO6G7lcQYJ0r7ECC8x7ZEeIrcrtk5m5Tj3caAZJyLQSNVOeWC8rLDLn/ZsOvD88kZM7R2XCjpTQTHqOxiu47OQspaaTwsvKKwvAXTDVP0N4Oy7T1cyw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU72I-0000dk-Cs for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17360081652378 (code B ref -1); Sat, 04 Jan 2025 16:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jan 2025 16:29:25 +0000 Original-Received: from localhost ([127.0.0.1]:56853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU71h-0000cI-2B for submit@debbugs.gnu.org; Sat, 04 Jan 2025 11:29:25 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:37870) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU71c-0000bw-E0 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 11:29:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU71V-00061u-Be for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:29:13 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU71T-0002YV-0K for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:29:13 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C82EA164AE; Sat, 4 Jan 2025 17:29:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:from:from; s=sel2011a; t=1736008143; bh=ZJ W/gSAjqp6jL7Kl35Nx5KoYtp88SzmMAF8Lcn3BAT4=; b=aQwZBEsSzVPjlj/Aty G76bMLG+h5lI+oexa53zVghtutKWw7tO5K8OPHhgKkcNkf9MgrOMPlUsAzHea0Zz I1XDKBf8f5m6Kag4CRbnrQ749Vcz4r/55dozCXPfoCNd0priN+vrSU1NX1vy6WHU UpNiry/pwWJ1NfQOoSMBYPSI0= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id mS5bcm0yehJQ; Sat, 4 Jan 2025 17:29:03 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 45F0C1648A; Sat, 4 Jan 2025 17:29:02 +0100 (CET) X-Mailer: git-send-email 2.47.1 Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298427 Archived-At: Hello, In https://lists.gnu.org/archive/html/emacs-devel/2025-01/msg00041.html we are discussing adding git-commit.el to Emacs. This change is triggered by that discussion but what I suggest here is to first move some code out of git-commit.el and into log-edit.el. Previously git-commit.el wrapped around some commands from log-edit.el to provide better variants. The following patch instead modifies the existing commands. It also adds a new command and a new helper function. Cheers, Jonas Jonas Bernoulli (1): Improve comment cycling in log-edit lisp/vc/log-edit.el | 62 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 59 insertions(+), 3 deletions(-) -- 2.47.1