From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christoph Badura Newsgroups: gmane.emacs.bugs Subject: bug#72341: VC: CVS template lines not stripped when committing Date: Fri, 9 Aug 2024 17:11:51 +0200 Message-ID: <20240809151150.GV9440@irregular-apocalypse.k.bsd.de> References: <20240728123256.GW9440@irregular-apocalypse.k.bsd.de> <86plqxz9t0.fsf@gnu.org> <20240728192115.GY9440@irregular-apocalypse.k.bsd.de> <86le1lylud.fsf@gnu.org> <20240729095312.GZ9440@irregular-apocalypse.k.bsd.de> <86a5i0z89z.fsf@gnu.org> <864j83wfwd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15478"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Dmitry Gutov , 72341@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 09 17:12:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scRIU-0003pr-Qm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Aug 2024 17:12:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scRID-0001Kw-JK; Fri, 09 Aug 2024 11:12:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scRIB-0001Ki-BZ for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 11:12:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1scRIB-0007Dz-2A for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 11:12:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=YiAiycWt6O8Ho8mfpyHHYaspg6w374K+gS1yT8jcRtU=; b=QplijIQDYOH3PF7VJWh7l6Uvcln9GcOW3Lsm7AY2rL5LicwXZQa+wJWrCZcgWUNBiw5+4HUalHOkm2Wt2+IoW19Fc+RgxtEDcRWVhjdvecrg/Yg4IQYYJaLIEVSgzHImdsLeg7KCNcFmoZc7tpbZm97phknxMRM7cznLtkzbze5jFkrnxw67G42DVWBXOatkNeg/LTy+MKAS0/srFZiSYO8QiS36KziG03KkwGYK+80Kw0qcBiQ23jTulfbwoxgiltjt0/Yg5n5EGj9HFv4gqs2oqLE3BDKJs9Ga+djngJlSow5W7rVlHOR9DJJzbbYJi1SIEtKGgXUz4dOqr/gPxw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1scRIc-0002Xk-HM for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christoph Badura Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Aug 2024 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72341 X-GNU-PR-Package: emacs Original-Received: via spool by 72341-submit@debbugs.gnu.org id=B72341.17232163469724 (code B ref 72341); Fri, 09 Aug 2024 15:13:02 +0000 Original-Received: (at 72341) by debbugs.gnu.org; 9 Aug 2024 15:12:26 +0000 Original-Received: from localhost ([127.0.0.1]:38502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scRI1-0002Wl-P0 for submit@debbugs.gnu.org; Fri, 09 Aug 2024 11:12:26 -0400 Original-Received: from moe.eta.tal.de ([195.8.227.228]:42636 helo=moc.eta.tal.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scRHy-0002Wc-9t for 72341@debbugs.gnu.org; Fri, 09 Aug 2024 11:12:24 -0400 Original-Received: from irregular-apocalypse.k.bsd.de (unknown [82.139.197.224]) by smtp.tal.de (Postfix) with ESMTP id 645B48000C6A; Fri, 9 Aug 2024 17:11:51 +0200 (CEST) Original-Received: by irregular-apocalypse.k.bsd.de (Postfix, from userid 201) id 1552F918D4; Fri, 9 Aug 2024 17:11:51 +0200 (CEST) Content-Disposition: inline In-Reply-To: <864j83wfwd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289970 Archived-At: Sorry for the delay. On Fri, Aug 02, 2024 at 10:19:30AM +0300, Eli Zaretskii wrote: > > Date: Tue, 30 Jul 2024 16:35:29 +0300 > > Cc: 72341@debbugs.gnu.org > > From: Dmitry Gutov > > > > On 29/07/2024 15:34, Eli Zaretskii wrote: > > > I'm unsure how to proceed with this. My bother is that this is a > > > definite change in behavior wrt what VC did until now. Users of VC > > > might be unaware of this removal, and could start some log lines with > > > the prefix, which will mysteriously disappear from the log message. > > > > > > Dmitry, WDYT? Maybe we should add this removal guarded by a user > > > option, by default off? Or maybe we can identify where the template > > > starts and ends, and only remove in that region? > > > > If we do this, we'd only remove the lines starting with "CVS:". We could > > also add special syntax highlighting for them. That would probably be > > enough. > Agreed. I'm afraid my emacs-fu isn't strong enough for that. > > Then vc-cvs-checkin would additionally process the commit message string > > returned by log-edit-extract-headers. > > > > Note that it seems we only handle "templates" for CVS and RCS, so there > > is no prior art for implementing this feature. > > Right. Patches welcome to implement this. Cool. I'll get back to this. But probably not this month. I'm extremly busy right now. --chris