From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christoph Badura Newsgroups: gmane.emacs.bugs Subject: bug#72341: VC: CVS template lines not stripped when committing Date: Mon, 29 Jul 2024 11:53:13 +0200 Message-ID: <20240729095312.GZ9440@irregular-apocalypse.k.bsd.de> References: <20240728123256.GW9440@irregular-apocalypse.k.bsd.de> <86plqxz9t0.fsf@gnu.org> <20240728192115.GY9440@irregular-apocalypse.k.bsd.de> <86le1lylud.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/1.5.20 (2009-06-14) Cc: 72341@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 29 11:54:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYN50-0009Fw-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jul 2024 11:54:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYN4i-0004pT-QQ; Mon, 29 Jul 2024 05:53:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYN4g-0004p6-My for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 05:53:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYN4g-0005dk-9B for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 05:53:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=4zuGDH9TG7YkqS+bn8zRKhPYxajswynZW6w4gnz4LTU=; b=RcNwZLLzqGgP/5CTjqJ8FRV3j1bU2LMNo/wuLLzaCC+iwJ1Trp2WexiF3c9ddJqzwdMQ95vuyOBttn7pO4vwHi5yDOJ1C7NctiisJRbCaqrbeSdHCeIxtewJVvZtY8GO7XPS5pjLt1BceuUdZE9eudBHiC6wdpoLo/AtUZe7MTYcRSYTsRfkGF2oux85xXC1iz8qqveTktfXnunQNyWBLfq/ByPhG+AFsQm5aQotjVy8mx9reM3rNlDyRkDPwdV7CxRapOeh8I+3EoWlRWyW8P8c1/wUtz8gl/XP98EO/aobRZrDQeD3h4uH3bK/iYzkF3xnfUJcWABK2uHd3GCYJw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sYN4r-0006xL-TM for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 05:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christoph Badura Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2024 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72341 X-GNU-PR-Package: emacs Original-Received: via spool by 72341-submit@debbugs.gnu.org id=B72341.172224681026699 (code B ref 72341); Mon, 29 Jul 2024 09:54:01 +0000 Original-Received: (at 72341) by debbugs.gnu.org; 29 Jul 2024 09:53:30 +0000 Original-Received: from localhost ([127.0.0.1]:44881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYN4M-0006wX-AI for submit@debbugs.gnu.org; Mon, 29 Jul 2024 05:53:30 -0400 Original-Received: from moe.eta.tal.de ([195.8.227.228]:58438 helo=moc.eta.tal.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYN4K-0006wO-A5 for 72341@debbugs.gnu.org; Mon, 29 Jul 2024 05:53:29 -0400 Original-Received: from irregular-apocalypse.k.bsd.de (unknown [82.139.197.224]) by smtp.tal.de (Postfix) with ESMTP id 0A3CD8015748; Mon, 29 Jul 2024 11:53:13 +0200 (CEST) Original-Received: by irregular-apocalypse.k.bsd.de (Postfix, from userid 201) id 67034918D3; Mon, 29 Jul 2024 11:53:13 +0200 (CEST) Content-Disposition: inline In-Reply-To: <86le1lylud.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289509 Archived-At: On Mon, Jul 29, 2024 at 05:26:50AM +0300, Eli Zaretskii wrote: > Somewhat clearer, thanks. I don't see this stripping feature > documented in the CVS manual; did I miss something? I didn't see it documented either. The closest thing that comes to documentation of that feature is the documentation for rcsinfo: https://www.gnu.org/software/trans-coord/manual/cvs/html_node/rcsinfo.html#rcsinfo It is implemented in src/logmsg.c:do_editor(). > And one more questions: where do those "CVS:" lines come from when you > use the template file? They have to be be in the template file. I figure the idea is that the template files can contain "mandatory" text that will be part of the actuall log message and "explanatory" text, prefixed with "CVS: ", that will be stripped after the commit message has been edited. As an example, here's the default template for the NetBSD repositories: ----------------8<------------------8<------------------8<----------------- CVS: ---------------------------------------------------------------------- CVS: CVSROOT cvs.NetBSD.org:/cvsroot CVS: please use "PR category/123" to have the commitmsg appended to PR 123 ----------------8<------------------8<------------------8<----------------- I'm only aware of the NetBSD and pkgsrc repositories that make use of CVS templates. And their template files contain only lines prefixed with "CVS: ". Off topic and speaking of documentation. I noticed that https://www.gnu.org/software/emacs/manual/html_node/emacs/Log-Buffer.html doesn't document C-c C-k and doesn't explain how the region is set up so that an initial C-w will kill from point to the end of the buffer. log-edit's documentation is also not correct with regard to this (i.e. the entire log buffer isn't emptied as point is after the Summary: header). Is that worth reporting separately? --chris