From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: mohkale@kisara.moe Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames Date: Sat, 22 Apr 2023 11:21:45 +0100 Message-ID: <20230422102146.93003-1-mohkale@kisara.moe> References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mohsin Kaleem To: Eli Zaretskii , 62994@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 22 12:22:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqANk-0001eI-AO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Apr 2023 12:22:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqANY-0002LW-6H; Sat, 22 Apr 2023 06:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqANW-0002Kh-Gk for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 06:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqANW-0004pr-8j for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 06:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqANW-0002z1-3W for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 06:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: mohkale@kisara.moe Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.168215891911450 (code B ref 62994); Sat, 22 Apr 2023 10:22:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 22 Apr 2023 10:21:59 +0000 Original-Received: from localhost ([127.0.0.1]:41903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqANT-0002yX-2a for submit@debbugs.gnu.org; Sat, 22 Apr 2023 06:21:59 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:58988 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqANN-0002yD-Lz for 62994@debbugs.gnu.org; Sat, 22 Apr 2023 06:21:57 -0400 Original-Received: from localhost.localdomain (unknown [146.70.133.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 07D2DA0FB5; Sat, 22 Apr 2023 12:21:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1682158912; bh=6g0KC4G4H/YUwO7HIoEj+HjhIuo6Y2jWHVVql078lDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zXeim4WlCdI4O9EWPFGWSYPShk3extrqqldjFOSN9zt8yjWR9JtTQkczR8mW4X1IA bs4Ldl73kow6teI77+0Q/1HRh8cI45MFMTYjWPi4YioaueppB3KIZBzye5DHw32X7G GkBlnvcwYcsxn0N7s06qlqfEFDk31LjJSge/O6W3vBjJqXcPi7QPYm80uylNLu/XsS L6Zdjp8bZYMkq2TufQ/op6Q/4yW8MCZU3ZLhDOc7+uCLnQktXJJUfjp3GeXLlYzyuV s/CHB57Dv0pJxhB+UMm1esvao/NEfSHVPhcH1W69eKvQwHFcuDd5DNOiFcZ/ZQQc0l ZIwEKYti5TpqA== X-Mailer: git-send-email 2.40.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260452 Archived-At: From: Mohsin Kaleem Modern terminals (such as kitty) support setting the style of an underline with the escape sequence exposed in the Smulx termcap. This allows for (among others) wavy underlines on terminals. These terminals also support setting the color of these underlines using a separate escape sequence that to the best of my knowledge is not exposed as a termcap but has been adopted by other terminal supporting editors like neovim. Version 3: All changed hunks reformatted with M-x tabify. I think the only comment that hasn't been actioned on is whether to retain the original order of underline styles in face_underline_type. Mohsin Kaleem (1): Add support for colored and styled underlines on tty frames etc/NEWS | 13 +++++ lisp/cus-face.el | 5 +- src/dispextern.h | 10 ++-- src/term.c | 54 +++++++++++++++++++-- src/termchar.h | 7 +++ src/xfaces.c | 121 ++++++++++++++++++++++++++++++++++++++++++----- 6 files changed, 190 insertions(+), 20 deletions(-) -- 2.40.0