From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: mohkale@kisara.moe Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v2 0/1] Support styled underlines on tty Emacs frames Date: Fri, 21 Apr 2023 20:24:32 +0100 Message-ID: <20230421192433.579140-1-mohkale@kisara.moe> References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10330"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mohsin Kaleem To: Eli Zaretskii , 62994@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 21 21:25:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppwNt-0002WP-Lp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Apr 2023 21:25:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppwNU-0000xk-GI; Fri, 21 Apr 2023 15:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppwNS-0000xD-Oo for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 15:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppwNS-0004ZY-FG for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 15:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppwNR-0002AC-Tn for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 15:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: mohkale@kisara.moe Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Apr 2023 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.16821050818270 (code B ref 62994); Fri, 21 Apr 2023 19:25:01 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 21 Apr 2023 19:24:41 +0000 Original-Received: from localhost ([127.0.0.1]:41168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppwN7-00029K-G1 for submit@debbugs.gnu.org; Fri, 21 Apr 2023 15:24:41 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:35940 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppwN5-00029B-KG for 62994@debbugs.gnu.org; Fri, 21 Apr 2023 15:24:40 -0400 Original-Received: from localhost.localdomain (unknown [146.70.132.151]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 65B23A0FB5; Fri, 21 Apr 2023 21:24:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1682105078; bh=i57P11yBj/cjk+R5yhu47yBft06LG9MEpAOAQb4v2zQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F28vm/o+VKNoyDmNIaBB3z93Dv2WZ+30AhAJqxkbRxB3hv+cjbnhL0Jr/gDlW1Pa3 8ddtbW41iwEpFiPb1jx0+oHjlTDzVpIHNTtqf0yWORfu4H6k+WSv9AZqeR2UNsTTKf uGfCK4ogWZ3/dwwxrMUc9w7c7MHxvguKzP+/uAREJTW+XBhU1/+QCM2eltGB2Jdozo K0SoBH7PqVjFtL/0hvelNtNFc6Q5jmwiFTDoyGOdgVjgh5PA5baJBfsVe3IHfhE6cP UO6AHl47R4zj4OPlF1Gmw9moVK5Lfb4sN/9ukB/kRqvsD5cRmhYnBppCE5ZquTIKko xNviYDxKYic1g== X-Mailer: git-send-email 2.40.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260413 Archived-At: From: Mohsin Kaleem Modern terminals (such as kitty) support setting the style of an underline with the escape sequence exposed in the Smulx termcap. This allows for (among others) wavy underlines on terminals. These terminals also support setting the color of these underlines using a separate escape sequence that to the best of my knowledge is not exposed as a termcap but has been adopted by other terminal supporting editors like neovim. Version 2: This should've acted on all the comments on the last patch. The only thing I'm not sure about is the formatting. I've tried my best to get something consistent with what's already their or the style guide reference I found online but it's probably broken in a few places. Mohsin Kaleem (1): Add support for colored and styled underlines on tty frames etc/NEWS | 12 +++++ lisp/cus-face.el | 5 +- src/dispextern.h | 10 ++-- src/term.c | 54 +++++++++++++++++++-- src/termchar.h | 7 +++ src/xfaces.c | 121 ++++++++++++++++++++++++++++++++++++++++++----- 6 files changed, 189 insertions(+), 20 deletions(-) -- 2.40.0