unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noah Friedman <friedman@splode.com>
To: larsi@gnus.org
Cc: max.brieiev@gmail.com, eliz@gnu.org, 56459@debbugs.gnu.org
Subject: bug#56459: 29.0.50; Edebug disables Eldoc
Date: Mon, 01 Aug 2022 17:51:08 -0700 (PDT)	[thread overview]
Message-ID: <20220801175108.23591.FMU1943@gedanken-donuts.prv.splode.com> (raw)
In-Reply-To: <87sfmg1bpf.fsf@gnus.org> (22-08-01 12:48:28+0200 larsi@gnus.org)

In <87sfmg1bpf.fsf@gnus.org> 2022-08-01 12:48:28+0200, Lars Ingebrigtsen <larsi@gnus.org> writes:
>Noah Friedman <friedman@splode.com> writes:
>
>> So in the current snapshot I'm running, 9dc0fdfdc1 (2022-07-02 07:04:32),
>> it looks like the check for edebug mode was removed already
>
>Sorry, I don't follow -- the code currently is
>
>(defun eldoc-display-message-no-interference-p ()
>  "Return nil if displaying a message would cause interference."
>  (not (or executing-kbd-macro
>           (bound-and-true-p edebug-active)
>           ...
>
>So the check for edebug is still there.

My mistake; I was looking in the wrong place.

>If I remove that check, I don't see any problems -- stepping through the
>code doesn't trigger eldoc, so there's no covering up of messages.  (But
>moving the cursor after stepping triggers eldoc, but that seems fine.)

That seems right to me too, so I'd vote for removing it.

This also serves as a useful reminder to me that I ought to do a better job
describing interaction problems in the first place, because I am not likely
to remember the details 22 years later!





  reply	other threads:[~2022-08-02  0:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-09  7:23 bug#56459: 29.0.50; Edebug disables Eldoc Max Brieiev
2022-07-11 10:49 ` Lars Ingebrigtsen
2022-07-11 11:52   ` Eli Zaretskii
2022-08-01  1:59     ` Noah Friedman
2022-08-01  2:52     ` Noah Friedman
2022-08-01 10:48       ` Lars Ingebrigtsen
2022-08-02  0:51         ` Noah Friedman [this message]
2022-08-02  9:58           ` Lars Ingebrigtsen
2023-02-28  2:15         ` Dmitry Gutov
2023-02-28 13:04           ` Eli Zaretskii
2023-02-28 16:25             ` Dmitry Gutov
2023-03-01 15:42               ` Eli Zaretskii
2023-03-01 15:49                 ` Eli Zaretskii
2023-03-01 16:06                   ` Dmitry Gutov
2023-03-01 16:57                     ` Eli Zaretskii
2023-03-01 18:25                       ` João Távora
2023-03-01 18:42                         ` Eli Zaretskii
2023-03-01 19:11                           ` João Távora
2023-03-01 19:19                       ` Dmitry Gutov
2023-03-01 19:25                         ` Eli Zaretskii
2023-03-01 19:39                           ` Dmitry Gutov
2023-03-01 19:58                             ` João Távora
2023-03-01 21:36                               ` Dmitry Gutov
2023-03-02  6:08                             ` Eli Zaretskii
2023-03-04  0:43                               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801175108.23591.FMU1943@gedanken-donuts.prv.splode.com \
    --to=friedman@splode.com \
    --cc=56459@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=max.brieiev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).