From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue Date: Fri, 18 Mar 2022 22:25:24 +0100 Message-ID: <20220318212524.53sgxqnw2a67xsfe@Ergus> References: <87pmmjw9ru.fsf.ref@aol.com> <87pmmjw9ru.fsf@aol.com> <83sfrffb59.fsf@gnu.org> <20220318174252.xd33nalq4fdwpkeb@Ergus> <83r16zf6n9.fsf@gnu.org> <83pmmjf5x3.fsf@gnu.org> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54450@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 18 22:27:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVK7t-000AYx-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Mar 2022 22:27:13 +0100 Original-Received: from localhost ([::1]:49672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVK7s-0001la-7j for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Mar 2022 17:27:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVK7i-0001lQ-Hl for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2022 17:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVK7i-0005H3-9K for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2022 17:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVK7i-0003qr-3e for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2022 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2022 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54450 X-GNU-PR-Package: emacs Original-Received: via spool by 54450-submit@debbugs.gnu.org id=B54450.164763877414735 (code B ref 54450); Fri, 18 Mar 2022 21:27:02 +0000 Original-Received: (at 54450) by debbugs.gnu.org; 18 Mar 2022 21:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:58523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVK6w-0003pa-4L for submit@debbugs.gnu.org; Fri, 18 Mar 2022 17:26:14 -0400 Original-Received: from sonic314-14.consmr.mail.bf2.yahoo.com ([74.6.132.124]:34814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVK6u-0003pJ-6u for 54450@debbugs.gnu.org; Fri, 18 Mar 2022 17:26:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1647638766; bh=8Up0Wt/4e4HdMcFizCOTPcpjrnuhdY26T7z8f/HswRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=LgRbrVs+5E6n5f26kwf1PUmxL5DmIrN84z4kig6qX7jpzFKEhIG9NteXnQssfcgDuYS13BenesO7Jlig+oxZ+Ib+w8HOcvstiQAKUMOtc/7k+q1fHslya/M08RPN6wyU5Gge+oA7UsDEpOUzprrdOkR/r2rnbP6O86Ab9kloL0iHaSUeF1uMt8+XOT0egJ+03L0p1s1LtjB66aCiYtV/HR7u5EUeuyH8rj4xVB4KSx1yTpMc8qUaDDow8jyxN5qtWGZeSHxrCFK4cH/ECR8WzubRLw/NwifjTb7fIdUBEIh5NNu5eSQEncxktpKhsbJoTySXvFLFugZ5BK4Tqparkg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647638766; bh=zuJy3kodrzaA26x2aanzbbU5p5XATyTA7PJ490bDxCB=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=InyjURi+H7Av9uSFw9m/5qrlZ1tgricfjRVqXzSfaQXDcaKEQTf9ry3zz8swS55jR9KFPk5uD38edL0kulnVMK/bZ0oCF0KZRUPcBGMBAYH4nAIVhNJEJ/qfUwq8eCoj3zBqxpzuD9MRh2lQZOT7eFPhdRKaUMM/6JiAYZVGwXi/tnBGE8MO9hPlRBXemSIxDrUCVN7cPXjgGvXfOkwsQFxKWIeF28HrA0RiB1csl9/a/zmxpk8PKjNe8cp7bXSGactI8wlSYloOOFkqP+z8SsZnhmUfcySIC+FVMl11kNLijfUMmO2KNNAP8M528cKoIbzOqaYMFn9lhXiX7H+zAA== X-YMail-OSG: LVBM7twVM1nI5FUMi_dmp1PlGq9nPc6YVl8Pn2LtCLAvU2oWStTmKXYPDrPK4.V RQVjAkfL5q.K_v5uJzdBrsG_zXysRnmtQL8HfylRq6_375v2x3v1UCpeozm0jQH4pUuoGBFQpwEL Jx2PALOUXrhuLQMZG9qI_F8VyhPaiyDLyb1Vuf96ZFeaIZQTMdW1qLAqAV9rzuflrA6F8jHvIcty zxiEsEfUcsg3GRn7RvU1CGS664f6bKv1gFiL5b687xKMPsJElzanrE4Gbthto4V1z7j3WemPsY8c SyEeL5Psg1W67h.WvvqrBZsIyUnS792HFtwch2JS5P7cc1ajG2fF8JgDCEto8jBWdJ5GFSOVRRub m1AZcSqFPO1ca8aecZ5b16SFmBnucS6L4R6a8_e3lh7vkMNeg.2xkMHNIdYHh.7KHVSAXTLHi4fn XBaERcs97RmwtyMzQFlAyVljnPBMLjhcJAd6LfWtNeKrVVzgHA3kAJbW6rwjAyeptq.IgK9nPTkM AYscBCdu1osji81dhoVMEyaqLkAejeDRBsfSOXIuONtH_QMw_scWoQ22BfBb5rw.sKvrIZJ3rTO4 vTFzEOX8rwGvubsKFnO_7fMQiB63hTz_XUnd3KFpvbSkYou_.U25n7w_g7bWqQIL9sjaPtCmb0W_ 6EGwCHnNk5AKintJWfieXVY8ruG4tXnQ22S3MNOtmGNn1eAoyxyC3I2sDYoB8Cd57hVapsn8BfSi Yx9GnH2uc5vSi62_jd1lelnwpN8jw6oQeFUVGQmD7ZOWp9hKQMyj80DG09FgLuR3sbvDm.Dl.St_ LCwjiRB1weIIb76qzNbtmg3riUXGnLBtlOMd.SgL8w X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Fri, 18 Mar 2022 21:26:06 +0000 Original-Received: by kubenode514.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 191ba8307da387d3c43d34f17ee134d0; Fri, 18 Mar 2022 21:26:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83pmmjf5x3.fsf@gnu.org> X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228571 Archived-At: On Fri, Mar 18, 2022 at 08:54:00PM +0200, Eli Zaretskii wrote: >> Date: Fri, 18 Mar 2022 20:38:18 +0200 >> From: Eli Zaretskii >> Cc: 54450@debbugs.gnu.org >> >> > Yes, this could solve the issue for the region, but not in general for >> > redisplay--update-cursor-face-highlight which was the initial problem >> > with Juri's code. Same for any other function that goes into the >> > pre-redisplay-functions hook. >> >> I asked for a test case, and this is what you gave me. >> >> If there's another test case, please show it. > >But before you do, please try the alternative patch below: > >diff --git a/src/xdisp.c b/src/xdisp.c >index 5cb5839..6d8d4aa 100644 >--- a/src/xdisp.c >+++ b/src/xdisp.c >@@ -13211,7 +13211,8 @@ prepare_menu_bars (void) > struct window *w = XWINDOW (this); > if (w->redisplay > || XFRAME (w->frame)->redisplay >- || XBUFFER (w->contents)->text->redisplay) >+ || XBUFFER (w->contents)->text->redisplay >+ || w->last_point != marker_position (w->pointm)) > { > windows = Fcons (this, windows); > } Yes, now this seems to solve the issue for the two use cases described. Thanks, Ergus