From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ross Vandegrift Newsgroups: gmane.emacs.bugs Subject: bug#53298: 29.0.50; GTK3 frame stops updating Date: Sun, 16 Jan 2022 12:44:10 -0800 Message-ID: <20220116204410.e2vjlz3g4clrxg7q@stgulik> References: <87h7a4w57u.fsf@kallisti.us> <08309eaf-2abb-080e-9c55-573b330e7765@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53298@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 16 23:12:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9Dky-0004uA-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 23:12:12 +0100 Original-Received: from localhost ([::1]:34608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9Dkx-0002yf-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 17:12:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Dkp-0002yV-5K for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 17:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9Dko-00053t-J3 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 17:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9Dko-0002HB-95 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 17:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ross Vandegrift Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 22:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53298 X-GNU-PR-Package: emacs Original-Received: via spool by 53298-submit@debbugs.gnu.org id=B53298.16423710818700 (code B ref 53298); Sun, 16 Jan 2022 22:12:02 +0000 Original-Received: (at 53298) by debbugs.gnu.org; 16 Jan 2022 22:11:21 +0000 Original-Received: from localhost ([127.0.0.1]:44373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Dk9-0002GF-1K for submit@debbugs.gnu.org; Sun, 16 Jan 2022 17:11:21 -0500 Original-Received: from ravenhurst.kallisti.us ([69.164.210.145]:45230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9CNt-0006Kx-FL for 53298@debbugs.gnu.org; Sun, 16 Jan 2022 15:44:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kallisti.us ; s=20220106; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eqpyulx41GrMqeuK5gFwtD1uCAlc+8XDuRBdhOL6yUA=; b=FP93dvuqVnGDV0wy4jBAYVeCAC 9KcI5nLt05Z8b5j8u41UgVdgwLSWdIvCRdFXl7XhHnra6HQ3RUZmKk9b3F824DQnbURlAhxOCkl0A ko+lDAyG5BbFU27OITddMws6ZC6oA/BTfJkMAy5P4ES3NAtffkwUpLBZiUwvK/kkWjynou3nhvLHX uqdjWh2VAwRgE4YcyE4ocJnZcpoyx1u3iGtV3SEUaaFfJwk+mHuEbNmwvJTZ8qOO5PcduuQCYdNlS rFXqRa+LD1+RedX2YATLlHNUDLeqO6QMMblkdnNw7JNheT/MMxV/ahiZho0U/AsFkySmeM69R9Vdd xjbiLFhg==; Original-Received: from [50.46.16.53] (helo=stgulik) by ravenhurst.kallisti.us with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9CNr-00GREI-1r; Sun, 16 Jan 2022 15:44:15 -0500 Content-Disposition: inline In-Reply-To: <08309eaf-2abb-080e-9c55-573b330e7765@gmx.at> X-Mailman-Approved-At: Sun, 16 Jan 2022 17:11:20 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224419 Archived-At: On Sun, Jan 16, 2022 at 12:06:12PM +0100, martin rudalics wrote: > Thanks for the report. I suppose this is the problem described in > Bug#49955 28.0.50; Emacs got quasi freeze. For some reasons, Masaru > Nomiya reported that bug as fixed but we never got a conclusive answer. > > Also the problem he reported here > > https://www.mail-archive.com/enlightenment-users@lists.sourceforge.net/msg26981.html > > apparently had no conclusive outcome either. > > Can you try commenting in the two lines > > /** SET_FRAME_VISIBLE (f, 1); **/ > /** SET_FRAME_ICONIFIED (f, false); **/ > > in xterm.c and tell whether that solves the problem. If so, we could > add an option to set these in accordance with the window manager used. No, that didn't help. Reverting 483c5e953c as suggested in #49955 does though. I mucked with the revert a bit, the issue is skipping the the FocusIn handling on GTK. The minimal working revert is below. Not sure if this is safe for the other issue through. Ross diff --git a/src/xterm.c b/src/xterm.c index 5798ea3eeb..752b6562bb 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -9574,16 +9574,10 @@ handle_one_xevent (struct x_display_info *dpyinfo, goto OTHER; case FocusIn: -#ifndef USE_GTK /* Some WMs (e.g. Mutter in Gnome Shell), don't unmap minimized/iconified windows; thus, for those WMs we won't get a MapNotify when unminimizing/deconifying. Check here if we - are deiconizing a window (Bug42655). - - But don't do that on GTK since it may cause a plain invisible - frame get reported as iconified, compare - https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00133.html. - That is fixed above but bites us here again. */ + are deconizing a window (Bug42655). */ f = any; if (f && FRAME_ICONIFIED_P (f)) { @@ -9593,7 +9587,6 @@ handle_one_xevent (struct x_display_info *dpyinfo, inev.ie.kind = DEICONIFY_EVENT; XSETFRAME (inev.ie.frame_or_window, f); } -#endif /* USE_GTK */ x_detect_focus_change (dpyinfo, any, event, &inev.ie); goto OTHER;