From: Vincent Lefevre <vincent@vinc17.net>
To: Alan Mackenzie <acm@muc.de>
Cc: 50640@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: bug#50640: 28.0.50; incorrect highlighting in C++ mode
Date: Sat, 25 Sep 2021 23:51:17 +0200 [thread overview]
Message-ID: <20210925215117.GU7497@zira.vinc17.org> (raw)
In-Reply-To: <YU+R0ju3SDUm42/6@ACM>
On 2021-09-25 21:17:06 +0000, Alan Mackenzie wrote:
> Hello, Vincent and Stefan.
>
> On Sat, Sep 25, 2021 at 11:17:07 -0700, Stefan Kangas wrote:
> > Vincent Lefevre <vincent@vinc17.net> writes:
>
> > > Consider a test.cc file containing:
>
> > > if (xMin - xt < t3Font->glyphX ||
> > > yMin - yt < t3Font->glyphY ||
> > > xMax - xt > t3Font->glyphX + t3Font->glyphW ||
> > > yMax - yt > t3Font->glyphY + t3Font->glyphH) {
> > > }
>
> > > (this comes from the xpdf source) and open it with "emacs -Q".
>
> > > The first two "xt" and "yt" are highlighted in green instead of
> > > remaining in black.
>
> Yes. C++ Mode is recognising the < .. < .. > .. > as two nested
> templates. The green is font-lock-type-face. :-(
>
> > > If I remove the last condition as follows and reopen the file:
>
> > > if (xMin - xt < t3Font->glyphX ||
> > > yMin - yt < t3Font->glyphY ||
> > > xMax - xt > t3Font->glyphX + t3Font->glyphW) {
> > > }
>
> > > then only the "yt" is highlighted incorrectly.
>
> Yes, then only yt opens a "template", there being no closing > to balance
> the xt <.
>
> There's really not much which can be done about this in CC Mode, sorry.
> CC Mode's analysis of ambiguous C++ constructs is not very deep, so it
> sometimes gets it wrong, as here.
Note that when < .. < .. > .. > comparisons occur, there is
probably || or && between them. Are C++ nested templates common
with || or && inside them? If not, || and && should be forbidden
in nested template matching.
Alternatively, whitespace characters could also give a hint:
AFAIK, for templates, this is usually no whitespace after '<'
and no whitespace before '>'.
--
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
next prev parent reply other threads:[~2021-09-25 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 12:57 bug#50640: 28.0.50; incorrect highlighting in C++ mode Vincent Lefevre
2021-09-25 18:17 ` Stefan Kangas
2021-09-25 21:17 ` Alan Mackenzie
2021-09-25 21:51 ` Vincent Lefevre [this message]
2022-08-26 11:42 ` Lars Ingebrigtsen
2022-08-26 12:24 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925215117.GU7497@zira.vinc17.org \
--to=vincent@vinc17.net \
--cc=50640@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).