From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rolf Unger Newsgroups: gmane.emacs.bugs Subject: bug#7221: timestamp in cvs-quickdir on Win32 system Date: Fri, 27 Aug 2021 01:06:56 +0200 Message-ID: <20210826230656.x2gtayojelzb3z5d@yellow-pi> References: <87imddv2aa.fsf@gnus.org> <83h7rcgbt3.fsf@gnu.org> <877dg8w043.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28966"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20170113 (1.7.2) Cc: Stefan Kangas , 7221@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 01:08:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJOTi-0007Ch-Da for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 01:08:10 +0200 Original-Received: from localhost ([::1]:46022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJOTg-0003Pl-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 19:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJOTa-0003PM-4F for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 19:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJOTZ-0006pC-T9 for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 19:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJOTZ-0003eZ-OW for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 19:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rolf Unger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 7221-submit@debbugs.gnu.org id=B7221.163001922613982 (code B ref 7221); Thu, 26 Aug 2021 23:08:01 +0000 Original-Received: (at 7221) by debbugs.gnu.org; 26 Aug 2021 23:07:06 +0000 Original-Received: from localhost ([127.0.0.1]:50748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJOSg-0003dS-C4 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 19:07:06 -0400 Original-Received: from mout.web.de ([212.227.15.3]:39849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJOSe-0003cx-7z for 7221@debbugs.gnu.org; Thu, 26 Aug 2021 19:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1630019217; bh=zm4lVPeeShlwS5LlffdpcC4V4pHpM18R1aPzVUYI5Cs=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=Bcc4wnimu7S37SWAwFpWN9JovDplz5yUlyKrWS+5Y12OaibJH7YZndvUB6zDpIVDu h/PX9AZJXgfqkZ4OLvjeX1UCtNX6U7TbpG0Rh/c/jpBFNE04v5nh+YlFzP045IGvLR VyaMhA4q2125Axq1swL5dd0461Wvt3JDE0iw6/94= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from yellow-pi ([46.223.163.162]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MMFB7-1mMwIO360T-007z5E; Fri, 27 Aug 2021 01:06:57 +0200 Original-Received: from rolf by yellow-pi with local (Exim 4.89 #2 (Debian)) id 1mJOSW-0001eA-Pj; Thu, 26 Aug 2021 23:06:56 +0000 Content-Disposition: inline In-Reply-To: <877dg8w043.fsf@gnus.org> X-Provags-ID: V03:K1:QRzdJOzVhne5Ypqa3FqtQ3Uu7hz9Zyk1bcFGUBKcH+CVQNLfwYK allmT199CRxjUSBRkneEvUt5Y27KhC4HfWm/r6hEdBCKp6i4t6DAQidWIbpDlOzI5uUyBnJ LOTHm8uNdSH6efnzA99onnzxXV1xYoCJ859bRfuADZKGkCL8lXtDc6WN8W8O0exSHoA8CUp 4hrnYHqJ9ldnZKm3L+fUQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:BsoLijAdG34=:Plvoj+MQL9MV0opVfga+07 T75HjvDttZNORjut3YzuQ9cWxfc7Hfgct9ybT1ECfUGLHgyG5zXSOL3tLnCb7OhMlbsuL6AK0 inE44OorKw7aFjCXVYXth+VE7w1p43TKS4+ZJMzLJ/i9MoQJCw1aU5QukLPjSmnccfr9vIGUX muw+UACMwdkePM3FQH2zGNKPMgZ2sNcsNWzfhIbOqx/r2s0pAtW7UcyphxVSTJtEoaRK2CrY+ uQ+JYhbP/gU5Dyu7Y8LL11eLZI94cL4GorlfxWW2PDOGQ6iutwyG3BMyeJtFNvB5gmPyqMTIW tCQgrazy9M/ZFxzY9ETgYRnyEl7LIQ6ck0MpHzYkbfTk8jjg9SWUTnz3AGsVZzK0HPlZJ9GGl pMQ0OkVJm9eoEvVLwL9Gza8kSp/jiqlbLLgJC/5QWxljOmijfvuOILOfvSDAQCAfvzGrvkvrn SFFt31+kGe0bPbCaqDSbm32Xg5cCpfdAf2D9xTclnDFEANJfrTDB4YNDlMWTAF1hx/esSViRd mKl9mFm0eCYkfKDY/zVbDGG/bqpLFv9oi/tEz5kGf/EDYii4jno8Y+iPYIJldCz4zn3SisdrT ZXKehAMZ67TWbGjcZB4Gkv7n3ikerb8ROavu4lEdS0hzCYXCwuIxKl6v7mXNe3/nMnOCj0hps cUyXfAU4iByFjgJEERDN2EgZ0zTfnFRg1xCIr/CD8ZpDx4SETAYnLRaKgEdBLbHfXYJHwLTrB IF/na9uRgdeFugeQYI31ojoEFFIGtWW5luPwBc34LO7BNPDHynSBmrilXeeRCWOgZj0Yvi7P X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212770 Archived-At: Hi Lars, I gave it a go with your suggested patch, and it still marks some files as modified that are not modified. Maybe I should give some details to my constellation: My working directory is on a win32 machine, but the repository is on a Linux box and I use the pserver protocol to access the repository. My Project resides all in one directory, it consists of two .c files, a header file and some Windows resource script files .rc. Furthermore I have a Makefile for MinGW gnu make and one .mak file for nmake. The Makefile, the .mak and the .rc resource files are marked as modified if I open the project directory with `csv-quickdir`. The .c files and the header file are not shown (the rule for files that are up-to-date) If I use cvs-status on this same directory all files are shown as up-to-date (which is the same what I get if I run `cvs status` in a shell. The interesting part is: If I open a file (the Makefile for example) with `o` in the other window the *cvs* buffer will immediately show the file that have just opened as `modidied`. But I haven't done any changes in that opened file, only the active cursor is in that buffer. If I hit `g` to refresh the *cvs* buffer with (cvs -f -n update -d -P) the opened file that is said to be modified will transition to Up-To-Date again. I thought it could be related with the character encoding because the .rc files are UTF-8 encded and theser .rc files are shown as modified. But if it is a encoding issue it should not happen for the Makefile, because this file as ASCII clean file. If I execute `vc-dir` on my project only some unregistered files are shown, because vc doesn't show files that are not modified. So `vc` does show the status of the files correctly. All this strange behaviour let's me guess, that the problem is not within the elisp code and maybe wrong assumptions on the date format of cvs' timestamp of the revision. Rolf On Thu, 26 Aug 2021 after 20 h, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > > > I don't think I agree. My reading of the relevant CVS code is that > > CVS uses either 'asctime' or 'ctime' to produce the time string for > > "Entries", and 'asctime'/'ctime' always produce the standard format of > > the time, not the locale-preferred format produced by %c. See > > vers_ts.c:time_stamp in the CVS sources. > > > > FWIW, I see the same problem on my MS-Windows machine. > > Does the proposed patch fix the issue, then? It removes the "%c" and > uses a more standard date format: > > diff --git a/lisp/vc/pcvs-info.el b/lisp/vc/pcvs-info.el > index 9f8a168a0a..5a607e337b 100644 > --- a/lisp/vc/pcvs-info.el > +++ b/lisp/vc/pcvs-info.el > @@ -454,7 +454,8 @@ cvs-fileinfo-from-entries > ((let ((mtime (file-attribute-modification-time > (file-attributes (concat dir f)))) > (system-time-locale "C")) > - (setq timestamp (format-time-string "%c" mtime t)) > + (setq timestamp (format-time-string "%a %b %e %H:%M:%S %Y" > + mtime t)) > ;; Solaris sometimes uses "Wed Sep 05", not "Wed Sep 5". > ;; See "grep '[^a-z_]ctime' cvs/src/*.c" for reference. > (if (=3D (aref timestamp 8) ?0) > > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no