From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitrii Kuragin Newsgroups: gmane.emacs.bugs Subject: bug#48246: [PATCH] Prevent unnecessary restarings of ispell program. Date: Wed, 5 May 2021 13:29:45 -0700 Message-ID: <20210505202945.32400-1-dmitriy.kuragin@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1240"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitrii Kuragin To: 48246@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 23:54:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lePTQ-0000Cp-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 23:54:28 +0200 Original-Received: from localhost ([::1]:46060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lePTP-00071I-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 17:54:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lePT0-0006zJ-DJ for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lePSz-0003YH-WA for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lePSz-000528-Tx for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitrii Kuragin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 21:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48246 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162025160719327 (code B ref -1); Wed, 05 May 2021 21:54:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 May 2021 21:53:27 +0000 Original-Received: from localhost ([127.0.0.1]:34719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lePSQ-00051e-ME for submit@debbugs.gnu.org; Wed, 05 May 2021 17:53:27 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leOA0-0004ED-6a for submit@debbugs.gnu.org; Wed, 05 May 2021 16:30:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leO9z-000644-W7 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 16:30:20 -0400 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:41709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leO9y-00050C-Cd for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 16:30:19 -0400 Original-Received: by mail-pf1-x433.google.com with SMTP id v191so2843012pfc.8 for ; Wed, 05 May 2021 13:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xgfMwKHErg6jAnqvq7NRG+RvP57aUE2D5WXJU7jk6L0=; b=NenGx6UBX9GmXsGDxyCBKK87nPktJw32wLItsTiwsKBpFSs6tsijC8tf3Rt/Bn06bv 5HW3s6S0M86p59rtC7qC25k8LApaN8Xplbd10YKNscLsXsmwit+KhDsEkXoeRUO8lqc3 W/VcMt+AE4dV39g+L+VR+9UlUJh52qgOWGQnHfxIghQXJUWuTT06C5hhhtiZxw9b4qlW zHexMTZGnqAVvM9GuqKAf4+vFmHz25jUdb3XI5Zje12cHgLvvdAZCBX51ZWb0dsLLJs8 MWQ9GP1P/VBEUGQAzAhTSMhZd+D0FPX83Kz+6d+aor95HgMNuYYOP/EKPlzUOaxv15uW AY5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xgfMwKHErg6jAnqvq7NRG+RvP57aUE2D5WXJU7jk6L0=; b=EdyI3i2t//XiSbpJa/VRLZVy0FgqLo8D+Y1jMdBJQUJStBfqs5iaTnK4sPYVFTbASA UCGcO3PhFzUi7kNJmO2Tcg/FYC9A1HmNv1fSLe4+esABonh5xtiUAOtRs6Dl9Ds0v46y bCFzwf6H7VVclJXvW9iHCOHP6IHmeCp0CD5QSTpoOqURX8IHXsFJ3nRzrhcu8M1wX1Kn ICK8tM9fQ/NvnObM9YBnpbi6MDUQZ1JEG1gj7DqunAzHap6TpZiG98Iq51/NG9dY4b/D ZJzHC4lJXvNXaWmTz4/LZo75LpLWjWZmc8FSR11NlB73nD196kOYQkQtsf3YyPmjZ6ZZ dz/g== X-Gm-Message-State: AOAM530wgF24wHxMwzy8+hUxsqpoInAmjoPw44frmdU0yy1g5KnXsI8v bR3NYJQEkEDLtemKohYMggMMlBAias84dl04 X-Google-Smtp-Source: ABdhPJzFBi13kYg7RyjvKHqeS/nFRo6Rm+XS9zCQD1FOmttpLIt+5IlY1B9tbnmCpKzUHlGMFxYVlQ== X-Received: by 2002:a63:4d24:: with SMTP id a36mr721500pgb.64.1620246615809; Wed, 05 May 2021 13:30:15 -0700 (PDT) Original-Received: from localhost.localdomain ([2601:647:4680:e330:2c6e:5a86:3f38:6935]) by smtp.googlemail.com with ESMTPSA id x26sm99708pfm.134.2021.05.05.13.30.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 May 2021 13:30:15 -0700 (PDT) X-Mailer: git-send-email 2.31.1.527.g47e6f16901-goog Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=dmitriy.kuragin@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 05 May 2021 17:53:25 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205742 Archived-At: From: Dmitrii Kuragin Fix bug when ispell always restarted when `ispell-program-name` has a custom value. Function `eq` compares the object identity and not the object values which causes `eq` always return `nil` for values with the same value but different identity (address). `equal` compares actual values. --- lisp/textmodes/ispell.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 932308ee59..4dbc7640bc 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -1245,7 +1245,7 @@ ispell-initialize-spellchecker-hook (defun ispell-set-spellchecker-params () "Initialize some spellchecker parameters when changed or first used." - (unless (eq ispell-last-program-name ispell-program-name) + (unless (equal ispell-last-program-name ispell-program-name) (ispell-kill-ispell t) (if (and (condition-case () (progn -- 2.31.1.527.g47e6f16901-goog