From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Wed, 5 May 2021 13:08:53 -0400 Message-ID: <20210505170853.locsnpxoth7fukeq@E15-2016.optimum.net> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <87zgxan7lx.fsf@tcd.ie> <878s4t8up2.fsf@gnus.org> <8735v1jrit.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5344"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: Lars Ingebrigtsen , 48179@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 19:19:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leLAy-0001EH-Qf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 19:19:08 +0200 Original-Received: from localhost ([::1]:47284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leLAx-0006ct-Hg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 13:19:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leL2J-0006eo-Sl for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 13:10:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leL2A-0006NQ-F7 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 13:10:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leL2A-0006z0-8A for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162023455126808 (code B ref 48179); Wed, 05 May 2021 17:10:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 5 May 2021 17:09:11 +0000 Original-Received: from localhost ([127.0.0.1]:33398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leL1I-0006yI-4g for submit@debbugs.gnu.org; Wed, 05 May 2021 13:09:11 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:39567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leL1D-0006xs-J6 for 48179@debbugs.gnu.org; Wed, 05 May 2021 13:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620234536; bh=VIgywxsBE2Zuddg65DN4pPJgJDZw+Tq1pbtaAY4RHyU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=KQf/KMlmXp3BsfHj232hu7g5w+jqmQAW6GAfnf1uVmbzHv2Xjhi6Cl88BicxwB460 mxrb6k8yzZ5ntoNZbP2LNkEizI7g7zD/NpKQjF7Ju7X1VwLK7hJNwdKnVeQz1i0wki SuW0RU5u4RrxFYdk4eM3HP8Buc6Udo/I7Y4gpOhQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MAwXh-1lpebp0WZl-00BIRX; Wed, 05 May 2021 19:08:56 +0200 Content-Disposition: inline In-Reply-To: <8735v1jrit.fsf@tcd.ie> X-Provags-ID: V03:K1:doX8MsjtgEpHiQJRnX5eszQqZuDm5ca6bOjVJM1e39uqL159t84 xFXMPeIJZD4VHQp1J+cpadRfcdnSeBg2Z6m3VdHTwdu2BNMFzdou27os7sXB+SRMJTZlM8N /WMoz2KMulBO3129XDbCvZskd+kbd8+2DDbCXqA/qTGrRIGVGAu3VMMvHZWVgy9lY//2jEi huXmDcZFSHG/7i5b7VFQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:yzhEEW3xRoY=:h7clNezzHBnCq88Ne+jNnU dE32h5Z+iWN9Q0zRtLk+/AZ6fj4bDbHRUh7MHxNVTpY72Hsxmh7VKPtLx78qvpzEtlenH7r99 dJsOuFCQdvsG6zwJsOhmMRBVYy8U4HX/GjvZxYIh7xqc6QD2mADFi3thncI1NMw9rXT+EkQG/ wXePRozGyjaDLsvBQ1L0D/Ns0BnyvyMp8MwUa9VKlmweaeVuhFKiVPIoquTL3Y4+Jkwuu25g6 75TP7Z0a2r785/Vh6/qcGsab7Btg0CFBrJeDNXOR7XpRWEAjxSR/NDEmai8M2UiJZvqKbrkiF miZSg9c+CZjybX34IlxXjIeDfjrj3DEWh0BneHMRR4kaIcarhNmuLFlduNlQTtfYfZbYLTH3p uWf7+IasOdkk/oWSpZnuvlIABcFS9ALSXWEH1SXtT4x7u55wUD3m/cEvYhSEJE9TS5E7ooAmA wUwsS4x+jD2sX55MK/nZYNtiPjZj43XDRg2JuTUQbTEFbfLkkLTi3Oci/cVj1FTEuG2BIWPdr 9PB4N0msr0LHwfmWgW8jYDAy+4R0TnvzDyR+nGuIpX2QYM9ouYqEI3Rq2ne0/MyrG+zG+cv2t qSvHmRB4aa9MbzvQbGOF+ZAB0Gfvwm6ge2lEQF+i0MxONG4V0wXIdB6y6x+Y4iQ20/ARO+RVx lN7eGyBM+6GM9nbXskVT9j7tsAtvupMYZ/UztVo7IZMIczLzAEkXyfIz2vNba56fhQQxHfYpO NoASwrwXu4iKWf19x1kUH+7//Qo1C1A92Hj1++G7KpiTjUsx0qIl5kdWcptdfcQZyWG+u9RQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205730 Archived-At: On 2021-05-05 13:26, Basil L. Contovounesios wrote: > Lars Ingebrigtsen writes: >... Important follow-up: 5) Throughout my prior patches, I had been using variable 'buffer-file-name' to compare against the value for the 'filename' key in bookmarks' alists. That is wrong, in the sense that it's only correct for buffers visiting files. The correct comparator seems to be the output of function (bookmark-buffer-file-name), see there, which will cover all cases of all buffers. With that change, it's probably wrong to perform 'expand-file-name' when performing any comparison. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0