From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48218: [PATCH] ibuffer.el: Use display-buffer properly Date: Tue, 4 May 2021 10:54:43 +0200 Message-ID: <20210504085442.1491551-1-miha@kamnitnik.top> Reply-To: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= To: 48218@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 10:52:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldqnB-0002UK-69 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 10:52:33 +0200 Original-Received: from localhost ([::1]:51598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldqnA-0006bp-8T for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 04:52:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldqmg-0006Zu-Ms for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 04:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldqmg-0004bf-Ct for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 04:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldqmg-0004Wi-9W for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 04:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162011827617384 (code B ref -1); Tue, 04 May 2021 08:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 May 2021 08:51:16 +0000 Original-Received: from localhost ([127.0.0.1]:51789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldqlw-0004WK-9K for submit@debbugs.gnu.org; Tue, 04 May 2021 04:51:16 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:48888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldqlu-0004WE-ES for submit@debbugs.gnu.org; Tue, 04 May 2021 04:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldqlu-0004lD-5X for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 04:51:14 -0400 Original-Received: from kamnitnik.top ([209.250.245.214]:33302 helo=mail.kamnitnik.top) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldqls-00040e-1M for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 04:51:13 -0400 Original-Received: from localhost (unknown [IPv6:2a00:ee2:e04:9300:b7eb:7ae7:cc56:e0da]) by mail.kamnitnik.top (Postfix) with ESMTPSA id 93C96BBB7D; Tue, 4 May 2021 08:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1620118265; bh=aWbNlm3xSxE1hF+fPvP5M8wjVTR4F1SkeR+8O0sLHP4=; h=From:To:Cc:Subject:Date:From; b=aES+m9t3H9IO1Gn7ex4pV5r4GfrW26SBPfYniGL7csLqoN7V81dwoNix0wVFEKims rg3/O57ZgzbmXHA5pb7qFKlUTU5URQS2Pc2fk74kMUnX9GX6XguGEc4sW5KgJG4uam Cm3qkf7iKTI4CvfziSCiHVl4NZan9gXXDZtXvaMHcurjwGMcqppwaBKovQdnT9A61E r6yEWILnu3qj2RpOss41BYql7FIY5qhvcH7p19aGl2ysZKCXlaOTckGROfKQy+Z8z1 ZIMZvMfMQmj1t9FDP3NV60MDd5pw9V6yz7KAt4M/BEVN23uxk0UF8DGpAcgVbBR9A7 McFXKMmGoAn7Q== X-Mailer: git-send-email 2.31.1 Received-SPF: pass client-ip=209.250.245.214; envelope-from=miha@kamnitnik.top; helo=mail.kamnitnik.top X-Spam_score_int: 38 X-Spam_score: 3.8 X-Spam_bar: +++ X-Spam_report: (3.8 / 5.0 requ) BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=1.999, PDS_OTHER_BAD_TLD=1.999, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205580 Archived-At: Minor simplification for C-o command in ibuffer. C-o can pop up a new frame under some display-buffer configurations. In this case, `pop-to-buffer' focuses the new frame, but `select-window' usually fails to focus the original frame. This simple patch fixes that (if your window manager doesn't automatically focus newly created frames). --- * lisp/ibuffer.el (ibuffer-visit-buffer-other-window-noselect): Use display-buffer instead of pop-to-buffer and selecting the old window. --- lisp/ibuffer.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index b484dd717c..c80222ed0f 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -988,9 +988,7 @@ ibuffer-visit-buffer-other-window (let ((buf (ibuffer-current-buffer t))) (bury-buffer (current-buffer)) (if noselect - (let ((curwin (selected-window))) - (pop-to-buffer buf) - (select-window curwin)) + (display-buffer buf) (switch-to-buffer-other-window buf)))) (defun ibuffer-visit-buffer-other-window-noselect () -- 2.31.1