From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Mon, 3 May 2021 05:12:04 -0400 Message-ID: <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37469"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 48179@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 11:19:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldUjc-0009dg-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 11:19:24 +0200 Original-Received: from localhost ([::1]:54470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldUjb-0003A2-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 05:19:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUdS-00060P-VJ for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 05:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldUdS-0004iT-JC for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 05:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldUdS-0001Zk-DE for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 05:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.16200331356045 (code B ref 48179); Mon, 03 May 2021 09:13:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 3 May 2021 09:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:46220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUch-0001ZR-13 for submit@debbugs.gnu.org; Mon, 03 May 2021 05:12:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:38561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUcf-0001ZJ-8F for 48179@debbugs.gnu.org; Mon, 03 May 2021 05:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620033127; bh=2Aj4MIPI3fR2iIrI3+eGp8Gx0nHVdeo74iSWZlsVuAU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=hfYexYBs3ms4Ub9ph2o3EgTK/f4Wdr5EIOASquUZKzyPjb5LDFe56wdsuNSY5WbOi xmiRQZRUiSLWJaRXEz8XAd9kM3bpUDLv31MYXmP6HsBmCpvyjauMMGU20iA9TNU948 UZ4VsnyLQW842Ou/kGAcnsT8DpSjhcipVe+8H1gs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mg6Zq-1l4fyS34hy-00hgk3; Mon, 03 May 2021 11:12:07 +0200 Content-Disposition: inline In-Reply-To: <87zgxcdzh3.fsf@gnus.org> X-Provags-ID: V03:K1:4C6CCUpvGDUGqyJ2wWXWlWabZxWLjCxwoyV8bpU5IiTSnO+Fm+1 Ixi9dXgx13+oekic/oKgZI6s5NpJxiy1gN2e/wQses38MO0CxiTzNr3v62gUSiBg7FJqhHe zjpZ0AyJ4zuW44SmSjVo38BaLFoxNRjISolizFWcWbirrnRzef35gNoG7dwjrlo+3AHtexS EoV+Vc++0znQxn1t8zK7w== X-UI-Out-Filterresults: notjunk:1;V03:K0:aOzCwhqXfq8=:ns0zMia4X6HkEhPb5b63i8 OfpkhaJ+vOJV572DrQXv0etHmyx5tQ45utyhSgvPpdLd6/JxoiAW0Wl/DPVXZ4jZrW2bcZiOu y3xd1AznzmiCwtlZyxkOlglGXpYhqrQ4kUO+9Vu6XbNIE27di4FaOCFlrkItht50vnIaMbDdH 8SyxTiGi0U6KmBTuqnbb96b9fkJY3g9tlURS7CCfjaVgwbNtsMIPZF1aIBcosP1smeKVRvJb0 uPXODUVjWNUI/aeIq+Y6Q9alWex9Emy5aL07st1Mw2PWoVFJKDneblF623foAjZ3MVRx0g9xZ +Vce+pxmEVHM8AHp7I8eP+y6iaACJ97s97azMQA0QOTtVsutDB95mOtlN2sDDpeU2aM8Pelm3 efELkKJ4RaDXsraakBF+TtKIw1ePyPIQHNOtPYRoTbrrzTVI9V4EwMUNi8lHpA7Ehk5dia+RF duJDt14QHSBq5NCbXxQUKxx1HGAiYF4J43cA0yTbB7YhVBbA1nqO99APKWX/Y5WyM9tjtBAMz e/les93N81PAqxuZrr/uH0sXjLBVVZYMVxVD8PTnsTWuMVB8LY5qTWg4NYabaybbYHJ7Kvqzf iyXCPZ3lsFuH1m88pXj0zNxgJV4fUeUvobMkwgMKhBTQPe2rT7HKY7tLPY7v1xXwgrC3Zmf6M F9aQmK/Dn7WNpQJXvJ7sQ8RNOho5pxbBP8KX9IsyicDCTgb8Zlk0Tmy87b5M3TPvrFVQZmblO ks6tQGxIfCmoK/7dzRk9gPjLhfhh5KLcLZKeKk3eivMdPW0lYZrXC8mxNN2xW5n9gta27//E X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205489 Archived-At: On 2021-05-03 09:54, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > The attached patch adds a feature to bookmark.el to colorize a > > bookmark's line, making it easily observable. The idea was adopted fro= m > > package bm.el, available on MELPA. I was able to test this on Emacs 27= , > > but there seem to have been some changes in snapshot to make it > > difficult to use that version of bookmark.el on my Emacs 27, so please > > verify that I performed the migration properly. > > The patch is against Emacs 27, I guess? (Because it didn't apply > cleanly on Emacs 28.) We're not accepting new features for Emacs 27, > though, so can you respin it for Emacs 28? I thought I did base the patch on yesterday's gnu.org cgit version... Here's what the on-line log is showing me... Age Commit message (Expand) Author = Files Lines 2020-09-07 Use format-prompt in read-file-name calls that Lars Ingebri= gtsen 1 -3/+3 have a default 2020-09-06 Use `format-prompt' when prompting with default Lars Ingebri= gtsen 1 -1/+1 values > Also -- it's slightly obscure what it's doing, but testing seems to > indicate that it just puts a face over the current line when you're > doing a `C-x r m' command? Just. Yes, that is the entire point: "colorize a bookmark's line". > That's nice, but I think it would also make sense to restore these > faces when jumping to a buffer from the bookmark buffer -- otherwise > it's just a bit confusing. Yes. If someone deletes the buffer after creating the bookmark, the overlay will be lost. What you're asking for is a simple two or three lines to add to the jump function, but there's no sense if you can't even apply the current patch. If you can figure out what the problem is with that, I can add the trivial code for the jump. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0