From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 11:16:33 -0400 Message-ID: <20210428151633.smexarr74kosy63y@E15-2016.optimum.net> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> <83k0ongnc7.fsf@gnu.org> <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> <87fszbnd70.fsf@gmail.com> <20210428095054.wkpyxl2axhdx26dq@E15-2016.optimum.net> <838s52hb7h.fsf@gnu.org> <20210428124952.anyz3ddhgvlcxyj3@E15-2016.optimum.net> <83mttiftnl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26608"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 48072@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 17:17:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lblwA-0006nK-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 17:17:14 +0200 Original-Received: from localhost ([::1]:44628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lblwA-0005DE-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 11:17:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lblvy-0005Cv-1u for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 11:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lblvx-0001VC-QB for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 11:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lblvx-0000Rc-Mg for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.16196230051683 (code B ref 48072); Wed, 28 Apr 2021 15:17:01 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:53794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lblvg-0000R5-VV for submit@debbugs.gnu.org; Wed, 28 Apr 2021 11:16:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lblve-0000Qr-Jc for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 11:16:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619622996; bh=0RWtB7ZQwbY36uPx9ZffsMFosozRT8oPfylMumkImHM=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=iZypgguV2Y0UVuiCLJbDMTCHHlpybv65El27728D/oRHmAF4lw2IOLh6o9zizKaoT XBIYlnlVjMU3RWAQG1Rz+Odgk+u+ABiyJ/HIIM0IV7cSBeCXWcTB1eGvxVwm37FUjT Qc9M9+Xrs7HziJMSCyS+m87aXiW2H9HeRETS0LwE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MfHEJ-1l5AGO3cjr-00grmE; Wed, 28 Apr 2021 17:16:36 +0200 Content-Disposition: inline In-Reply-To: <83mttiftnl.fsf@gnu.org> X-Provags-ID: V03:K1:IgyN1GboGx+G+HfWaSGQLcPiFC3BPIEt53oLZQCYStPrFa20Osv ipLWq+VAgkAWr594L+OnkbjIdFaXSLkULZkPafbiZOAmB9EFnJ+rvOR5XXPeS+ZX7xbfnlT XOGi/zPN4NKP04OTeiXqLnBA7GAKj44zeYTZHhIZ1V0wZg+SsSBx5IyavLJT85FSH9ttC3L 4dxlpVprv8MA1PuKuEZXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:AqHOgVVX+y0=:B8q+TZxxW9+ZlLavJHWFR8 pEceui2aTUh26zlW+xBgOx0G7dHnGQQMfoPUF8GXsEYOsIT6jN17GozNqP8Z5mmYDGMP3noci AMXB77xut11DU6ziMNU/Q0ShyS57Hd2YqfMIJ6i0H/2kMog2UA6kas+3rzOe9UnJrgKQH0dvz BnctwvuA/LYgBy9x/RSv8yUooWPhlf8H2LhT5+99P/Ofhg42aDkTiO70nH4qG4NGkXC6MQyeP TWRKLpqXHgkZ0ZstzGrIXa2TNqQa3M3rw3R2EyKvZz/DloxDOqqtDpRJ8pGT7OdY4GMjgI/3J GzWNbkBeYZKyZB8491ZWxx+NZoWCgnvZWvhwxv781jgCyEjE26yKwq6KDGxIXsQOycN3DW6BC s3VVCaqQgza18AkX7ShpxSs3cW0BEdft7CsvyWnUnnuEWTv7l4GACSZUoboKJii5Kbe4MnhTR 2bqbt5pk2BiSDIEZh3AWMmpnTfkFsmjM+PCDe4KRO+vSOXtyYlzv/UUJc2wkmuLETfusg0Tr6 oD/8nL/4X3lH/qHv70RBwU0gAmfcNgAb8bxi3wo5NyDJ/2D8aTItMULA2AWrJvD4a4lNxh1PU Oj+mTkO/KSxIle8/M8LmgFgS/743LP/S2F8kCdcNnmuyufXqnYaYPhtbmYZhx4a7Ltgm0Am6U KVFGw+U10ufMPNCQBj7zYeRebTMXTFpgJroasm9jOTVJKRThLHIKOEjW4UlK/SG3RLdnr+0zD wIkP8zzJHITC3/yivxvOajYL4T7FPW9Bm2Pdkrhj2gp4oHrESv1cN07rAPlMfT8O+NlM3aYP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205119 Archived-At: [Continued] 2.3) Though what we're considering is how undesirable it would be to restrict a user from using shell built-ins, what I feel would be much more useful and natural for users would be to be enable them to use their personal shell aliases and functions. Under the current dired implementation this is impossible. In diredc, it is possible for persistent asynchronous commands (the default for '&') because diredc opens an interactive shell buffer and uses function comint-send-input instead of using emacs shell-* commands. This would be an argument for me not to perform the constraint check as currently written because function executable-find wouldn't find them. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0