From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Tue, 27 Apr 2021 15:32:53 -0400 Message-ID: <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40133"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 48072@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 27 21:34:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbTTV-000AAN-Dt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 21:34:25 +0200 Original-Received: from localhost ([::1]:39564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbTTU-0008K8-H7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 15:34:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbTT8-0008AS-98 for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbTT8-00048s-0r for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbTT7-0005qs-UT for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Apr 2021 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161955198422429 (code B ref 48072); Tue, 27 Apr 2021 19:34:01 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 27 Apr 2021 19:33:04 +0000 Original-Received: from localhost ([127.0.0.1]:50976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTSC-0005ph-Km for submit@debbugs.gnu.org; Tue, 27 Apr 2021 15:33:04 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:45089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTSA-0005ov-Hr for 48072@debbugs.gnu.org; Tue, 27 Apr 2021 15:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619551976; bh=sEoebJbM/Cta5X/dynGQaZj2Y81nPYzkwXO8QcIMylA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=NmbxsJAXhqp8FVtNu8JRFsQvr7RVEhAZvGiyxPRYzFVlthmJ/4jzJ+ZmRVeoqbato z3Rqz4/rk0iH3yW1EfBbN6ww2p2kl7T24iSTvhnld4DrkM/o6zXnC+otvl5hNY/m2G jHhUlbBWhl7WrNdCM+itj/y1AkiKVaq2rJihwess= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N1wll-1lQnDN0Mu1-012INy; Tue, 27 Apr 2021 21:32:56 +0200 Content-Disposition: inline In-Reply-To: <83lf93h6x1.fsf@gnu.org> X-Provags-ID: V03:K1:JNuWEAxrtRLJ0tM/QZrf1pecZfWjadWUNEqN7jQkUwY8/ra8Z+F s/zloPRdvuTpZPTOyvfsF/Ac2SkIWDOlMHEROKUEnRvMM549NnMqeD3bu5s7NBSSn2Ym7dC OIbJarhojes3BGa3v6uuk/nlpLg1Xp+/zWY8MBdcM5WlUfbRAOzIAd2iCv+fGLGJ9fIAjJf xcpok9S/2oKITeVSCBG7Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:BaFyEY+7lB8=:xUJ4VLxLRkpTMG+uNjyih1 zpydGyhIqu5tkOe9jeGagdlgeH9wtlDPMLNYzmjbwOt5J3dMexQJisSJz0cBbdegVXYNzomp4 pJO4FO+7KvAQW8vJlCWawAKyIO6iSxjo0Ztihz0VMB/ZoqY+0RrYVU+JhaJvf4I7nq7x/jHaL 0BEDb8TrBXPuzz6QfiXvQbJP4fs1HN/XcOxCQeHUUbCcCfw0dBsHMl7bXSpVdlv+r4ssBwMIS Fjhsvazob52XkNVLJBS1PVFOMFC7ozopjKzdjus+35+tJ0I+MEEySqAHbFk0v5SIeNDM/W8Rf Ir3Il036re8z2cOQS4SlTfJhooErbNbOCAQLR6zfYWYVV+7B+GJSRQ/Z377xMMCLl8Ep5bbHK U++cf7W580JEYtjXoLQTq4463qDBQgpmSap5DAnboAsqsqiQxDRVFsAp2pDvEkWuRu4kJqtS5 /kCBQ5J00zeQ6k+sFzj3g+fGQqDzDLgGV0Vc9YI6pcLjhJKnCcas3NavsNT/VjCABvi/yxIzE ORqvQ5wPtUsIxkGjeco8mr2x81EHiVEhnP0N0vh71pSjKI3SkUsYjWFYGwtNAG6jh/SMZ2C5Y sBjJYXtqFp2T9JYYc5KojNViUK2DYR5A2me8aK1/2Y4csSQVvyTsJK4/1PqzF30WERSwFiQX6 Vj/pCivUL8EEDtwP9pOnRFDCvV/ylvE2YM3DJYvlEh/9s7E/b3P0Jc9nU7WsZkMxYYtU/II2E wGZMKM9/vdDu+Pi/oNh86v2rd3qUf4Gcse3USEEpZpGPDyKyYwEokFnHisEl15jIIwjqdSEZ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205053 Archived-At: On 2021-04-27 22:19, Eli Zaretskii wrote: > > Date: Tue, 27 Apr 2021 15:02:43 -0400 > > From: Boruch Baum > > > > Function dired-read-shell-command was accepting an empty input. This i= s > > a bug because it then passes the empty input as a legitimate command > > which is silently processed (in error) by dired, eventually to return = a > > completion message. > > I'm not sure we want to disallow this. Well, that's not anything for me to respond to. > (Wasn't there a similar discussion recently?) I don't follow the mailing lists, so I have no idea. > > validates the entered command as a valid shell executable. > > This is certainly a mistake: a valid shell command doesn't have to be > a file that executable-find is able to find. Shells are known to > support all kinds of internal and magic commands. My testing indicates otherwise. > > Thanks. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0