From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Date: Wed, 14 Apr 2021 23:31:47 -0400 Message-ID: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="wrvhv2sruki3lcpk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26328"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 To: 47784@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 15 05:32:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWsjn-0006m4-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 05:32:15 +0200 Original-Received: from localhost ([::1]:49374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWsjm-0007oL-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 23:32:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWsjb-0007o9-TU for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWsjb-0008EJ-Lu for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWsja-0006H5-IW for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 03:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Emacs Bug Reporting Original-Received: via spool by submit@debbugs.gnu.org id=B.161845752024109 (code B ref -1); Thu, 15 Apr 2021 03:32:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 03:32:00 +0000 Original-Received: from localhost ([127.0.0.1]:36116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWsjX-0006Gn-Ve for submit@debbugs.gnu.org; Wed, 14 Apr 2021 23:32:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:50984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWsjT-0006Gb-Su for submit@debbugs.gnu.org; Wed, 14 Apr 2021 23:31:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWsjT-0007nb-L2 for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:31:55 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:42781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWsjR-00086Z-J5 for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618457510; bh=gemglBM5BHijUNyGkO439gw2idxnkfQnDv8DthDZN/g=; h=X-UI-Sender-Class:Date:From:To:Subject; b=KrDVUtUgKC/nmRkmqiWrAFY78Oz7tI2BKR1Tc1LbrjicYF9OXAKQxlDy60ekTlo40 f9sat7xnAtEp3dQxlzZUFAkdc8jgY9sU20k6qusYK2KBKe4s5LC2cn9YbhPnLxvWKH UYYFi/2A33r726u2ya+241nxfGltH3m+NYx4HZOc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2V0B-1lfrWk3gch-013uHT for ; Thu, 15 Apr 2021 05:31:50 +0200 Content-Disposition: inline X-Provags-ID: V03:K1:2pso4Vtrv1z4bx8ryyYvHrKB9FS6by7Ri0QZ+dhFeNlWTtuMsR0 PMZ1e6palwTE4elx8934zZN/33TLfdn8/VbTk3vLiXbfdpKSPIz9+Ch2DuHme0wPzJidKgF h/juM7TDBJeTPnkqR1FTEZGuXZGb545BY9VVxurw+scXWvN4GqOf1IIgg/RYrsWEtVzQcRl WaxJx6YWXVuGCqazYmNKA== X-UI-Out-Filterresults: notjunk:1;V03:K0:kI6Qi9ZLRZk=:TF6sZ45w+C9gw3sxIehHrq jtsMy8DrUP5QPJQTLnGYe7kAl/lpyj/+OHSWfQQS4aabffOWYjfDT54urry+G8+I/s0M6da6U OEXBgVCteTUeE1r8sp+5Zp4F7JW9Ub1cT5nO11Dg8HfUsIp0ZJb0SXAv3D1BtVjKKEbrNEeYN 6FDlMOC73xIBw+ibEoozk3/2cRADdRYgH/4kr8zvtnKj7DmGF+ainKEiM1naWqYBoTm+j3SCr wcS/PfcoGqffFxMV4LLV1aumk/A0pk1UIK2zqvND7Hw58a6t55tK1+/7bmiCxN6e1vMgRbLAv pjs7atFfOa/b6U0lR7ehd12SLgBsfKBNrvAMai7yEhLZEmQhfoW+irq73U6dTBm9TpiZA2SV7 uiuKy01NhoQ+49kTN2Cq9WlAo1MhQU8xzSsQUr1Kx5uYIDymMP4E6TW3/RCSc+QlYj/ids3mX J77VuM84+uLdDV6wQIvCBVS8zWQe9WEaQmBeaadXwIDDmYzHRc7tZUvxBeUdvhv7dW3lQngqs jNd7GGQwft/i5M5nxMh8xKN2FX9VD+HqgE/edUeewmALdrLQicTwwihUjTd/pXpKumFYChWKk hlQalLiRQCM4nIe/7mp51Q55xBBZ2rx7Q2KHUOvKmc/S4Wnn6lMRpNP57XRUWwCt8zJrk5PGE i7SY5SlZ2Ra2ySaXg19lm+z3ygg5N8zZqgZN5WV3ZaYMCDkfqrYg0Qd6jjkp54BSXZQyHlh/s b6K/u/zGpl4kIRonSfLtjIikVArgTJ+mfX/47pH40qlPZGfURhga+Jo8o7ixRc06SLxfq5GY Received-SPF: pass client-ip=212.227.17.20; envelope-from=boruch_baum@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204040 Archived-At: --wrvhv2sruki3lcpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Two patch files are attached. + ses-header-row.patch + Function `ses-set-header-row' was determining the current row based upon variable `ses--curcell', but that variable is NIL until one begins an operation on a cell (eg. keybindings '=3D', '"'), so navigating to a row was insufficient to select that row, and further generated an ERROR because the code was not expecting a NIL value for variable `ses--curcell' + Using function `user-error' instead of `error' doesn't spawn a debug session and backtrace buffer when variable `toggle-debug-on-error' is set. + ses-user-error.patch + Quasi-randomly replaces some calls to function `error' with `user-error'. + There could be many other desirable points of replacement, but these were some obvious ones, and without knowing whether the patch would be accepted at all, it's what I invested. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --wrvhv2sruki3lcpk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ses-header-row.patch" diff --git a/ses.el b/ses.el index a2e6033..06a3d51 100644 --- a/ses.el +++ b/ses.el @@ -3457,7 +3457,9 @@ With a \\[universal-argument] prefix arg, prompt the user. The top row is row 1. Selecting row 0 displays the default header row." (interactive (list (if (numberp current-prefix-arg) current-prefix-arg - (let ((currow (1+ (car (ses-sym-rowcol ses--curcell))))) + (let* ((curcell (or (ses--cell-at-pos (point)) + (user-error "Invalid header-row"))) + (currow (1+ (car (ses-sym-rowcol curcell))))) (if current-prefix-arg (read-number "Header row: " currow) currow))))) --wrvhv2sruki3lcpk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ses-user-error.patch" diff --git a/ses.el b/ses.el index 06a3d51..f7893de 100644 --- a/ses.el +++ b/ses.el @@ -2252,7 +2252,7 @@ Based on the current set of columns and `window-hscroll' position." names))))) (if (string= s "") - (error "Invalid cell name") + (user-error "Invalid cell name") (list (intern s))))) (let ((rowcol (ses-sym-rowcol sym))) (or rowcol (error "Invalid cell name")) @@ -3380,7 +3380,7 @@ buffer." ((derived-mode-p 'ses-mode) ses--local-printer-hashmap) ((minibufferp) ses--completion-table) ((derived-mode-p 'help-mode) nil) - (t (error "Not in a SES buffer"))))) + (t (user-error "Not in a SES buffer"))))) (when local-printer-hashmap (let ((ses--list-orig-buffer (or ses--list-orig-buffer (current-buffer)))) (help-setup-xref @@ -3414,7 +3414,7 @@ buffer." ((derived-mode-p 'ses-mode) ses--named-cell-hashmap) ((minibufferp) ses--completion-table) ((derived-mode-p 'help-mode) nil) - (t (error "Not in a SES buffer"))))) + (t (user-error "Not in a SES buffer"))))) (when named-cell-hashmap (let ((ses--list-orig-buffer (or ses--list-orig-buffer (current-buffer)))) (help-setup-xref --wrvhv2sruki3lcpk--