From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alyssa Ross Newsgroups: gmane.emacs.bugs Subject: bug#45095: [PATCH] lisp/progmodes/compile.el: only use comint-term-environment under comint Date: Mon, 7 Dec 2020 09:04:51 +0000 Message-ID: <20201207090450.2225-1-hi@alyssa.is> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35394"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alyssa Ross To: 45095@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 07 10:06:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmCTD-00090v-Si for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 10:06:12 +0100 Original-Received: from localhost ([::1]:55300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmCTC-0004HD-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 04:06:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCT4-0004EL-J5 for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmCT4-0002DA-Bv for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmCT4-000495-6h for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alyssa Ross Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 09:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160733192615890 (code B ref -1); Mon, 07 Dec 2020 09:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Dec 2020 09:05:26 +0000 Original-Received: from localhost ([127.0.0.1]:52368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCSU-00048E-25 for submit@debbugs.gnu.org; Mon, 07 Dec 2020 04:05:26 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCSS-000485-NT for submit@debbugs.gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCSS-0003cv-DR for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCSQ-0001uO-Aq for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DE9215C013A for ; Mon, 7 Dec 2020 04:05:19 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 04:05:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=fN6EVBNYtUwlutBjyjvSLvW0aL SQDMa+pyJnUIy+9ws=; b=O38bITqKytL0n5/tvTwOfAWJQyQm4Qv58wiI4+Ls+Y K8ejuouhISKLq3CwnwbyRTvTMPZAx8gv41Ot1pIhJltgZEHgUCeCq9cMFfCRqEZN JdDSc5vSBmDCRP4rGFoR0iXPtaMdNfm6WtPymnzbjJYQWS/+mbZxKv6CEVPPfvcq lt7pPxeN1dbcVbY1RHV3DOvcGCBKK1cXLLD2LH8ZoE8+LJ4bGt1OVGQTEKyRJgGS ldLzvJPNl8efsC69kSM1LDrFRqby0XoVLoS285wTmLZWxCaLT3BteCuZo5lsouqX wbI4b7abbmYLwasSZezggiioLsETrGvOj6ezIUhh4AaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fN6EVBNYtUwlutBjy jvSLvW0aLSQDMa+pyJnUIy+9ws=; b=H44oLGVyCFcsH68uX2qSp+5k0bI6EgXcD uW70TZDWFxHJQtiyV2bxtgzREio8BHVU8uyBM9eoPsbOMiJpHx5tGXqu7urHdtwU 0UHlUrN2gqXmA1/JC48D3zxcMwsyuyEnRHLUnEdviSzr4Py/1/mR4ZYwlRQaFF5N rn8Negivv9SywmHjIoCWItGwn4kLHHtpHt0kheGQ6Gfxr2G3a+kkNYSZE9Y3LOZh cgdImhLBwCBskHVtBfmeNPNWs5YWnNrNYnZy6HlsSso/4G9TqGTkB5KWrWtMSrG9 UPGWpTiDrTyCoMPlDQK2qVGAD0o6+e0oJ3zD9jWpn3H1Ke5VH2dTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejfedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucggtffrrghtthgvrhhnpeehvdffgffhteeijefgteeftdfghfdvheeuhedvjedugf eggfeljefgleefvefgfeenucfkphepgeeirddukeefrddutdefrddujeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvghvvg drqhihlhhishhsrdhnvght X-ME-Proxy: Original-Received: from eve.qyliss.net (unknown [46.183.103.17]) by mail.messagingengine.com (Postfix) with ESMTPA id 910AA108005C for ; Mon, 7 Dec 2020 04:05:19 -0500 (EST) Original-Received: by eve.qyliss.net (Postfix, from userid 1000) id 36E6A1092; Mon, 7 Dec 2020 09:05:18 +0000 (UTC) X-Mailer: git-send-email 2.27.0 Received-SPF: softfail client-ip=66.111.4.27; envelope-from=qyliss@eve.qyliss.net; helo=out3-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195212 Archived-At: comint-term-environment is used for configuring the environment for terminal output under comint. If compile is being used with a different major mode, that mode probably can't handle the fancy terminfo output that comint can, so comint-term-environment should only be used under comint or a derived mode. ; Tested with emacs -Q as follows: ; ; (1) Set comint-terminfo-terminal to "dumb-emacs-ansi", provided by ; recent ncurses: ; ; (setq comint-terminfo-terminal "dumb-emacs-ansi") C-x C-e ; ; (2) Verify that no uninterpreted control characters are displayed by ; (compile "grep --color=auto Emacs README") C-x C-e ; ; (3) Verify that grep knows it can output color when using comint: ; (compile "grep --color=auto Emacs README" t) C-x C-e ; ; Prior to this change, grep in (2) would output control characters, ; which would be displayed uninterpreted in the buffer. --- I haven't got my copyright papers sorted yet, so hopefully this change is also small enough that that doesn't matter. lisp/progmodes/compile.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 787f5d5ef3..b4bcc3f2d2 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1868,7 +1868,8 @@ compilation-start (let ((process-environment (append compilation-environment - (comint-term-environment) + (when (derived-mode-p 'comint-mode) + (comint-term-environment)) (list (format "INSIDE_EMACS=%s,compile" emacs-version)) (copy-sequence process-environment)))) (set (make-local-variable 'compilation-arguments) -- 2.27.0