From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped. Date: Sun, 22 Nov 2020 17:08:30 +0000 Message-ID: <20201122170830.GD5912@ACM> References: <20200923144824.GD6178@ACM> <20200924102022.GA4714@ACM> <20201119211822.GE6259@ACM> <20201122131231.GB5912@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32741"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43558@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 22 18:09:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgsrb-0008RC-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 18:09:23 +0100 Original-Received: from localhost ([::1]:34784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgsrZ-0000Ft-NV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 12:09:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgsrG-0000EC-8R for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 12:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgsrF-0004ul-T3 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 12:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgsrF-0001aR-Ma for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 12:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2020 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43558-submit@debbugs.gnu.org id=B43558.16060649206066 (code B ref 43558); Sun, 22 Nov 2020 17:09:01 +0000 Original-Received: (at 43558) by debbugs.gnu.org; 22 Nov 2020 17:08:40 +0000 Original-Received: from localhost ([127.0.0.1]:48188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgsqu-0001Zm-ET for submit@debbugs.gnu.org; Sun, 22 Nov 2020 12:08:40 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:30423 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1kgsqr-0001ZT-BV for 43558@debbugs.gnu.org; Sun, 22 Nov 2020 12:08:38 -0500 Original-Received: (qmail 28824 invoked by uid 3782); 22 Nov 2020 17:08:30 -0000 Original-Received: from acm.muc.de (p2e5d52bc.dip0.t-ipconnect.de [46.93.82.188]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 22 Nov 2020 18:08:30 +0100 Original-Received: (qmail 11810 invoked by uid 1000); 22 Nov 2020 17:08:30 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193856 Archived-At: Hello, Stefan. On Sun, Nov 22, 2020 at 10:20:32 -0500, Stefan Monnier wrote: > > Because syntax-table text properties are already used for so many > > different things in CC Mode (I think the count is five in C++ Mode). > > Adding another one would mean having to scan for this rare construct at > > every buffer change, and this would slow things down, possibly a lot. > The fact that you already have 5 other such uses implies that the slow > down from this one cannot possibly be larger than 20% (since the scan > for it is very simple, I doubt any of the other 5 is simpler). The fact remains that an implementation at the C level is objectively better than one at the Lisp level. > Most major modes have such things and we live just fine with them. > This is a non-issue. Really? Are there any other programming language modes whose comments syntax.c cannot handle without syntax-table text properties? > Stefan -- Alan Mackenzie (Nuremberg, Germany).