From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Itai Seggev Newsgroups: gmane.emacs.bugs Subject: bug#43878: patch for 43878 Date: Fri, 20 Nov 2020 14:19:09 -0600 Message-ID: <20201120201909.GA47328@knuth.cs.hmc.edu> References: <20201009062445.GA13478@knuth.cs.hmc.edu> <20201116205311.GA1046@knuth.cs.hmc.edu> <87eektvuwx.fsf@gnus.org> <20201117183610.GB1046@knuth.cs.hmc.edu> <20201118233415.GF1370@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6174"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Lars Ingebrigtsen , 43878@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 20 21:20:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgCtG-0001Qr-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 21:20:21 +0100 Original-Received: from localhost ([::1]:53408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgCtF-0002lV-B9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 15:20:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgCt1-0002j7-0J for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgCt0-0002nt-9L for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgCt0-0005OO-27 for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Itai Seggev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Nov 2020 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43878 X-GNU-PR-Package: emacs Original-Received: via spool by 43878-submit@debbugs.gnu.org id=B43878.160590356020657 (code B ref 43878); Fri, 20 Nov 2020 20:20:02 +0000 Original-Received: (at 43878) by debbugs.gnu.org; 20 Nov 2020 20:19:20 +0000 Original-Received: from localhost ([127.0.0.1]:44365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgCsK-0005N7-Je for submit@debbugs.gnu.org; Fri, 20 Nov 2020 15:19:20 -0500 Original-Received: from ark.cs.hmc.edu ([134.173.42.130]:47656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgCsI-0005Mo-L8 for 43878@debbugs.gnu.org; Fri, 20 Nov 2020 15:19:19 -0500 Original-Received: from knuth.cs.hmc.edu (knuth.cs.hmc.edu [IPv6:2620:102:2001:902:f069:3ff:fe3e:8a5c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ark.cs.hmc.edu (Postfix) with ESMTPS id 5EDCB64087A; Fri, 20 Nov 2020 12:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cs.hmc.edu; s=ark; t=1605903549; bh=E/ctO+qxl3dDtHm+1UFS+C0v7uY4+CU7jVmkzHx8P2E=; h=Date:From:To:Subject:References:In-Reply-To; b=Oc/lPH1/wZ+/cvOGv78/QfW5gC/MdxQSnP23JH7yTknxd4LMktT5p0b54+9NfpboO PJidNlzAjPBSwEAqOLrRy5yhE93+eV/5hZ/lxqS1R0WbtOIVTN9a95RuFwVqDArWZP tQxpS9J+ZCTkJSGZ2A3tfFoRpR6VgE0EhACC6ZFI= Original-Received: (nullmailer pid 49557 invoked by uid 13452); Fri, 20 Nov 2020 20:19:09 -0000 Content-Disposition: inline In-Reply-To: <20201118233415.GF1370@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193799 Archived-At: On Wed, Nov 18, 2020 at 11:34:15PM +0000, Alan Third wrote: > On Tue, Nov 17, 2020 at 12:36:10PM -0600, Itai Seggev wrote: > > +ifeq ($(shell uname),Darwin) > > Is $DARWIN_OS available in the Makefile? Not as far as I can tell. But here's a revised patch that is both more targeted and only using autoconf variables: diff --git a/src/Makefile.in b/src/Makefile.in index c5fb2ea3ab..02d50bb7ca 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -336,6 +336,10 @@ DUMPING= CHECK_STRUCTS = @CHECK_STRUCTS@ HAVE_PDUMPER = @HAVE_PDUMPER@ +## ARM Macs require that all code have a valid signature. Since pump +## invalidates the signature, we must re-sign to fix it. +DO_CODESIGN=$(patsubst @configuration@,aarch64-apple-darwin%,yes) + # 'make' verbosity. AM_DEFAULT_VERBOSITY = @AM_DEFAULT_VERBOSITY@ @@ -653,6 +657,9 @@ temacs$(EXEEXT): $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(W32_RES_LINK) $(LIBES) ifeq ($(HAVE_PDUMPER),yes) $(AM_V_at)$(MAKE_PDUMPER_FINGERPRINT) $@.tmp +ifeq ($(DO_CODESIGN),yes) + codesign -s - -f $@.tmp +endif endif $(AM_V_at)mv $@.tmp $@ $(MKDIR_P) $(etc) -- Itai In 1997 a group of programmers started writing a desktop environment to fix a travesty they didn't create. Their program promptly found its way onto un*x systems everywhere. Today, still opposed by a software monopolist, they survive as soldiers of fortune. If you share their vision, if you know you can help, and if you can connect to internet, maybe you can join... the K-Team.