unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44284@debbugs.gnu.org
Subject: bug#44284: 27.1; with some Unicode font, scrolling upward with the mouse wheel actually scrolls downward when the cursor needs repositioning
Date: Sun, 1 Nov 2020 22:13:26 +0100	[thread overview]
Message-ID: <20201101211326.GQ27593@zira.vinc17.org> (raw)
In-Reply-To: <834km8gbiv.fsf@gnu.org>

On 2020-11-01 20:47:04 +0200, Eli Zaretskii wrote:
> > 3. The fact that row->phys_ascent > row->ascent in compute_line_metrics
> > yields an incorrect behavior. This is about the following comment:
> > 
> >       /* If first line's physical ascent is larger than its logical
> >          ascent, use the physical ascent, and make the row taller.
> >          This makes accented characters fully visible.  */
> 
> This is not a bug, we must keep that code.  It just isn't supposed to
> fire in your case.

For this one, I meant that if the first row is made taller for some
good reason, then this shouldn't yields recentering when scrolling
upward with the mouse wheel, and (move-to-window-line -1) should put
the cursor on the last fully visible display line of the window, as
documented.

Solving (2) would no longer trigger this code in my case, but you
should make sure that this code, which is still useful in some other
cases, behaves correctly with various Emacs features.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)





  reply	other threads:[~2020-11-01 21:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 16:36 bug#44284: 27.1; with some Unicode font, scrolling upward with the mouse wheel actually scrolls downward when the cursor needs repositioning Vincent Lefevre
2020-10-28 16:44 ` Vincent Lefevre
2020-10-28 16:53 ` Eli Zaretskii
2020-10-30 10:52   ` Vincent Lefevre
2020-10-30 11:31     ` Eli Zaretskii
2020-10-30 13:33       ` Vincent Lefevre
2020-10-30 13:37         ` Eli Zaretskii
2020-10-30 16:31           ` Vincent Lefevre
2020-10-30 20:34             ` Vincent Lefevre
2020-10-30 20:57               ` Vincent Lefevre
2020-10-30 21:09                 ` Eli Zaretskii
2020-10-30 23:00                   ` Vincent Lefevre
2020-10-31  0:46                     ` Vincent Lefevre
2020-10-31  1:13                       ` Vincent Lefevre
2020-10-31  7:38                         ` Eli Zaretskii
2020-10-31 22:43                           ` Vincent Lefevre
2020-11-01  0:24                             ` Vincent Lefevre
2020-11-01  0:28                               ` Vincent Lefevre
2020-11-01 16:15                                 ` Eli Zaretskii
2020-11-01 16:15                               ` Eli Zaretskii
2020-11-01 17:32                                 ` Vincent Lefevre
2020-11-01 17:43                                   ` Eli Zaretskii
2020-11-01 18:34                                     ` Vincent Lefevre
2020-11-01 18:47                                       ` Eli Zaretskii
2020-11-01 21:13                                         ` Vincent Lefevre [this message]
2020-11-07  8:29                                         ` Eli Zaretskii
2020-11-07 10:35                                           ` Vincent Lefevre
2020-11-07 13:22                                             ` Eli Zaretskii
2020-11-01 15:55                             ` Eli Zaretskii
2020-11-01 17:26                               ` Vincent Lefevre
2020-10-30 20:58               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101211326.GQ27593@zira.vinc17.org \
    --to=vincent@vinc17.net \
    --cc=44284@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).