From: Alan Third <alan@idiocy.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 44120@debbugs.gnu.org
Subject: bug#44120: 28.0.50; Animated GIFs sometimes leave "trails"
Date: Wed, 21 Oct 2020 21:08:42 +0100 [thread overview]
Message-ID: <20201021200842.GB47992@breton.holly.idiocy.org> (raw)
In-Reply-To: <873627jsmv.fsf@gnus.org>
On Wed, Oct 21, 2020 at 09:17:28PM +0200, Lars Ingebrigtsen wrote:
>
> M-x eww RET https://lh4.googleusercontent.com/TQ10szluPdXsKoYIeYe5ljxjVIoJzcCvLybUa3tEA24a6vISYkwiqAz9VymzgyNY_N8tfqHKvxSv9WhrcC-GvDc4uaiCE1T52y3C6xK1K--Lazicm9PSBiGxGVCyjFtDTBJaEOuExA
>
> will give you an animated GIF that displays the problem: It seems like
> when repainting, the previous area that has changed isn't reset... or
> something.
>
> We're probably not following the GIF animation standard when applying
> the deltas?
Well, I think this is the problem:
From image.c:
/* From gif89a spec: 1 = "keep in place", 2 = "restore
to background". Treat any other value like 2. */
From the gif89a spec:
iv) Disposal Method - Indicates the way in which the graphic is to
be treated after being displayed.
Values : 0 - No disposal specified. The decoder is
not required to take any action.
1 - Do not dispose. The graphic is to be left
in place.
2 - Restore to background color. The area used by the
graphic must be restored to the background color.
3 - Restore to previous. The decoder is required to
restore the area overwritten by the graphic with
what was there prior to rendering the graphic.
4-7 - To be defined.
That gif uses a disposal value of 3 quite a lot.
It looks like when a block is updated with a disposal value of 3 we
should hang onto the previous contents and then restore them in, I
guess, the next frame.
--
Alan Third
next prev parent reply other threads:[~2020-10-21 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 19:17 bug#44120: 28.0.50; Animated GIFs sometimes leave "trails" Lars Ingebrigtsen
2020-10-21 20:08 ` Alan Third [this message]
2020-10-22 12:01 ` Lars Ingebrigtsen
2020-10-22 12:14 ` Alan Third
2020-10-22 12:54 ` Eli Zaretskii
2020-10-21 20:37 ` Stefan Kangas
2020-10-22 12:02 ` Lars Ingebrigtsen
2022-04-10 15:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021200842.GB47992@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=44120@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).