From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#43973: 28.0.50; [NS] Two crashes on macOS Date: Wed, 14 Oct 2020 22:15:48 +0100 Message-ID: <20201014211548.GP60347@breton.holly.idiocy.org> References: <20201014204147.GO60347@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4076"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43973@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 23:17:45 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSo9Y-0000wB-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 23:17:44 +0200 Original-Received: from localhost ([::1]:39846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSo9X-0004TD-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 17:17:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSo8s-0004Sd-Pf for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 17:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSo8s-0007sK-8p for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 17:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSo8s-0002CJ-4X for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 17:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43973 X-GNU-PR-Package: emacs Original-Received: via spool by 43973-submit@debbugs.gnu.org id=B43973.16027101645430 (code B ref 43973); Wed, 14 Oct 2020 21:17:02 +0000 Original-Received: (at 43973) by debbugs.gnu.org; 14 Oct 2020 21:16:04 +0000 Original-Received: from localhost ([127.0.0.1]:53232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSo7v-0001PB-QD for submit@debbugs.gnu.org; Wed, 14 Oct 2020 17:16:04 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:35130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSo7r-0001DC-5V for 43973@debbugs.gnu.org; Wed, 14 Oct 2020 17:16:00 -0400 Original-Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id B08EB82D; Wed, 14 Oct 2020 23:15:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1602710152; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=1502; bh=4U3CbBDvXKzu5/Y9QJX1lRkUxDS3kbNndVsX57IDPxI=; b=dLl3w1BUYocsVV80KV99lYPVql5t4TpyCYmjVvdih8Y2Jr0cjTeAO4tuqlmZTKhy fvylus87NMgA2AnilKeCAMEzUST8VKWF0/WnpqLRx0PEtvGhrSYugoIYcqu3i9wCzpc RxpE0Q8rxprzRHehnIq2lsv9gcBrJ9h7hVHM8t0TM9Q4LQ78MyuR8ONj0m5myk9DQYb IiNVCV7GonmaT/oKvVXenxAKZ2TwJrQWJHPTsVmGQkmitTaLqve/SN5Yvh5Vlrec2ED xSJIhTw4sA8w5QPmhaNjoT5m2QcbISGURQfsZamj8jg+FjmWt7e+TjTAAdXR0JkVpHF POqMX4zTbQ== Original-Received: by smtp.mailfence.com with ESMTPA ; Wed, 14 Oct 2020 23:15:49 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 52F1D2025FAC0D; Wed, 14 Oct 2020 22:15:48 +0100 (BST) Mail-Followup-To: Alan Third , Andrii Kolomoiets , 43973@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190528 Archived-At: On Thu, Oct 15, 2020 at 12:01:17AM +0300, Andrii Kolomoiets wrote: > Alan Third writes: > > > On Tue, Oct 13, 2020 at 10:35:28AM +0300, Andrii Kolomoiets wrote: > >> (make-frame `((parent-frame . ,(selected-frame)) > >> (width . 0.5) > >> (height . 0.5) > >> (top . 0.5) > >> (left . 0.5)))| > > > > Out of interest, does the frame need to be smaller than default for > > the crash to happen? For example if width is 1 does it still crash? > > The frame must be small enough to not all the toolbar buttons fits the > toolbar: > > (setq test-frame (make-frame `((parent-frame . ,(selected-frame)) > (width . 41)))) > > The last button (isearch) is replaced by ">>". Funnily enough that ">>" is what I was looking at. I guess it's a toolkit image and not something we provide with Emacs...? > There are no crash if '(width . 42)'. Can you try this: modified src/nsmenu.m @@ -1207,7 +1207,7 @@ - (BOOL) changed enablement == prevEnablement ? NO : YES; } -- (void) addDisplayItemWithImage: (EmacsImage *)img +- (void) addDisplayItemWithImage: (NSImage *)img idx: (int)idx tag: (int)tag helpText: (const char *)help modified src/nsterm.h @@ -561,7 +561,7 @@ #define NS_DRAW_TO_BUFFER 1 - (void) clearActive; - (void) clearAll; - (BOOL) changed; -- (void) addDisplayItemWithImage: (EmacsImage *)img +- (void) addDisplayItemWithImage: (NSImage *)img idx: (int)idx tag: (int)tag helpText: (const char *)help -- Alan Third